[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master|RESOLVED --- Comment #13 from Lucas Gass --- Missing 22.05.x dependencies, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Katrin Fischer changed: What|Removed |Added Attachment #140604|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 141498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141498&action=edit Bug 31252: Advanced search in staff interface should call barcodedecode if the search index is a barcode We should run any inputted barcode through barcodedecode before passing it to any subroutines. This was missed during the initial development of bug 26351. Test Plan: 1) Set itemBarcodeInputFilter to "Remove spaces from" 2) Browse to the staff side advanced search 3) Run a barcode search for "MY TEST" 4) Note the message returned is: No results match your search for 'bc,wrdl: "MY TEST"'. 5) Apply this patch 6) Restart all the things! 7) Repeat your search 8) Note the message returned is: No results match your search for 'bc,wrdl: "MYTEST"'. 9) Note the lack of the space between MY and TEST! Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31707 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 --- Comment #10 from David Nind --- Thanks Kyle and Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 --- Comment #9 from Katrin Fischer --- Sorry, maybe too many comments from me here :) You'll have to read them all: (In reply to Katrin Fischer from comment #5) > I just ran into a case where the library has barcodes with trailing spaces > from a batch of faulty barcode labels. Could it be an option to add the > ItemBarcodeInputFilter into the item edit form too? (just wondering if you > have an opinion about this, totally a separate bug) Yep, totally a separate bug ;) (In reply to Katrin Fischer from comment #4) > I did some more research and it looks like we already use the filter like > that in a lot of places. If there is an issue with libsuite8 we should > probably move it to a separate bug. Again agreed ;) I am ok to move on with this patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Kyle M Hall changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #8 from Kyle M Hall --- Katrin, I think both the issue with the libsuite8 filter, and adding an option to add the ItemBarcodeInputFilter into the item edit form deserve their own bug reports! (In reply to Katrin Fischer from comment #3) > Looking at this again... the libsuite8 conversion is an odd one: > > IMS-b-126 searches for: CPL-IMS-b--126 => Where is the branchcode suddenly > coming from? > > This should not happen, IMS-B-125 should stay identical on conversion? > > t/Circulation_barcodedecode. > 'libsuite8' => ['b000126', 'b12', 'B0126', 'IMS-B-126', > 'ims-b-126','CD024','00123','11998'], > 'libsuite8' => ['IMS-b-126', 'IMS-b-12', 'IMS-B-126', 'IMS-B-126', > 'ims-b-126','IMS-CD-24','IMS-b-123','IMS-b-11998'], > > Can you have a look please? That's out of scope -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 David Nind changed: What|Removed |Added Status|Signed Off |In Discussion CC||da...@davidnind.com --- Comment #7 from David Nind --- Patch still applies and have signed off, as everything works as per the test plan. Have changed status to 'In Discussion' as I think Katrin's comments need addressing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 David Nind changed: What|Removed |Added Attachment #138202|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 140604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140604&action=edit Bug 31252: Advanced search in staff interface should call barcodedecode if the search index is a barcode We should run any inputted barcode through barcodedecode before passing it to any subroutines. This was missed during the initial development of bug 26351. Test Plan: 1) Set itemBarcodeInputFilter to "Remove spaces from" 2) Browse to the staff side advanced search 3) Run a barcode search for "MY TEST" 4) Note the message returned is: No results match your search for 'bc,wrdl: "MY TEST"'. 5) Apply this patch 6) Restart all the things! 7) Repeat your search 8) Note the message returned is: No results match your search for 'bc,wrdl: "MYTEST"'. 9) Note the lack of the space between MY and TEST! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #4 from Katrin Fischer --- I did some more research and it looks like we already use the filter like that in a lot of places. If there is an issue with libsuite8 we should probably move it to a separate bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 --- Comment #5 from Katrin Fischer --- I just ran into a case where the library has barcodes with trailing spaces from a batch of faulty barcode labels. Could it be an option to add the ItemBarcodeInputFilter into the item edit form too? (just wondering if you have an opinion about this, totally a separate bug) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer --- Looking at this again... the libsuite8 conversion is an odd one: IMS-b-126 searches for: CPL-IMS-b--126 => Where is the branchcode suddenly coming from? This should not happen, IMS-B-125 should stay identical on conversion? t/Circulation_barcodedecode. 'libsuite8' => ['b000126', 'b12', 'B0126', 'IMS-B-126', 'ims-b-126','CD024','00123','11998'], 'libsuite8' => ['IMS-b-126', 'IMS-b-12', 'IMS-B-126', 'IMS-B-126', 'ims-b-126','IMS-CD-24','IMS-b-123','IMS-b-11998'], Can you have a look please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 --- Comment #2 from Katrin Fischer --- I like this, but I was a little worried it could create problems with the other barcode filters. So what happens if the barcode is not scanned but for example copied from a report or from the items table (already being converted?) Are we sure the existing filters will not "double-convert" those? So I have tested (looking at the test for the barcode filters): libsuite8 Unconverted: b000126 searches for: Converted: IMS-b-126 searches for: CPL-IMS-b--126 --> unwanted conversion This is odd, because the test covers this and they should actually be the same? The additional space should not upset Koha, so we can probably ignore this. Also tested CueCat, T, EAN etc. and it looks good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Emmanuel Bétemps changed: What|Removed |Added CC||e.bete...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Kyle M Hall changed: What|Removed |Added Depends on||26351 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 [Bug 26351] Add plugin hooks to transform item barcodes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 --- Comment #1 from Kyle M Hall --- Created attachment 138202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138202&action=edit Bug 31252: Advanced search in staff interface should call barcodedecode if the search index is a barcode We should run any inputted barcode through barcodedecode before passing it to any subroutines. This was missed during the initial development of bug 26351. Test Plan: 1) Set itemBarcodeInputFilter to "Remove spaces from" 2) Browse to the staff side advanced search 3) Run a barcode search for "MY TEST" 4) Note the message returned is: No results match your search for 'bc,wrdl: "MY TEST"'. 5) Apply this patch 6) Restart all the things! 7) Repeat your search 8) Note the message returned is: No results match your search for 'bc,wrdl: "MYTEST"'. 9) Note the lack of the space between MY and TEST! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31253 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
