[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
--- Comment #8 from Nick Clemens ---
(In reply to Arthur Suzuki from comment #7)
> Thanks!
>
> Pushed to 21.11 for 21.11.12
This depends on 30992 which was not backported to 21.11
This means that:
reservedate is being formatted in opac-reserve.pl:
$itemLoopIter->{reservedate} = output_pref({ dt =>
dt_from_string($first_hold->reservedate), dateonly => 1 }); # FIXME Should be
formatted in the template
And is also being formatted in the template:
On hold for patron expected at [% Branches.GetName(
itemLoo.ExpectedAtLibrary ) | html %] since [% itemLoo.reservedate | $KohaDates
%]
And DateUtils dies on an unexpected date (as it has already been formatted)
Please revert
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Katrin Fischer changed: What|Removed |Added Version(s)|22.11.00,21.11, 22.05.06|22.11.00,22.05.06,21.11.12 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 --- Comment #7 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Arthur Suzuki changed: What|Removed |Added Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to stable|RESOLVED Resolution|--- |FIXED --- Comment #6 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.06 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #5 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Nice one Katrin, this is a great little improvement. Going straight for QA on this, it's clear and simple and achieves exactly what's on the tin. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Martin Renvoize changed: What|Removed |Added Attachment #138399|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 138680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138680=edit Bug 31272: Use TT plugins for pickup library and due date in opac-reserve.pl Before this patch the date formatting for the due date was done in the .pl instead of the template and the branchcode would show instead of the library's name in the list of items when placing an item level hold in the OPAC. To test: * Find or create a record with mulitple items * Check out one of the items * Place a record level hold * Return an item to set to waiting * Place an item level hold * Go to the OPAC and start placing an item level hold * Verify the messages in the item table show the branchcode * Apply patch * Only visible change should be the library name replacing the branchcode Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 --- Comment #1 from Katrin Fischer --- Created attachment 138399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138399=edit Bug 31272: Use TT plugins for pickup library and due date in opac-reserve.pl Before this patch the date formatting for the due date was done in the .pl instead of the template and the branchcode would show instead of the library's name in the list of items when placing an item level hold in the OPAC. To test: * Find or create a record with mulitple items * Check out one of the items * Place a record level hold * Return an item to set to waiting * Place an item level hold * Go to the OPAC and start placing an item level hold * Verify the messages in the item table show the branchcode * Apply patch * Only visible change should be the library name replacing the branchcode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Katrin Fischer changed: What|Removed |Added Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Katrin Fischer changed: What|Removed |Added Depends on||30992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 [Bug 30992] Hard to translate single word strings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Katrin Fischer changed: What|Removed |Added Depends on|30992 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 [Bug 30992] Hard to translate single word strings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Katrin Fischer changed: What|Removed |Added Depends on||30992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 [Bug 30992] Hard to translate single word strings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
