[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Alex Buckley changed: What|Removed |Added Version(s)|Exclude some patron |Exclude patron categories released in|categories from submitting |from submitting OPAC |OPAC purchase suggestions |purchase suggestions by |by selecting them in the|selecting them in the new |new |suggestionPatronCategoryExc |suggestionPatronCategoryExc |eptions system preference. |eptions system preference. | --- Comment #18 from Alex Buckley --- (In reply to Vinod from comment #17) > What is relevance of old purchase suggestions, why it can't be replaced with > new? Or current can be used in different way as discussed above? Hi Vinod, Are you referring to why did I add a new system preference (suggestionPatronCategoryExceptions) rather than converting the existing 'suggestion' system preference to a dropdown of patron categories ALLOWED to make suggestions? If that is what you're referring to I did not go that route for 2 reasons: Reason 1. It would have meant every time libraries added new patron categories to Koha they would have had to remember to update the system preference allowing those new patron categories to make suggestions, something easily forgotten. Whereas, adding a new system preference (suggestionPatronCategoryExceptions) defining patron categories NOT allowed to make suggestions means as new patron categories are added, by default, those patrons will be able to submit suggestions. i.e. From a library configuration perspective, I believe it is better for new patron categories to be allowed to do something by default unless explicitly denied. Reason 2: There are precedents for my approach already in Koha: - The OPACHoldsIfAvailableAtPickup and OPACHoldsIfAvailableAtPickupExceptions sysprefs. - The OpacHiddenItems and OpacHiddenItemsExceptions sysprefs. --- Also, I avoided adding a boolean flag to patron categories controlling whether they could submit suggestions, to keep all suggestion configurations managed in one place: system preferences. Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #17 from Vinod --- What is relevance of old purchase suggestions, why it can't be replaced with new? Or current can be used in different way as discussed above? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #16 from Alex Buckley --- Thank you for testing Rhonda. I can also replicate the inability to uncheck all checkboxes and save the OPACHoldsIfAvailableAtPickupExceptions syspref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Rhonda Kuiper changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #15 from Rhonda Kuiper --- I opened a bug for the problem saving system preferences where there is a drop down as in suggestionPatronCategoryExceptions when you clear all the checked options. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 ByWater Sandboxes changed: What|Removed |Added Attachment #139114|0 |1 is obsolete|| --- Comment #14 from ByWater Sandboxes --- Created attachment 139165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139165=edit Bug 31333: Unit tests Test plan: 1. Run tests (Categories.t has been updated by me, and I suggest running Suggestions.t to confirm it still passes): sudo koha-shell kohadev prove t/db_dependent/Koha/Patron/Categories.t prove t/db_dependent/Koha/Suggestions.t Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Rhonda Kuiper changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #13 from Rhonda Kuiper --- OK. I still had my sandbox available and I tested OPACHoldsIfAvailableAtPickupExceptions to see if the system would save changes when I updated from having something checked to unchecking everything. I got the same result as for the suggestionPatronCategoryExceptions preference. I would say this bug is fine and we have another problem with saving system preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #12 from Rhonda Kuiper --- I had the same thought. This might not be a problem with this bug. It might be a system preference problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #11 from Katrin Fischer --- Great testing, Rhonda. I wonder if this happens with other prefs of this type (patron category list) as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #10 from Rhonda Kuiper --- I just completed the test plan for this bug and everything was great with one exception. As stated in the test plan, I Select the patron category you're logged in as in suggestionPatronCategoryExceptions syspref. In this case 'Staff'. That is the only category I selected. I then got to the step that says 'Untick your patron category in the suggestionPatronCategoryExceptions syspref.' and that resulted in zero categories check. When I tried to save, I got the message 'Nothing to save'. I checked to OPAC and I still was not able to place a purchase suggestion even though the 'Staff' box was unticked. I then checked another category and unticked the 'Staff' box and I was able to save. On the OPAC, I was able to place a purchase suggestion. Other than the case of trying to remove all the checks from the patron types, this functioned as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Alex Buckley changed: What|Removed |Added Version(s)||Exclude some patron released in||categories from submitting ||OPAC purchase suggestions ||by selecting them in the ||new ||suggestionPatronCategoryExc ||eptions system preference. Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Alex Buckley changed: What|Removed |Added Keywords||Academy, ||release-notes-needed Status|ASSIGNED|Needs Signoff --- Comment #9 from Alex Buckley --- I've attached a patchset that introduces a new syspref: 'suggestionPatronCategoryException'. This syspref, like the existing 'OPACHoldsIfAvailableAtPickupExceptions' syspref, is a multi-choice dropdown of patron categories. Any categories selected are not affected when the 'suggestion' syspref is enabled. --- Note: 1. I deliberately chose to add a new syspref to 'exclude' categories, rather than alter the existing 'suggestion' syspref to be the multi-choice dropdown of 'allowed' patron categories because I felt the latter could create confusion for upgrading libraries. Specifically, every time they added new patron categories they may wonder why those patrons could not submit suggestions if the library had not remembered to manually allow that category to create suggestions. 2. Another conscious decision was to place the logic for checking if a patron could create a suggestion in Koha/Patron/Category.pm. The point of this enhancement is to allow/disallow patrons from placing suggestions based on their patron category. Therefore, it felt right to have that logic in Koha/Patron/Category.pm, rather than Koha/Suggestion.pm Ready for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #8 from Alex Buckley --- Created attachment 139114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139114=edit Bug 31333: Unit tests Test plan: 1. Run tests (Categories.t has been updated by me, and I suggest running Suggestions.t to confirm it still passes): sudo koha-shell kohadev prove t/db_dependent/Koha/Patron/Categories.t prove t/db_dependent/Koha/Suggestions.t Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #7 from Alex Buckley --- Created attachment 139113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139113=edit Bug 31333: Add ability to make purchase suggestions by borrower type Introduce a suggestionPatronCategoryExceptions system preference. If the suggestion syspref is enabled then libraries can stop specific borrower types from making suggestions by ticking the type in the suggestionPatronCategoryExceptions syspref. Test plan: 1. Apply patches, update database, re-start services 2. Set 'suggestion' syspref = 'Allow' 3. Confirm you can view the purchase suggestion links on OPAC biblio detail page & 'your summary' page. As well as successfully submit a suggestion. 4. Select the patron category you're logged in as in suggestionPatronCategoryExceptions syspref 5. Confirm the purchase suggestion links are hidden in the OPAC biblio detail page & 'your summary' page 6. In your browser enter the link: /cgi-bin/koha/opac-suggestions.pl e.g. http://localhost:8080/cgi-bin/koha/opac-suggestions.pl 7. Confirm a 404 page loads 8. Confirm you can view/moderate suggestions in the staff client - even though your patron is selected in the suggestionPatronCategoryExceptions syspref 9. Untick your patron category in the suggestionPatronCategoryExceptions syspref 10. Confirm you can view the purchase suggestion links on the OPAC, as well as successfully submit a suggestion. 11. Set 'suggestion' syspref = "Don't allow" 12. Confirm the purchase suggestion links are hidden in the OPAC 13. Select all patron categories in suggestPatronCategoryExceptions syspref. View the OPAC without logging in and confirm you can perform searches and view OPAC biblio detail pages. Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #6 from Alex Buckley --- Created attachment 139112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139112=edit Bug 31333: Database changes Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #5 from Vinod --- (In reply to Katrin Fischer from comment #4) > Why would it be too late? There is no reason why this should not be added. > The problem is that the sponsored code was never submitted to community, so > there was no chance to integrate it. Actually long back (4/5 year), some of the library professionals from India contributed for this development to one of the developer (l2c2.ac.in) but it is not yet done as the firm is looking for some more sponser I guess. But it is very late and many felt it was very much needed during covid situations too. Hope the new discussion will motivate the l2c2.co.in to act promptly on this feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Alex Buckley changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #4 from Katrin Fischer --- Why would it be too late? There is no reason why this should not be added. The problem is that the sponsored code was never submitted to community, so there was no chance to integrate it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #3 from Vinod --- I think it's too late to incorporate such a common feature which may be very much required by many libraries. The same has been sponsored by the Indian community too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Vinod changed: What|Removed |Added CC||amitddng...@gmail.com, ||indr...@l2c2.co.in, ||kohapa...@gmail.com, ||mishrav...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Katrin Fischer changed: What|Removed |Added CC||vinod_librarian@rediffmail. ||com --- Comment #2 from Katrin Fischer --- *** Bug 9290 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #1 from Katrin Fischer --- There is an old bug 9290 about this, that hasn't moved in quite a while. As this is assigned already, I think we can make the other a duplicate to give this a fresh start. Alex, if you prefer to keep the low bug number, just switch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Allow the ability to make purchase suggestions to be set by borrower type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
