[Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Nick Clemens changed: What|Removed |Added Depends on||29287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29287 [Bug 29287] Display of funds on acquisitions home is not consistent with display on funds page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 --- Comment #1 from Nick Clemens --- Created attachment 139829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139829&action=edit Bug 31367: Add subtotals if budget has children On bug 29287 we added child funds if a fund had no parent id It turns out funds can have a parent, and still have children (sub-sub-funds) This patch simply checks for children, rather than checking for lack of parent. Totals are already calculated correctly in GetBudgetHierarchy To test: 1 - Add a fund "Fund" to a budget - assign 1000 dollars 2 - Add a sub-fund "SubFund" - assign 100 dollars 3 - Add a sub-sub-fund "SubSubFund" - assign 10 dollars 4 - Add to a basket $5 order from SubSubFund 5 - Add to a basket $50 order from SubFund 6 - Add to a basket $500 order form Fun 7 - View acqui home - note 'SubFund' does not include total from 'SubSubFund' 8 - Apply patch 9 - Confirm all sub-sub-funds totaled in sub-funds and that fund total correctly adds sub and sub-sub funds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Nick Clemens changed: What|Removed |Added Severity|enhancement |normal Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 ByWater Sandboxes changed: What|Removed |Added Attachment #139829|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 139850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139850&action=edit Bug 31367: Add subtotals if budget has children On bug 29287 we added child funds if a fund had no parent id It turns out funds can have a parent, and still have children (sub-sub-funds) This patch simply checks for children, rather than checking for lack of parent. Totals are already calculated correctly in GetBudgetHierarchy To test: 1 - Add a fund "Fund" to a budget - assign 1000 dollars 2 - Add a sub-fund "SubFund" - assign 100 dollars 3 - Add a sub-sub-fund "SubSubFund" - assign 10 dollars 4 - Add to a basket $5 order from SubSubFund 5 - Add to a basket $50 order from SubFund 6 - Add to a basket $500 order form Fun 7 - View acqui home - note 'SubFund' does not include total from 'SubSubFund' 8 - Apply patch 9 - Confirm all sub-sub-funds totaled in sub-funds and that fund total correctly adds sub and sub-sub funds Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Martin Renvoize changed: What|Removed |Added Attachment #139850|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 140480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140480&action=edit Bug 31367: Add subtotals if budget has children On bug 29287 we added child funds if a fund had no parent id It turns out funds can have a parent, and still have children (sub-sub-funds) This patch simply checks for children, rather than checking for lack of parent. Totals are already calculated correctly in GetBudgetHierarchy To test: 1 - Add a fund "Fund" to a budget - assign 1000 dollars 2 - Add a sub-fund "SubFund" - assign 100 dollars 3 - Add a sub-sub-fund "SubSubFund" - assign 10 dollars 4 - Add to a basket $5 order from SubSubFund 5 - Add to a basket $50 order from SubFund 6 - Add to a basket $500 order form Fun 7 - View acqui home - note 'SubFund' does not include total from 'SubSubFund' 8 - Apply patch 9 - Confirm all sub-sub-funds totaled in sub-funds and that fund total correctly adds sub and sub-sub funds Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC||martin.renvoize@ptfs-europe ||.com --- Comment #4 from Martin Renvoize --- Nice fix, works as expected.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.07 released in|| CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Arthur Suzuki changed: What|Removed |Added Version(s)|22.11.00, 22.05.07 |22.11.00, 22.05.07, released in||21.11.14 Status|Pushed to stable|Pushed to oldstable CC||arthur.suz...@biblibre.com --- Comment #7 from Arthur Suzuki --- applied to 21.11 for 21.11.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC||vic...@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
