[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2024-06-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

--- Comment #18 from Owen Leonard  ---
Rebased, but comment 13 is still valid:

> With the patch
> 
> HTML customization - pub date today- Displayed - OK
> HTML customization - pub date tomorrow - Displayed - Not OK
> HTML customization - no pub date   - Displayed - OK
> News   - pub date today- Displayed - OK
> News   - pub date tomorrow - Not displayed - OK
> News   - no pub date   - Not displayed - OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2024-06-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

--- Comment #17 from Owen Leonard  ---
Created attachment 167756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167756=edit
Bug 31450: (follow-up) Add hint about empty publication date

This patch adds a hint to the additional contents form when the
user is adding a news item, "News without a publication date will
not display."

This patch also makes to extra changes: Changing the grammatically
incorrect heading "Modify an additional content" to "Modify
additional content."

The patch also splits the expiration date hint into two separate
div.hint containers for better readability.

To test, apply the patch and add a new news item. You should see
the new hint under the publication date field.

Try adding an HTML customization. The hint should not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2024-06-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

--- Comment #16 from Owen Leonard  ---
Created attachment 167755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167755=edit
Bug 31450: Remove some debug lines

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2024-06-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Owen Leonard  changed:

   What|Removed |Added

 Attachment #146925|0   |1
is obsolete||
 Attachment #146926|0   |1
is obsolete||
 Attachment #146927|0   |1
is obsolete||

--- Comment #15 from Owen Leonard  ---
Created attachment 167754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167754=edit
Bug 31450: HTML customizations and News will not display on OPAC without
Publication date

To test:
1) Create some HTML Customizations and some News items that are
   set to display on the OPAC. Create one of each: [ 'With
   publication date today', 'With publication date in the future',
   'Without publication date' ]
2) Note that news with publication date 'today' will display; with
   publication date 'in the future' will not display; with
   publication date unset will not display.
3) Note that html_customizations with date 'today' will display;
   with publication date 'in the future' will not display;
   with publication date unset will display.
4) Sign-Off

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2024-06-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-03-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Paul Derscheid  changed:

   What|Removed |Added

   Assignee|paul.dersch...@lmscloud.de  |lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-02-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #14 from Katrin Fischer  ---
Setting to failed QA - I believe if a pubdate is set, it should be respected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-02-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

--- Comment #13 from Caroline Cyr La Rose  ---
With the patch, my HTML customization with publication date in the future is
displayed.

Without the patch

HTML customization - pub date today- Displayed - OK
HTML customization - pub date tomorrow - Not displayed - OK
HTML customization - no pub date   - Not displayed - Not OK
News   - pub date today- Displayed - OK
News   - pub date tomorrow - Not displayed - OK
News   - no pub date   - Not displayed - OK

With the patch

HTML customization - pub date today- Displayed - OK
HTML customization - pub date tomorrow - Displayed - Not OK
HTML customization - no pub date   - Displayed - OK
News   - pub date today- Displayed - OK
News   - pub date tomorrow - Not displayed - OK
News   - no pub date   - Not displayed - OK

https://snipboard.io/H8rGQj.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

--- Comment #12 from Owen Leonard  ---
Created attachment 146927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146927=edit
Bug 31450: (follow-up) Add hint about empty publication date

This patch adds a hint to the additional contents form when the
user is adding a news item, "News without a publication date will
not display."

This patch also makes to extra changes: Changing the grammatically
incorrect heading "Modify an additional content" to "Modify
additional content."

The patch also splits the expiration date hint into two separate
div.hint containers for better readability.

To test, apply the patch and add a new news item. You should see
the new hint under the publication date field.

Try adding an HTML customization. The hint should not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

--- Comment #11 from Owen Leonard  ---
Created attachment 146926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146926=edit
Bug 31450: Remove some debug lines

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Owen Leonard  changed:

   What|Removed |Added

 Attachment #146914|0   |1
is obsolete||
 Attachment #146915|0   |1
is obsolete||

--- Comment #10 from Owen Leonard  ---
Created attachment 146925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146925=edit
Bug 31450: HTML customizations and News will not display on OPAC without
Publication date

To test:
1) Create some HTML Customizations and some News items that are
   set to display on the OPAC. Create one of each: [ 'With
   publication date today', 'With publication date in the future',
   'Without publication date' ]
2) Note that news with publication date 'today' will display; with
   publication date 'in the future' will not display; with
   publication date unset will not display.
3) Note that html_customizations with date 'today' will display;
   with publication date 'in the future' will not display;
   with publication date unset will display.
4) Sign-Off

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |paul.dersch...@lmscloud.de
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

--- Comment #9 from Katrin Fischer  ---
Created attachment 146915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146915=edit
Bug 31450: Remove some debug lines

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #139824|0   |1
is obsolete||
 Attachment #139825|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 146914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146914=edit
Bug 31450: HTML customizations and News will not display on OPAC without
Publication date

To test:
1) Create some HTML Customizations and some News items that are set to display
on the OPAC. Create one of each: [ 'With publication date today', 'With
publication date in the future', 'Without publication date' ]
2) Note that news with publication date 'today' will display; with publication
date 'in the future' will not display; with publication date unset will not
display.
3) Note that html_customizations with date 'today' will display; with
publication date 'in the future' will not display; with publication date unset
will display.
4) Sign-Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

--- Comment #7 from Katrin Fischer  ---
If the commit line is exactly the same, one patch will overwrite the other.
I'll fix it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #139824|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Katrin Fischer  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #6 from Katrin Fischer  ---
*** Bug 32987 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2023-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #5 from Caroline Cyr La Rose  ---
I think the obsoleted patch wasn't supposed to be?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Katrin Fischer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Failed QA

--- Comment #4 from Katrin Fischer  ---
Hi Paul, could you please check the patch? It only seems to be removing some
debug lines.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2022-09-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2022-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #139824|0   |1
is obsolete||

--- Comment #3 from Paul Derscheid  ---
Created attachment 139825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139825=edit
Bug 31450 - HTML customizations and News will not display on OPAC without
Publication date

To test:
1) Create some HTML Customizations and some News items that are set to display
on the OPAC. Create one of each: [ 'With publication date today', 'With
publication date in the future', 'Without publication date' ]
2) Note that news with publication date 'today' will display; with publication
date 'in the future' will not display; with publication date unset will not
display.
3) Note that html_customizations with date 'today' will display; with
publication date 'in the future' will not display; with publication date unset
will display.
4) Sign-Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2022-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

--- Comment #2 from Paul Derscheid  ---
Created attachment 139824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139824=edit
Bug 31450 - HTML customizations and News will not display on OPAC without
Publication date

To test:
1) Create some HTML Customizations and some News items that are set to display
on the OPAC. Create one of each: [ 'With publication date today', 'With
publication date in the future', 'Without publication date' ]
2) Note that news with publication date 'today' will display; with publication
date 'in the future' will not display; with publication date unset will not
display.
3) Note that html_customizations with date 'today' will display; with
publication date 'in the future' will not display; with publication date unset
will display.
4) Sign-Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2022-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Paul Derscheid  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2022-08-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

--- Comment #1 from Lucas Gass  ---
I see that this only happens when I do not set a "Publication date:". That
makes sense for News, but HTML customizations should not required a Publication
date or an Expiration date

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31450] HTML customizations and News will not display on OPAC without Publication date

2022-08-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Lucas Gass  changed:

   What|Removed |Added

Summary|HTML customizations and |HTML customizations and
   |News will not display on|News will not display on
   |OPAC|OPAC without Publication
   ||date

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/