[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 --- Comment #1 from Nick Clemens --- Created attachment 140461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140461&action=edit Bug 31540: Exclude expired holds from the reminder job Some libraries don't want to auto-cancel holds, but we should not remind a patron about a hold which has expired. To test: 1 - Place a hold for a patron 2 - Set it waiting 3 - Run the holds reminder script in the future perl misc/cronjobs/holds/holds_reminder.pl -day 1 --date '2023-09-12' -v 4 - Note the holds would be reminded 5 - Set expirationdate for the hold less than today UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY); 6 - Run the remidner cron again 7 - No holds trigger! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 David Nind changed: What|Removed |Added Attachment #140461|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 140605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140605&action=edit Bug 31540: Exclude expired holds from the reminder job Some libraries don't want to auto-cancel holds, but we should not remind a patron about a hold which has expired. To test: 1 - Place a hold for a patron 2 - Set it waiting 3 - Run the holds reminder script in the future perl misc/cronjobs/holds/holds_reminder.pl -day 1 --date '2023-09-12' -v 4 - Note the holds would be reminded 5 - Set expirationdate for the hold less than today UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY); 6 - Run the remidner cron again 7 - No holds trigger! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldoldoldstable |RESOLVED --- Comment #10 from wainuiwitikap...@catalyst.net.nz --- (In reply to wainuiwitikapark from comment #9) > Not releasing in 21.05.22 Reverted from 21.05 branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 Katrin Fischer changed: What|Removed |Added Attachment #140605|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 141014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141014&action=edit Bug 31540: Exclude expired holds from the reminder job Some libraries don't want to auto-cancel holds, but we should not remind a patron about a hold which has expired. To test: 1 - Place a hold for a patron 2 - Set it waiting 3 - Run the holds reminder script in the future perl misc/cronjobs/holds/holds_reminder.pl -day 1 --date '2023-09-12' -v 4 - Note the holds would be reminded 5 - Set expirationdate for the hold less than today UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY); 6 - Run the remidner cron again 7 - No holds trigger! Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | --- Comment #4 from Katrin Fischer --- Nick, you'll have to send me cookies for the next time I have to fix your Assignee! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.08 released in|| --- Comment #6 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.08 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 Arthur Suzuki changed: What|Removed |Added Version(s)|22.11.00, 22.05.08 |22.11.00, 22.05.08, released in||21.11.15 CC||arthur.suz...@biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #7 from Arthur Suzuki --- applied to 21.11 for 21.11.15 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|Pushed to oldoldstable |Pushed to oldoldoldstable CC||wainuiwitikapark@catalyst.n ||et.nz Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15|21.11.15, 21.05.22 --- Comment #8 from wainuiwitikap...@catalyst.net.nz --- Backported to 21.05.x for 21.05.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15, 21.05.22 |21.11.15 --- Comment #9 from wainuiwitikap...@catalyst.net.nz --- Not releasing in 21.05.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
