[Koha-bugs] [Bug 31624] REST API: Add endpoint for generated covers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31624 Paul Derscheid changed: What|Removed |Added Assignee|oleon...@myacpl.org |paul.dersch...@lmscloud.de CC||tomasco...@gmail.com Component|OPAC|REST API Status|NEW |ASSIGNED QA Contact|testo...@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31624] REST API: Add endpoint for generated covers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31624 --- Comment #1 from Paul Derscheid --- Created attachment 144726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144726&action=edit Bug 31624: REST API: Add endpoint for generated covers This commit contains the main changes for the endpoint and the controller for the image generation. To test this, if you don't have a very elaborate setup: 1. Apply the patch 2. Request the endpoint, for example using: http://localhost:8080/api/v1/public/biblios/1/default_cover 3. Now you could use this JS in your console to get an unescaped version of the JSON response const response = await fetch('http://localhost:8080/api/v1/public/biblios/1/default_cover'); const result = await response.json(); console.log(result); 4. Copy the response and check whether it actually is a valid base64 encoded image. For example using this tool: https://base64.guru/converter/decode/file 5. Give me your thoughts on this patch I'm still in the process of using unit tests and hunting bugs, so it's now ready for a sign-off but I thought I'd already show it to whoever is interested. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31624] REST API: Add endpoint for generated covers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31624 --- Comment #2 from Paul Derscheid --- The preliminary test plan assumes ktd, btw. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31624] REST API: Add endpoint for generated covers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31624 --- Comment #3 from Paul Derscheid --- I made some typos. The patch is not ready for a sign-off (not 'now' ready). And of course I'm in the process of writing unit tests, not using them. 😬 See #c1 for reference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/