[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 --- Comment #10 from Pedro Amorim --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Pedro Amorim changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|23.11.00,23.05.03 |23.11.00,23.05.03,22.11.09 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.11.00|23.11.00,23.05.03 released in|| --- Comment #9 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Katrin Fischer changed: What|Removed |Added Attachment #154236|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 154261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154261=edit Bug 31667: Merge 'tip' and 'hint' classes This patch corrects a few instances of the use of the "tip" class and replaces them with "hint." The patch also removes the class from the staff interface CSS. To test, apply the patch and rebuild the staff interface CSS. - View a patron account and click the "Routing lists" link in the left-hand sidebar. - On the subscription routing lists page the "Search subscriptions" page label should look correct. - Go to Reports -> Catalog by item type. - The "Select none..." hint should be styled correctly. - The third instance, in the installer, is only visible if you try to install Koha using a MySQL user who doesn't have the correct privileges, so may be too much trouble to really test. A check of the patch should be adequate. Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 --- Comment #6 from Fridolin Somers --- Thanks a lot Owen for the additional work ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Fridolin Somers changed: What|Removed |Added Attachment #154233|0 |1 is obsolete|| --- Comment #5 from Fridolin Somers --- Created attachment 154236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154236=edit Bug 31667: Merge 'tip' and 'hint' classes This patch corrects a few instances of the use of the "tip" class and replaces them with "hint." The patch also removes the class from the staff interface CSS. To test, apply the patch and rebuild the staff interface CSS. - View a patron account and click the "Routing lists" link in the left-hand sidebar. - On the subscription routing lists page the "Search subscriptions" page label should look correct. - Go to Reports -> Catalog by item type. - The "Select none..." hint should be styled correctly. - The third instance, in the installer, is only visible if you try to install Koha using a MySQL user who doesn't have the correct privileges, so may be too much trouble to really test. A check of the patch should be adequate. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Owen Leonard changed: What|Removed |Added Attachment #153888|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 154233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154233=edit Bug 31667: Merge 'tip' and 'hint' classes This patch corrects a few instances of the use of the "tip" class and replaces them with "hint." The patch also removes the class from the staff interface CSS. To test, apply the patch and rebuild the staff interface CSS. - View a patron account and click the "Routing lists" link in the left-hand sidebar. - On the subscription routing lists page the "Search subscriptions" page label should look correct. - Go to Reports -> Catalog by item type. - The "Select none..." hint should be styled correctly. - The third instance, in the installer, is only visible if you try to install Koha using a MySQL user who doesn't have the correct privileges, so may be too much trouble to really test. A check of the patch should be adequate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667
--- Comment #3 from Fridolin Somers ---
There is another CSS rule in staff-global.scss :
label {
...
&.tip {
display: block;
margin: .5em 0;
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 --- Comment #2 from Owen Leonard --- Created attachment 153888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153888=edit Bug 31667: Merge 'tip' and 'hint' classes This patch corrects a few instances of the use of the "tip" class and replaces them with "hint." The patch also removes the class from the staff interface CSS. To test, apply the patch and rebuild the staff interface CSS. - View a patron account and click the "Routing lists" link in the left-hand sidebar. - On the subscription routing lists page the "Search subscriptions" page label should look correct. - Go to Reports -> Catalog by item type. - The "Select none..." hint should be styled correctly. - The third instance, in the installer, is only visible if you try to install Koha using a MySQL user who doesn't have the correct privileges, so may be too much trouble to really test. A check of the patch should be adequate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 --- Comment #1 from Fridolin Somers --- > git grep -e 'class="hint[ "]' -- koha-tmpl/ | wc -l 343 > git grep -e 'class="tip[ "]' -- koha-tmpl/ | wc -l 42 They may be few places where this class is not the first. But hint is clearly the boss ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
