[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Bug 31810 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What|Removed |Added Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Lucas Gass changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Blocks||31947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 [Bug 31947] Add 'btn-primary' to the main action button where it's missing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 --- Comment #10 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #6) > Fridolin: penalty points for not filling Assignee field. You should know. Oupsy, I need more coffee (or more IPA) ^^ Tanks for fixing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Marcel de Rooy changed: What|Removed |Added Attachment #142223|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 142294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142294&action=edit Bug 31810: Define 'Place hold' button as primary When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form. Patch changes this button from btn-default to btn-primary. Test plan : Play with placing hold, one and several, with cases : - normal - override required - none available Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 --- Comment #7 from Marcel de Rooy --- Not sure if a yellow button on a green form is the most optimal choice of colors. But its all a matter of taste :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m CC||m.de.r...@rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- Fridolin: penalty points for not filling Assignee field. You should know. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31888 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31812 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31884 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 David Nind changed: What|Removed |Added Attachment #142220|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 142223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142223&action=edit Bug 31810: Define 'Place hold' button as primary When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form. Patch changes this button from btn-default to btn-primary. Test plan : Play with placing hold, one and several, with cases : - normal - override required - none available Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 --- Comment #4 from Fridolin Somers --- We see this patch did the same on preferences page : Bug 30952: Set preferences save buttons as primary buttons https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141679 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 --- Comment #3 from Fridolin Somers --- Created attachment 142220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142220&action=edit Bug 31810: Define 'Place hold' button as primary When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form. Patch changes this button from btn-default to btn-primary. Test plan : Play with placing hold, one and several, with cases : - normal - override required - none available -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Fridolin Somers changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 --- Comment #2 from Fridolin Somers --- Looks like important action button must use btn-primary instead of btn-default https://getbootstrap.com/docs/4.0/components/buttons/#examples -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31810] Place hold button should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #1 from Fridolin Somers --- I see Bug 23957 changed from input to button -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
