[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #15 from wainuiwitikap...@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 Arthur Suzuki changed: What|Removed |Added Version(s)|23.05.00,22.11.04,22.05.11 |23.05.00,22.11.04,22.05.11, released in||21.11.19 Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC||arthur.suz...@biblibre.com --- Comment #14 from Arthur Suzuki --- applied to 21.11 for 21.11.19 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.11 released in|| --- Comment #13 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 --- Comment #12 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.04 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 --- Comment #10 from David Cook --- (In reply to Jonathan Druart from comment #9) > An ideal solution would have been to remove them all ;) Someday... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #9 from Jonathan Druart --- An ideal solution would have been to remove them all ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 Jonathan Druart changed: What|Removed |Added Attachment #146446|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 147201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147201&action=edit Bug 32205: Remove unnecessary syspref template params for failed OPAC auth This patch removes some unnecessary syspref template params for failed OPAC auth. The templates handle these syspref using the Koha.Preference() TT plugin function, so they're completely redundant and just make checkauth() longer than it needs to be. Test plan: 1) Apply patch 2) Enable OpacCloud, OpacBrowser, and OpacTopissue sysprefs 3) koha-plack --restart kohadev 4) Log out of Koha if you're logged in 5) Go to http://localhost:8080/cgi-bin/koha/opac-user.pl 6) Note that you can see the Cart as well as links for the following: Browse by hierarchy, Authority search, Tag cloud, Subject cloud, Most popular Signed-off-by: Fridolin Somers Signed-off-by: Solene Ngamga Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 solene.nga...@inlibro.com changed: What|Removed |Added Attachment #144827|0 |1 is obsolete|| --- Comment #7 from solene.nga...@inlibro.com --- Created attachment 146446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146446&action=edit Bug 32205: Remove unnecessary syspref template params for failed OPAC auth This patch removes some unnecessary syspref template params for failed OPAC auth. The templates handle these syspref using the Koha.Preference() TT plugin function, so they're completely redundant and just make checkauth() longer than it needs to be. Test plan: 1) Apply patch 2) Enable OpacCloud, OpacBrowser, and OpacTopissue sysprefs 3) koha-plack --restart kohadev 4) Log out of Koha if you're logged in 5) Go to http://localhost:8080/cgi-bin/koha/opac-user.pl 6) Note that you can see the Cart as well as links for the following: Browse by hierarchy, Authority search, Tag cloud, Subject cloud, Most popular Signed-off-by: Fridolin Somers Signed-off-by: Solene Ngamga -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 Fridolin Somers changed: What|Removed |Added Attachment #143889|0 |1 is obsolete|| --- Comment #6 from Fridolin Somers --- Created attachment 144827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144827&action=edit Bug 32205: Remove unnecessary syspref template params for failed OPAC auth This patch removes some unnecessary syspref template params for failed OPAC auth. The templates handle these syspref using the Koha.Preference() TT plugin function, so they're completely redundant and just make checkauth() longer than it needs to be. Test plan: 1) Apply patch 2) Enable OpacCloud, OpacBrowser, and OpacTopissue sysprefs 3) koha-plack --restart kohadev 4) Log out of Koha if you're logged in 5) Go to http://localhost:8080/cgi-bin/koha/opac-user.pl 6) Note that you can see the Cart as well as links for the following: Browse by hierarchy, Authority search, Tag cloud, Subject cloud, Most popular Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205
--- Comment #5 from Fridolin Somers ---
(In reply to David Cook from comment #4)
> (In reply to Fridolin Somers from comment #3)
> > Ah I found a place where a preference is missing Koha.Preference() use.
> > It is TagsEnabled at :
> >
> > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt:[% SET
> > TagsInputEnabled = ( ( Koha.Preference( 'opacuserlogin' ) == 1 ) &&
> > TagsEnabled && TagsInputOnList ) %]
>
> It gets fetched in opac/opac-basket.pl using
> C4::Context->preference('TagsEnabled') and then passed to the template as
> TagsEnabled.
OK great so we ignore it ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #3 from Fridolin Somers --- Ah I found a place where a preference is missing Koha.Preference() use. It is TagsEnabled at : koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt:[% SET TagsInputEnabled = ( ( Koha.Preference( 'opacuserlogin' ) == 1 ) && TagsEnabled && TagsInputOnList ) %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 David Cook changed: What|Removed |Added Component|Authentication |Templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 --- Comment #2 from David Cook --- There are more sysprefs to remove (both for OPAC and staff interface), but I thought this was an easily manageable chunk. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 --- Comment #1 from David Cook --- Created attachment 143889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143889&action=edit Bug 32205: Remove unnecessary syspref template params for failed OPAC auth This patch removes some unnecessary syspref template params for failed OPAC auth. The templates handle these syspref using the Koha.Preference() TT plugin function, so they're completely redundant and just make checkauth() longer than it needs to be. Test plan: 1) Apply patch 2) Enable OpacCloud, OpacBrowser, and OpacTopissue sysprefs 3) koha-plack --restart kohadev 4) Log out of Koha if you're logged in 5) Go to http://localhost:8080/cgi-bin/koha/opac-user.pl 6) Note that you can see the Cart as well as links for the following: Browse by hierarchy, Authority search, Tag cloud, Subject cloud, Most popular -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32203 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
