[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Danyon Sewell changed: What|Removed |Added Resolution|--- |FIXED CC||danyonsew...@catalyst.net.n ||z Status|Pushed to oldstable |RESOLVED --- Comment #15 from Danyon Sewell --- Not backporting to 21.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.14 released in|| --- Comment #14 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #13 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.06 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Nick Clemens changed: What|Removed |Added Attachment #149758|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 150416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150416=edit Bug 32232: Ignore DST when calculating patron age This change calculates patron age using the floating timezone, so that datetimes missing midnight don't cause fatal errors in the comparison. Test plan: 0. Apply patch 1. Change in koha-conf.xml to include Canada/Eastern 2. koha-plack --restart kohadev 3. Create a patron, setting the date of birth to one of these three dates - 1947-04-27 - 1948-04-25 - 1949-04-24 4. Save the patron 5. Patron detail page loads instead of producing fatal error Signed-off-by: Marius Mandrescu Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Marius changed: What|Removed |Added Attachment #149754|0 |1 is obsolete|| --- Comment #10 from Marius --- Created attachment 149758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149758=edit Bug 32232: Ignore DST when calculating patron age This change calculates patron age using the floating timezone, so that datetimes missing midnight don't cause fatal errors in the comparison. Test plan: 0. Apply patch 1. Change in koha-conf.xml to include Canada/Eastern 2. koha-plack --restart kohadev 3. Create a patron, setting the date of birth to one of these three dates - 1947-04-27 - 1948-04-25 - 1949-04-24 4. Save the patron 5. Patron detail page loads instead of producing fatal error Signed-off-by: Marius Mandrescu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Marius changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #9 from Caroline Cyr La Rose --- Thanks so much David! I can't vouch for the coding part, but the patch does solve the problem of accessing the patron's file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Caroline Cyr La Rose changed: What|Removed |Added Attachment #149738|0 |1 is obsolete|| --- Comment #8 from Caroline Cyr La Rose --- Created attachment 149754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149754=edit Bug 32232: Ignore DST when calculating patron age This change calculates patron age using the floating timezone, so that datetimes missing midnight don't cause fatal errors in the comparison. Test plan: 0. Apply patch 1. Change in koha-conf.xml to include Canada/Eastern 2. koha-plack --restart kohadev 3. Create a patron, setting the date of birth to one of these three dates - 1947-04-27 - 1948-04-25 - 1949-04-24 4. Save the patron 5. Patron detail page loads instead of producing fatal error Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #7 from David Cook --- Btw, it looks like t/db_dependent/Koha/Patrons.t has a unit test that covers this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 David Cook changed: What|Removed |Added Attachment #149737|0 |1 is obsolete|| --- Comment #6 from David Cook --- Created attachment 149738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149738=edit Bug 32232: Ignore DST when calculating patron age This change calculates patron age using the floating timezone, so that datetimes missing midnight don't cause fatal errors in the comparison. Test plan: 0. Apply patch 1. Change in koha-conf.xml to include Canada/Eastern 2. koha-plack --restart kohadev 3. Create a patron, setting the date of birth to one of these three dates - 1947-04-27 - 1948-04-25 - 1949-04-24 4. Save the patron 5. Patron detail page loads instead of producing fatal error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #5 from David Cook --- Actually, I'm going to amend that to use the same syntax that Jonathan used in bug 23079 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #4 from David Cook --- Created attachment 149737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149737=edit Bug 32232: Ignore DST when calculating patron age This change calculates patron age using the floating timezone, so that datetimes missing midnight don't cause fatal errors in the comparison. Test plan: 0. Apply patch 1. Change in koha-conf.xml to include Canada/Eastern 2. koha-plack --restart kohadev 3. Create a patron, setting the date of birth to one of these three dates - 1947-04-27 - 1948-04-25 - 1949-04-24 4. Save the patron 5. Patron detail page loads instead of producing fatal error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #3 from David Cook --- (In reply to Caroline Cyr La Rose from comment #0) > To test: > 1. Create a patron, setting the date of birth to one of these three dates > - 1947-04-27 > - 1948-04-25 > - 1949-04-24 > 2. Save the patron > --> Error To reproduce, you'll likely need to update to include Canada/Eastern in your koha-conf.xml and then restart Plack. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #2 from David Cook --- That's a tricky one. It looks like dt_from_string() silently will produce a floating timestamp where a valid local timestamp can't be produced. In this particular case, if $today were converted from local to floating, then the age in years should be able to be computed without error. After grepping around a bit, this looks like it could actually be an all right strategy. I was worried about it pushing the problem further down the line, but it looks like dateofbirth is mostly just used for display with this one exception... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23079 CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Shi Yao Wang changed: What|Removed |Added CC||shi-yao.w...@inlibro.com --- Comment #1 from Shi Yao Wang --- The code fails in sub get_age of Koha/Patron.pm at line: >return $today->subtract_datetime( $date_of_birth )->years; because $date_of_birth is invalid for time zone America/Toronto -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Caroline Cyr La Rose changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Caroline Cyr La Rose changed: What|Removed |Added CC||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
