[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Martin Renvoize changed: What|Removed |Added CC|martin.renvoize@ptfs-europe | |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Katrin Fischer changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Didier Gautheron changed: What|Removed |Added Blocks||34941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34941 [Bug 34941] Patron search to find patrons with hyphens when they haven't been added in the search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Manos PETRIDIS changed: What|Removed |Added CC||egpetri...@yahoo.com --- Comment #14 from Manos PETRIDIS --- I wonder if bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34580 is related to changes introduced here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Martin Renvoize changed: What|Removed |Added Blocks|34083 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34083 [Bug 34083] Patron auto-complete fails if organization patron full name is in a single field separated by a space -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Pedro Amorim changed: What|Removed |Added Blocks||34083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34083 [Bug 34083] Patron auto-complete fails if organization patron full name is in a single field separated by a space -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Blocks||33117 --- Comment #13 from Jonathan Druart --- I don't understand this change, it's a regression, see bug 33117. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 [Bug 33117] Patron checkout search not working if searching with second surname -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 --- Comment #12 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.03 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- In fact.. as this patch is trivial and fixes a major regression I'll go straight for PQA.. Thanks Nick -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #9 from Martin Renvoize --- Whilst the nerd/coder side of me prefers the alternative.. I think in real life people will all prefer the functionality of the first patch. As such, I tested that one and am signing off confident in the approach as agreed by the staff and a few customers here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Martin Renvoize changed: What|Removed |Added Attachment #145914|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Martin Renvoize changed: What|Removed |Added Attachment #145905|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 146021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146021=edit Bug 32772: Make all autocomplete searches 'starts_with' To test: 1 - Add patrons with surname Fitzwilliams and Williams 2 - Enable 'PatronAutocomplete' syspref 3 - In checkout box type 'Will' 4 - You see fitwilliams first 5 - Apply patch 6 - Type 'Will' 7 - Autocomplete does not suggest Fitzwilliam, only Williams 8 - Type '%will' 9 - Fitzwilliams is suggested Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 --- Comment #7 from Martin Renvoize --- OK.. we all agreed Option 1 is likely the behaviour we want.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 --- Comment #6 from Martin Renvoize --- Updateing to NSO.. both patches work as described so I'd be happy to sign off.. However, I'm not entirely sure which we should adopt.. the addition of `^` to turn a search into 'starts_with' or the addition of `%` to turn a search into 'contains'. My gut says, users were comfortable with default being `starts_with` and so documenting the addition of `%` switching it to `contains` may be the least friction approach. Asking colleagues to weight in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Nick Clemens changed: What|Removed |Added Severity|normal |major --- Comment #5 from Nick Clemens --- I am raising to major, while it doesn't affect data, it has a huge impact on library workflows -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Nick Clemens changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||martin.renvoize@ptfs-europe ||.com Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 --- Comment #4 from Nick Clemens --- The first patch makes al the searches 'Starts with' The second goes on top and undoes that and allows for '^' to mean starts with in a term -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 --- Comment #3 from Nick Clemens --- Created attachment 145914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145914=edit Bug 32772: [Alternate] Add support for '^' as "Starts with" in patron searching This patch parses each term we send to patron search - if it finds it starts with '^' then the term is searched as a starts with - other terms will still be 'contains' To test: 1 - Make a bunch of williams and fitzwiliams UPDATE borrowers SET surname = 'Fitzwilliams' IF borrowernumber < 25; UPDATE borrowers SET surname = 'Williams' IF borrowernumber > 25; 2 - Enable PatronAutrocomplete syspref 3 - Search for 'Will' in patron search 4 - You get Fitzwilliams (you see them in the automplete too) 5 - Apply patch 6 - Search for '^Will' 7 - Confirm that autocomplete and full search results only have williams, not fitzwilliams 8 - Search for '^Will an' 9 - Confirm you get 'Frances Williams' and 'Annie Williams' - as the 'an' is searched as contains -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 --- Comment #2 from Nick Clemens --- Created attachment 145905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145905=edit Bug 32772: Make all autocomplete searches 'starts_with' To test: 1 - Add patrons with surname Fitzwilliams and Williams 2 - Enable 'PatronAutocomplete' syspref 3 - In checkout box type 'Will' 4 - You see fitwilliams first 5 - Apply patch 6 - Type 'Will' 7 - Autocomplete does not suggest Fitzwilliam, only Williams 8 - Type '%will' 9 - Fitzwilliams is suggested -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Nick Clemens changed: What|Removed |Added Depends on||32520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32520 [Bug 32520] Patron autocomplete should respect DefaultPatronSearchFields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 --- Comment #1 from Nick Clemens --- For master this bug includes all fields in DefaultPatronSearchFields - depending on the backport of 31782 we still need a solution for surname search in stable versions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
