[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #8 from Lucas Gass --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 --- Comment #7 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.06 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917
Jonathan Druart changed:
What|Removed |Added
Attachment #150111|0 |1
is obsolete||
--- Comment #5 from Jonathan Druart ---
Created attachment 150207
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150207&action=edit
Bug 32917: Fix sample notice for CHANGE_PASSWORD
We've identified 3 issues:
* Name of patron is not showing up in subject line
* Name of patron is now showing in notice text
* Notice is set to be HTML, but has no line breaks and uses no HTML tags
In the database update, these issues don't occur:
$dbh->do( q{
INSERT IGNORE INTO letter (module, code, name, title, content,
message_transport_type) VALUES ('members', 'PASSWORD_CHANGE', 'Notification of
password change', 'Library account password change notification',
"Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nWe want to
notify you that your password has been changed. If you did not change it
yourself (or requested that change), please contact library staff.\r\n\r\nYour
library.", 'email');
});
So this patch will make them match up:
* Remove HTML flag
* Update patron. to borrower. in message text
* Remove patron name from subject (it won't work even with the correct
variables)
To test:
* Add an email address to your favourite sample user
* Make sure NotifyPasswordChange is set to "Notify"
* Update the sample user's password using the "change password" feature
* Verify a notice is shown in the notices tabs
Note: you won't see the line break issue there because of bug 30287
* Apply patch
* Recreate your database/run web installer so sample notices are loaded
* Repeat the test, it should generate a nice lookig notice now
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Depends on||25936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 [Bug 25936] Notify users if their password has changed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Testing notes (using KTD): 1. After applying the patch, a reset_all loads the updated notice: - remember to add email address again to patron used to test 2. I also tested by actually sending the email[1] - this showed that the formatting was fixed (line breaks now show where expected, so it is now nicely formatted). [1] To test sending emails using a Google account, edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where = your Google email address; = your APP password, not your Google account password): smtp.gmail.com 587 5 STARTTLS GOOGLEACCOUNTUSER GOOGLEAPPPASSWORD 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917
David Nind changed:
What|Removed |Added
Attachment #149729|0 |1
is obsolete||
--- Comment #3 from David Nind ---
Created attachment 150111
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150111&action=edit
Bug 32917: Fix sample notice for CHANGE_PASSWORD
We've identified 3 issues:
* Name of patron is not showing up in subject line
* Name of patron is now showing in notice text
* Notice is set to be HTML, but has no line breaks and uses no HTML tags
In the database update, these issues don't occur:
$dbh->do( q{
INSERT IGNORE INTO letter (module, code, name, title, content,
message_transport_type) VALUES ('members', 'PASSWORD_CHANGE', 'Notification of
password change', 'Library account password change notification',
"Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nWe want to
notify you that your password has been changed. If you did not change it
yourself (or requested that change), please contact library staff.\r\n\r\nYour
library.", 'email');
});
So this patch will make them match up:
* Remove HTML flag
* Update patron. to borrower. in message text
* Remove patron name from subject (it won't work even with the correct
variables)
To test:
* Add an email address to your favourite sample user
* Make sure NotifyPasswordChange is set to "Notify"
* Update the sample user's password using the "change password" feature
* Verify a notice is shown in the notices tabs
Note: you won't see the line break issue there because of bug 30287
* Apply patch
* Recreate your database/run web installer so sample notices are loaded
* Repeat the test, it should generate a nice lookig notice now
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917
--- Comment #2 from Katrin Fischer ---
Created attachment 149729
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149729&action=edit
Bug 32917: Fix sample notice for CHANGE_PASSWORD
We've identified 3 issues:
* Name of patron is not showing up in subject line
* Name of patron is now showing in notice text
* Notice is set to be HTML, but has no line breaks and uses no HTML tags
In the database update, these issues don't occur:
$dbh->do( q{
INSERT IGNORE INTO letter (module, code, name, title, content,
message_transport_type) VALUES ('members', 'PASSWORD_CHANGE', 'Notification of
password change', 'Library account password change notification',
"Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nWe want to
notify you that your password has been changed. If you did not change it
yourself (or requested that change), please contact library staff.\r\n\r\nYour
library.", 'email');
});
So this patch will make them match up:
* Remove HTML flag
* Update patron. to borrower. in message text
* Remove patron name from subject (it won't work even with the correct
variables)
To test:
* Add an email address to your favourite sample user
* Make sure NotifyPasswordChange is set to "Notify"
* Update the sample user's password using the "change password" feature
* Verify a notice is shown in the notices tabs
Note: you won't see the line break issue there because of bug 30287
* Apply patch
* Recreate your database/run web installer so sample notices are loaded
* Repeat the test, it should generate a nice lookig notice now
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 --- Comment #1 from Caroline Cyr La Rose --- The translation files usually change the TT variables by %s in the original string For example Dear [% borrower.firstname %] [% borrower.surname %] becomes Dear %s %s But for this letter, the variable are written in long form Library account password change notification for [% patron.firstname %] [% patron.surname %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
