[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-09-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Lucas Gass  ---
Hi Peter, a couple things:

1. Your DB update still reads 'bug_number  => "BUG_NUMBER",'. Can you replace
that with the actual bug number.

2. If I run the 'updatedatabase' multiple times it will continue to output:
Warning: PseudonymizationPatronFields already has 'age'
Warning: PseudonymizationTransactionFields already has 'interface'
Warning: pseudonymized_transactions already has 'age'
Warning: pseudonymized_transactions already has 'interface'
Warning: pseudonymized_transactions already has 'operator

3. Can we get an explain of "operator" as Jonathan requested in comment 2?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-09-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

Peter Vashchuk  changed:

   What|Removed |Added

 Attachment #155591|0   |1
is obsolete||

--- Comment #7 from Peter Vashchuk  ---
Created attachment 155780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155780=edit
Bug 33013: add age, interface and operator to pseudonymized statistics

This patch adds: age (patron's age), interface (sip/api/opac/intranet/cron/etc)
and operator (user id if it has extra permissions, for example: librarian)
to the pseudonymized statistics table.

To reproduce:
1. With Pseudonymization enabled, perform a check-out, check-in or renew to
add an entry to the pseudonymized_transactions table.
2. Apply the patch and perform the atomic update.
3. Go to sysprefs and enable "Interface" and "Operator ID" for
PseudonymizationTransactionFields
and "Patron's age" for PseudonymizationPatronFields.
4. Perform the same actions as you did earlier (check-out, check-in, or renew)
to add another
entry to the pseudonymized_transactions table. Compare those two entries, the
one that was
added should have new stats.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-09-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

Peter Vashchuk  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
Hi Peter,

Can you perltidy you changes?

 WARN   Koha/PseudonymizedTransaction.pm
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 14,
now: 26)

 WARN   Koha/Schema/Result/PseudonymizedTransaction.pm
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 56,
now: 62)

 WARN  
installer/data/mysql/atomicupdate/bug-33013_more-pseudonymization-fields.pl
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 0,
now: 19)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

--- Comment #5 from Peter Vashchuk  ---
(In reply to Émily-Rose Francoeur from comment #3)

Rebased on the current master, it should work now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

Peter Vashchuk  changed:

   What|Removed |Added

 Attachment #146955|0   |1
is obsolete||

--- Comment #4 from Peter Vashchuk  ---
Created attachment 155591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155591=edit
Bug 33013: add age, interface and operator to pseudonymized statistics

This patch adds: age (patron's age), interface (sip/api/opac/intranet/cron/etc)
and operator (user id if it has extra permissions, for example: librarian)
to the pseudonymized statistics table.

To reproduce:
1. With Pseudonymization enabled, perform a check-out, check-in or renew to
add an entry to the pseudonymized_transactions table.
2. Apply the patch and perform the atomic update.
3. Go to sysprefs and enable "Interface" and "Operator ID" for
PseudonymizationTransactionFields
and "Patron's age" for PseudonymizationPatronFields.
4. Perform the same actions as you did earlier (check-out, check-in, or renew)
to add another
entry to the pseudonymized_transactions table. Compare those two entries, the
one that was
added should have new stats.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

Peter Vashchuk  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

Émily-Rose Francoeur  changed:

   What|Removed |Added

 CC||emily-rose.francoeur@inLibr
   ||o.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #3 from Émily-Rose Francoeur  ---
When I try to apply the patch (git bz apply 33013) at step 2, I got this error

error: sha1 information is lacking or useless
(Koha/PseudonymizedTransaction.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 33013: add age, interface and operator to
pseudonymized statistics
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-33013-add-age-interface-and-operator-to-pseudo-xu_nqqh0.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

Owen Leonard  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #2 from Jonathan Druart  ---
I don't understand the "operator", can you detail please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30928

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-02-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

--- Comment #1 from Peter Vashchuk  ---
Created attachment 146955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146955=edit
Bug 33013: add age, interface and operator to pseudonymized statistics

This patch adds: age (patron's age), interface (sip/api/opac/intranet/cron/etc) 
and operator (user id if it has extra permissions, for example: librarian) 
to the pseudonymized statistics table.

To reproduce:
1. With Pseudonymization enabled, perform a check-out, check-in or renew to 
add an entry to the pseudonymized_transactions table.
2. Apply the patch and perform the atomic update. 
3. Go to sysprefs and enable "Interface" and "Operator ID" for
PseudonymizationTransactionFields
and "Patron's age" for PseudonymizationPatronFields.
4. Perform the same actions as you did earlier (check-out, check-in, or renew)
to add another
entry to the pseudonymized_transactions table. Compare those two entries, the
one that was
added should have new stats.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats

2023-02-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013

Peter Vashchuk  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/