[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2024-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/854
 CC||caroline.cyr-la-rose@inlibr
   ||o.com
  Documentation||Caroline Cyr La Rose
contact||

--- Comment #24 from Caroline Cyr La Rose  ---
Please set the status to 'Needs documenting' when there is a new field visible
to the user. Thanks! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2024-03-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Hammat wele  changed:

   What|Removed |Added

 CC||hammat.w...@inlibro.com
 Attachment #164154|1   |0
   is patch||
 Attachment #164154|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2024-03-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

--- Comment #23 from Hammat wele  ---
Created attachment 164154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164154=edit
Bug 33039: Incorrect date value stored when 'Published on' or 'Expected on' are
empty

When we edit a serial and we leave the date fields ('Published on' or 'Expected
on') empty
incorrect date are saved in the database -00-00 instade of current date and
we get Error 500

to reproduce
1. Connect to staff interface
2. Go to Serials and create a new subscription
3. Click on Serial collection in the left menu (and note the Subscription
numnber)
4. Select a serial to edit and Click on «Edit serials»
5. In the Serial edition form, delete «Published on > and « Expected on » dates
and save
 > Error 500 page is displayed
6. Check the value of «Published on > and « Expected on » dates  in the
database
select planneddate,publisheddate from serial where
subscriptionid=;
--> planneddate publisheddate have «-00-00» value
7. Apply the patch
8. repeat step 2, 3, 4, 5, 6
 ->  Error 500 page is no more displayed
 -> «Published on » and « Expected on » field have today date

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Lucas Gass  changed:

   What|Removed |Added

 Blocks||35867


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35867
[Bug 35867] Bug 33039 needs to be easier for librarians to use/understand
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35646

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #22 from Nick Clemens  ---
*** Bug 31792 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |FIXED

--- Comment #21 from Martin Renvoize  ---
Enhancement, no backport for 23.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

--- Comment #20 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #153090|0   |1
is obsolete||

--- Comment #19 from Marcel de Rooy  ---
Created attachment 153139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153139=edit
Bug 33039: Update Schema File [DO NOT PUSH]

Signed-off-by: Laura Escamilla 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #153089|0   |1
is obsolete||

--- Comment #18 from Marcel de Rooy  ---
Created attachment 153138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153138=edit
Bug 33039: Add ability to specify a template for serial subscription "Published
on (text)" field

Some libraries would like to have the text version of the serials
"published on" field auto-generated from a template. This template
should be definable at the subscription level.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Restart all the things!
4) Create or edit a new subscription
5) Edit the "Publication date template", create a template toolkit
   template.
   Keys available are the Koha::Subscription object as 'subscription'
   and the following serial table columns as keys:
serialseq
serialseq_x
serialseq_y
serialseq_z
subscriptionid
biblionumber
status
planneddate
publisheddate
publisheddateext
notes
routingnotes
   So your example template could be "[% subscription.subscriptionid %] [%
biblionumber %]"
6) Generate the next serial
7) Note the next issue has a "Date published (text)" field based on the
   template you set!

Signed-off-by: Laura Escamilla 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

--- Comment #17 from Kyle M Hall  ---
Created attachment 153090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153090=edit
Bug 33039: Update Schema File [DO NOT PUSH]

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #148534|0   |1
is obsolete||
 Attachment #148535|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall  ---
Created attachment 153089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153089=edit
Bug 33039: Add ability to specify a template for serial subscription "Published
on (text)" field

Some libraries would like to have the text version of the serials
"published on" field auto-generated from a template. This template
should be definable at the subscription level.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Restart all the things!
4) Create or edit a new subscription
5) Edit the "Publication date template", create a template toolkit
   template.
   Keys available are the Koha::Subscription object as 'subscription'
   and the following serial table columns as keys:
serialseq
serialseq_x
serialseq_y
serialseq_z
subscriptionid
biblionumber
status
planneddate
publisheddate
publisheddateext
notes
routingnotes
   So your example template could be "[% subscription.subscriptionid %] [%
biblionumber %]"
6) Generate the next serial
7) Note the next issue has a "Date published (text)" field based on the
   template you set!

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Kyle M Hall  changed:

   What|Removed |Added

 QA Contact|m.de.r...@rijksmuseum.nl|testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #15 from Kyle M Hall  ---
(In reply to Marcel de Rooy from comment #14)
> +if ( index( $template, '[%' ) != -1 ) { # Much faster than regex
> No problem, but 'much' sounds like exaggerating :) Just in memory..

https://stackoverflow.com/questions/30744379/unanchored-substring-searching-index-vs-regex

> 
> This call worries me:
> +my $tt = Template->new(
> +{
> +EVAL_PERL   => 1,
> +ABSOLUTE=> 1,
> +PLUGIN_BASE => 'Koha::Template::Plugin',
> +COMPILE_EXT => $use_template_cache ? '.ttc' : '',
> +COMPILE_DIR => $use_template_cache ?
> C4::Context->config('template_cache_dir') : '',
> +FILTERS  => {},
> +ENCODING => 'UTF-8',
> +}
> +) or die Template->error();
> Would prefer to see calling something central like in C4::Templates or in
> C4::Letters instead.

Bug 33041 already handles that

> 
> +$schema->txn_begin;
> +try {
> +my $text;
> +$tt->process(
> Please explain why a process call would need a transaction. Can we just
> remove it ?

Please have a look at C4::Letters. This is now standard procedure for template
processing.


> Could generating alternative text via a Koha plugin be easier somehow? And
> without needing a db revision ?
> Note that we already have:
> Koha/Plugins/Base.pm:$args->{'template'} = Template->new( { ABSOLUTE =>
> 1, ENCODING => 'UTF-8' } );

That sounds more complicated. If you want to write a POC for that I'd be happy
to take a look.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #14 from Marcel de Rooy  ---
+if ( index( $template, '[%' ) != -1 ) { # Much faster than regex
No problem, but 'much' sounds like exaggerating :) Just in memory..
The variable name could be confusing btw. It is template code.

This call worries me:
+my $tt = Template->new(
+{
+EVAL_PERL   => 1,
+ABSOLUTE=> 1,
+PLUGIN_BASE => 'Koha::Template::Plugin',
+COMPILE_EXT => $use_template_cache ? '.ttc' : '',
+COMPILE_DIR => $use_template_cache ?
C4::Context->config('template_cache_dir') : '',
+FILTERS  => {},
+ENCODING => 'UTF-8',
+}
+) or die Template->error();
Would prefer to see calling something central like in C4::Templates or in
C4::Letters instead.

+$schema->txn_begin;
+try {
+my $text;
+$tt->process(
Please explain why a process call would need a transaction. Can we just remove
it ?

Could generating alternative text via a Koha plugin be easier somehow? And
without needing a db revision ?
Note that we already have:
Koha/Plugins/Base.pm:$args->{'template'} = Template->new( { ABSOLUTE => 1,
ENCODING => 'UTF-8' } );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

--- Comment #13 from Marcel de Rooy  ---
+use Carp qw( croak );
Shouldnt we use exceptions now ?
PERL26: Koha::Exceptions (Approved on Apr 26, 2017)
Instead of die or croak when meeting unfavorable conditions in our code, we
should raise exceptions via Koha::Exceptions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED
 CC||m.de.r...@rijksmuseum.nl

--- Comment #12 from Marcel de Rooy  ---
Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #148472|0   |1
is obsolete||

--- Comment #11 from ByWater Sandboxes  ---
Created attachment 148535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148535=edit
Bug 33039: Update Schema File [DO NOT PUSH]

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #147173|0   |1
is obsolete||

--- Comment #10 from ByWater Sandboxes  ---
Created attachment 148534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148534=edit
Bug 33039: Add ability to specify a template for serial subscription "Published
on (text)" field

Some libraries would like to have the text version of the serials
"published on" field auto-generated from a template. This template
should be definable at the subscription level.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Restart all the things!
4) Create or edit a new subscription
5) Edit the "Publication date template", create a template toolkit
   template.
   Keys available are the Koha::Subscription object as 'subscription'
   and the following serial table columns as keys:
serialseq
serialseq_x
serialseq_y
serialseq_z
subscriptionid
biblionumber
status
planneddate
publisheddate
publisheddateext
notes
routingnotes
   So your example template could be "[% subscription.subscriptionid %] [%
biblionumber %]"
6) Generate the next serial
7) Note the next issue has a "Date published (text)" field based on the
   template you set!

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #148482|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

--- Comment #9 from Laura Escamilla  ---
Created attachment 148482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148482=edit
Bug 32924: (follow-up) Add left margin to 'Show mine only' label

Signed-off-by: Pedro Amorim 
Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #148471|0   |1
is obsolete||

--- Comment #8 from ByWater Sandboxes  ---
Created attachment 148472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148472=edit
Bug 33039: Update Schema File [DO NOT PUSH]

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #148470|0   |1
is obsolete||

--- Comment #7 from ByWater Sandboxes  ---
Created attachment 148471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148471=edit
Bug 33039: Update Schema File [DO NOT PUSH]

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #147174|0   |1
is obsolete||

--- Comment #6 from ByWater Sandboxes  ---
Created attachment 148470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148470=edit
Bug 33039: Update Schema File [DO NOT PUSH]

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-03-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||Laura.escamilla@bywatersolu
   ||tions.com

--- Comment #5 from Laura Escamilla  ---
(In reply to Kyle M Hall from comment #3)
> Created attachment 147173 [details] [review]
> Bug 33039: Add ability to specify a template for serial subscription
> "Published on (text)" field
> 
> Some libraries would like to have the text version of the serials
> "published on" field auto-generated from a template. This template
> should be definable at the subscription level.
> 
> Test Plan:
> 1) Apply this patch
> 2) Run updatedatabase.pl
> 3) Restart all the things!
> 4) Create or edit a new subscription
> 5) Edit the "Publication date template", create a template toolkit
>template.
>Keys available are the Koha::Subscription object as 'subscription'
>and the following serial table columns as keys:
> serialseq
> serialseq_x
> serialseq_y
> serialseq_z
> subscriptionid
> biblionumber
> status
> planneddate
> publisheddate
> publisheddateext
> notes
> routingnotes
>So your example template could be "[% subscription.subscriptionid %] [%
> biblionumber %]"
> 6) Generate the next serial
> 7) Note the next issue has a "Date published (text)" field based on the
>template you set!

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31792

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-02-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||33041


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33041
[Bug 33041] Use process_tt in C4::Serial::NewIssue
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-02-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

--- Comment #4 from Kyle M Hall  ---
Created attachment 147174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147174=edit
Bug 33039: Update Schema File [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-02-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #147167|0   |1
is obsolete||
 Attachment #147168|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 147173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147173=edit
Bug 33039: Add ability to specify a template for serial subscription "Published
on (text)" field

Some libraries would like to have the text version of the serials
"published on" field auto-generated from a template. This template
should be definable at the subscription level.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Restart all the things!
4) Create or edit a new subscription
5) Edit the "Publication date template", create a template toolkit
   template.
   Keys available are the Koha::Subscription object as 'subscription'
   and the following serial table columns as keys:
serialseq
serialseq_x
serialseq_y
serialseq_z
subscriptionid
biblionumber
status
planneddate
publisheddate
publisheddateext
notes
routingnotes
   So your example template could be "[% subscription.subscriptionid %] [%
biblionumber %]"
6) Generate the next serial
7) Note the next issue has a "Date published (text)" field based on the
   template you set!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-02-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||33030


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030
[Bug 33030] Add standardized subroutine for processing Template Toolkit syntax
outside of notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-02-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-02-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

--- Comment #2 from Kyle M Hall  ---
Created attachment 147168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147168=edit
Bug 33039: Update Schema File [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-02-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

--- Comment #1 from Kyle M Hall  ---
Created attachment 147167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147167=edit
Bug 33039: Add ability to specify a template for serial subscription "Published
on (text)" field

Some libraries would like to have the text version of the serials
"published on" field auto-generated from a template. This template
should be definable at the subscription level.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Restart all the things!
4) Create or edit a new subscription
5) Edit the "Publication date template", create a template toolkit
   template.
   Keys available are the Koha::Subscription object as 'subscription'
   and the following serial table columns as keys:
serialseq
serialseq_x
serialseq_y
serialseq_z
subscriptionid
biblionumber
status
planneddate
publisheddate
publisheddateext
notes
routingnotes
   So your example template could be "[% subscription.subscriptionid %] [%
biblionumber %]"
6) Generate the next serial
7) Note the next issue has a "Date published (text)" field based on the
   template you set!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2023-02-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/