[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.04,22.05.12 |23.05.00,22.11.04,22.05.12, released in||21.11.20 --- Comment #15 from Arthur Suzuki --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.12 released in|| --- Comment #14 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #13 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.04 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 148337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148337&action=edit Bug 33100: (QA follow-up) Trivial QA fixes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #10 from Martin Renvoize --- The code change is nice and clear here and in testing it's all working as expected for me. We're also nicely covered by unit tests. QA scripts are happy too, so I'm going to straight PQA this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Martin Renvoize changed: What|Removed |Added Attachment #148031|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 148226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148226&action=edit Bug 33100: Remove all punctuation at end of record This could potentially be overkill - if you have two records that only differ in ending punctuation, you might get a false result - I don't know how likely that is ( as I have mentioned before '!!!' is a band ) This seems a reasonable fix To test: 1 - Set sysprefs as in bug 33159 2 - Edit a record, biblionumebr 3 is fine 3 - Add a comma to end of author subfield a 4 - Save and note relinked 5 - Apply patch, restart all 6 - Save again 7 - Linked to original record Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Martin Renvoize changed: What|Removed |Added Attachment #148030|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 148225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148225&action=edit Bug 33100: Unit test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens changed: What|Removed |Added Blocks||33159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens changed: What|Removed |Added Depends on|33159 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Phil Ringnalda changed: What|Removed |Added Blocks|33159 | Depends on||33159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #7 from Phil Ringnalda --- I can only test locally with Zebra, because I've never gotten the instructions to make ElasticSearch work on macOS to actually work. With Zebra, 22.05.x does not exhibit this bug: after you add the comma, the heading still links to the original authority With Zebra, master @ 7a829606a46f5d3c2056ce9da5134ce293d584ad (the revision before bug 30280 broke linking names) does not exhibit this bug With Zebra, HEAD plus the patches from bug 33159 to allow linking names to work again does not exhibit this bug With ElasticSearch on a sandbox, HEAD plus the patches from bug 33159 to allow linking names does not exhibit this bug I'd like to know whether ElasticSearch on 22.05.x, ElasticSearch @ 7a829606a46f5d3c2056ce9da5134ce293d584ad, and ElasticSearch on 22.11.x exhibit this bug, but I don't have any way to find out myself. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #6 from Nick Clemens --- Created attachment 148031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148031&action=edit Bug 33100: Remove all punctuation at end of record This could potentially be overkill - if you have two records that only differ in ending punctuation, you might get a false result - I don't know how likely that is ( as I have mentioned before '!!!' is a band ) This seems a reasonable fix To test: 1 - Set sysprefs as in bug 33159 2 - Edit a record, biblionumebr 3 is fine 3 - Add a comma to end of author subfield a 4 - Save and note relinked 5 - Apply patch, restart all 6 - Save again 7 - Linked to original record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens changed: What|Removed |Added Attachment #147885|0 |1 is obsolete|| Attachment #147886|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 148030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148030&action=edit Bug 33100: Unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens changed: What|Removed |Added Blocks||33159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens changed: What|Removed |Added Depends on|33159 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #4 from Phil Ringnalda --- Whether or not you can have collisions depends on what heading rules you catalog under, but at least for Library of Congress/NACO rules you're pretty safe: a heading has to be unique after https://www.loc.gov/aba/pcc/naco/normrule-2.html#a is applied, which removes or blanks most punctuation. While Foo&, Foo#, and Foo are validly three different names (which is fine, we don't strip & or #), Foo-, Foo., Foo:, Foo=, Foo;, Foo%, Foo/, and Foo are all the same name so only one of them can exist. Comma is a little bit fun, because normalization says that the "first comma in $a is retained" but doesn't say "only if there is something following it" so technically if there's already someone named "Foo" it would be valid to have someone else named "Foo," but at least so far people giving themselves Cher-like single names don't seem very fond of having a trailing comma as part of their actual name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #3 from Nick Clemens --- Created attachment 147886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147886&action=edit Bug 33100: Remove all punctuation at end of record This could potentially be overkill - if you have two records that only differ in ending punctuation, you might get a false result - I don't know how likely that is ( as I have mentioned before '!!!' is a band ) This seems a reasonable fix To test: 1 - Set sysprefs as in bug 33159 2 - Edit a record, biblionumebr 3 is fine 3 - Add a comma to end of author subfield a 4 - Save and note relinked 5 - Apply patch, restart all 6 - Save again 7 - Linked to original record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #2 from Nick Clemens --- Created attachment 147885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147885&action=edit Bug 33100: Unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens changed: What|Removed |Added Depends on||33159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24094, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24833 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 --- Comment #1 from Phil Ringnalda --- May wind up invalid, I forgot that the fallout from bug 30280 means you can't actually test linking on master/22.11, because almost everything fails to link and thus autocreates duplicates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
