[Koha-bugs] [Bug 33103] Add vendor aliases

2023-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||33355


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355
[Bug 33355] ERM UI and markup has some issues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the||This allows to create
  release notes||aliases for a vendor. The
   ||aliases can be former names
   ||or different spellings of
   ||the name. Once added they
   ||will display on the vendor
   ||detail page. And they will
   ||be included in search when
   ||searching by a vendor's
   ||name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
 Resolution|--- |FIXED
 Status|Needs documenting   |RESOLVED
  Documentation||Caroline Cyr La Rose
contact||
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/681

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Needs documenting
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #63 from Martin Renvoize  ---
This is a great enhancement, but not one for backport I'm afraid

Marking Needs documenting :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #62 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #61 from Jonathan Druart  ---
I've got a very weird git conflict with the previous patch, it was trying to
modify Koha/Schema/Result/CurbsidePickupIssue.pm (??)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #149630|0   |1
is obsolete||

--- Comment #60 from Jonathan Druart  ---
Created attachment 149788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149788&action=edit
Bug 33103: DBIC schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #59 from Jonathan Druart  ---
Rename asked by Tomas.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #149480|0   |1
is obsolete||

--- Comment #58 from Jonathan Druart  ---
Created attachment 149630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149630&action=edit
Bug 33103: DBIC changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #57 from Jonathan Druart  ---
Created attachment 149629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149629&action=edit
Bug 33103: Rename aqbookseller_aliases.id with alias_id

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #56 from Jonathan Druart  ---
Created attachment 149609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149609&action=edit
Bug 33103: Prevent vendors to be displayed several times in the search result

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #55 from Jonathan Druart  ---
Created attachment 149608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149608&action=edit
Bug 33103: Fix accessibility issues

* Add spaces
* Add 'Add' and 'Remove' in addition of the icons
* Do not submit the form when enter is hit
* Fix translatability

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #54 from Jonathan Druart  ---
Created attachment 149607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149607&action=edit
Bug 33103: Deal with html tags

HTML tags won't be interpreted. However 

[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #149488|0   |1
is obsolete||
 Attachment #149489|0   |1
is obsolete||
 Attachment #149490|0   |1
is obsolete||
 Attachment #149491|0   |1
is obsolete||

--- Comment #53 from Jonathan Druart  ---
Created attachment 149606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149606&action=edit
Bug 33103: Display the aliases in the dropdown list in ERM

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #149419|0   |1
is obsolete||

--- Comment #52 from Katrin Fischer  ---
Created attachment 149491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149491&action=edit
Bug 33103: Prevent vendors to be displayed several times in the search result

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #149414|0   |1
is obsolete||

--- Comment #51 from Katrin Fischer  ---
Created attachment 149490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149490&action=edit
Bug 33103: Fix accessibility issues

* Add spaces
* Add 'Add' and 'Remove' in addition of the icons
* Do not submit the form when enter is hit
* Fix translatability

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148458|0   |1
is obsolete||

--- Comment #50 from Katrin Fischer  ---
Created attachment 149489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149489&action=edit
Bug 33103: Deal with html tags

HTML tags won't be interpreted. However 

[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148457|0   |1
is obsolete||

--- Comment #49 from Katrin Fischer  ---
Created attachment 149488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149488&action=edit
Bug 33103: Display the aliases in the dropdown list in ERM

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148456|0   |1
is obsolete||

--- Comment #48 from Katrin Fischer  ---
Created attachment 149487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149487&action=edit
Bug 33103: Add REST API tests

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148455|0   |1
is obsolete||

--- Comment #47 from Katrin Fischer  ---
Created attachment 149486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149486&action=edit
Bug 33103: Embed aliases in GET /vendors

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148454|0   |1
is obsolete||

--- Comment #46 from Katrin Fischer  ---
Created attachment 149485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149485&action=edit
Bug 33103: Make vendors searchable by aliases

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148453|0   |1
is obsolete||

--- Comment #45 from Katrin Fischer  ---
Created attachment 149484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149484&action=edit
Bug 33103: Add the ability to create vendor aliases

This patchset is adding the ability to create aliases for vendors. It
will then be easier to search for vendors.

* new DB table aqbookseller_aliases(id, vendor_id, alias)
* new pair of Koha classes Koha::Acquisition::Bookseller::Alias[es]
* new method to retrieve the aliases from the vendor
Koha::Acquisition::Bookseller->aliases
* The api spec changes to allow aliases to be embeded on
GET /acquisitions/vendors
* Add/Delete alias when editing a vendor
* Display the aliases on the vendor show view
* Search vendors by aliases
* Display the aliases in the dropdown list of the vendors in the ERM
module

Test plan:
- Create a vendor, add it some aliases
- Edit the vendor, remove some aliases
=> Behaviour must be consistent
- Search the vendor in the acquisition module by its aliases
=> The vendor must be returned in the result
- Go to the ERM module, add a new agreement or license
=> Notice that the dropdown list of the vendors is displaying the
aliases, that make vendors searchable by their aliases

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148452|0   |1
is obsolete||

--- Comment #44 from Katrin Fischer  ---
Created attachment 149483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149483&action=edit
Bug 33103: Add tests for Aliases Koha classes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148451|0   |1
is obsolete||

--- Comment #43 from Katrin Fischer  ---
Created attachment 149482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149482&action=edit
Bug 33103: Koha classes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148450|0   |1
is obsolete||

--- Comment #42 from Katrin Fischer  ---
Created attachment 149481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149481&action=edit
Bug 33103: DBIC specific

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148449|0   |1
is obsolete||

--- Comment #41 from Katrin Fischer  ---
Created attachment 149480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149480&action=edit
Bug 33103: DBIC changes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148448|0   |1
is obsolete||

--- Comment #40 from Katrin Fischer  ---
Created attachment 149479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149479&action=edit
Bug 33103: DB changes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #39 from Jonathan Druart  ---
Created attachment 149419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149419&action=edit
Bug 33103: Prevent vendors to be displayed several times in the search result

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #38 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #37)
> (In reply to Jonathan Druart from comment #35)
> > (In reply to Katrin Fischer from comment #34)
> > It was the easiest approach to make the filtering works in the ERM module.
> > Could we move that to its own bug?
> 
> Opened bug 33480.

Makes sense. I'll try to get back to this asap, but if someone wants to steal
it, that's also ok!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #37 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #35)
> (In reply to Katrin Fischer from comment #34)
> It was the easiest approach to make the filtering works in the ERM module.
> Could we move that to its own bug?

Opened bug 33480.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||33480


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33480
[Bug 33480] Improve display of the vendor aliases in the ERM module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #36 from Jonathan Druart  ---
Created attachment 149414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149414&action=edit
Bug 33103: Fix accessibility issues

* Add spaces
* Add 'Add' and 'Remove' in addition of the icons
* Do not submit the form when enter is hit
* Fix translatability

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #35 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #34)

Thanks, Katrin!

> 1) Please check:
>  FAIL Koha/Acquisition/Bookseller/Alias.pm
>FAIL pod coverage
>   POD coverage was greater before, try perl 
> -MPod::Coverage=PackageName -e666

False positive.

>  OK   Koha/Acquisition/Bookseller/Aliases.pm
>  OK   Koha/Schema/Result/Aqbookseller.pm
>  FAIL Koha/Schema/Result/AqbooksellerAlias.pm
>FAIL pod coverage
>   POD is missing for koha_object_class
>   POD is missing for koha_objects_class

POD is always missing for those methods. Nothing to worry here.

> 2) Vendor detail page
> 
> * We should add some space between the the alias name and the trash
> * More important: it needs at least a tool tip, right now it's a big
> accessibility issue. I believe with aria-hidden=true it will actually be
> invisible to screen readers?
> * Same goes for the Plus icon to add another field: space and accessibility.
> * When you click 'enter' in the field, the form submits 'save' and you are
> back on the detail page, but the alias was not saved.

Fixed in "Fix accessibility issues"

> 3) Other features
> 
> * Search and display in the aquisition module work nicely
> 
> 4) ERM module
> 
> I am not persuaded by the display tbh, I believe it will get messy very soon
> as often those aliases will be quite long and we might even want to record a
> slight name change. 
> 
> Could it be an option to show the aliases in the list as "second level"
> entries, kind of a hiearchical display, like we have it for funds? 
> 
> 
> I know that CORAL uses the aliases also for matching in some form (I believe
> when importing data), so it will be really nice to have this feature.

It was the easiest approach to make the filtering works in the ERM module.
Could we move that to its own bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #34 from Katrin Fischer  ---
1) Please check:

 OK Koha/Acquisition/Bookseller.pm
 FAIL   Koha/Acquisition/Bookseller/Alias.pm
   FAIL   pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 OK Koha/Acquisition/Bookseller/Aliases.pm
 OK Koha/Schema/Result/Aqbookseller.pm
 FAIL   Koha/Schema/Result/AqbooksellerAlias.pm
   FAIL   pod coverage
POD is missing for koha_object_class
POD is missing for koha_objects_class

2) Vendor detail page

* We should add some space between the the alias name and the trash
* More important: it needs at least a tool tip, right now it's a big
accessibility issue. I believe with aria-hidden=true it will actually be
invisible to screen readers?
* Same goes for the Plus icon to add another field: space and accessibility.
* When you click 'enter' in the field, the form submits 'save' and you are back
on the detail page, but the alias was not saved.


3) Other features

* Search and display in the aquisition module work nicely

4) ERM module

I am not persuaded by the display tbh, I believe it will get messy very soon as
often those aliases will be quite long and we might even want to record a
slight name change. 

Could it be an option to show the aliases in the list as "second level"
entries, kind of a hiearchical display, like we have it for funds? 


I know that CORAL uses the aliases also for matching in some form (I believe
when importing data), so it will be really nice to have this feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #147827|0   |1
is obsolete||

--- Comment #33 from Jonathan Druart  ---
Created attachment 148458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148458&action=edit
Bug 33103: Deal with html tags

HTML tags won't be interpreted. However 

[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #147654|0   |1
is obsolete||

--- Comment #32 from Jonathan Druart  ---
Created attachment 148457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148457&action=edit
Bug 33103: Display the aliases in the dropdown list in ERM

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #147653|0   |1
is obsolete||

--- Comment #31 from Jonathan Druart  ---
Created attachment 148456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148456&action=edit
Bug 33103: Add REST API tests

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #147652|0   |1
is obsolete||

--- Comment #30 from Jonathan Druart  ---
Created attachment 148455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148455&action=edit
Bug 33103: Embed aliases in GET /vendors

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #147651|0   |1
is obsolete||

--- Comment #29 from Jonathan Druart  ---
Created attachment 148454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148454&action=edit
Bug 33103: Make vendors searchable by aliases

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #147650|0   |1
is obsolete||

--- Comment #28 from Jonathan Druart  ---
Created attachment 148453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148453&action=edit
Bug 33103: Add the ability to create vendor aliases

This patchset is adding the ability to create aliases for vendors. It
will then be easier to search for vendors.

* new DB table aqbookseller_aliases(id, vendor_id, alias)
* new pair of Koha classes Koha::Acquisition::Bookseller::Alias[es]
* new method to retrieve the aliases from the vendor
Koha::Acquisition::Bookseller->aliases
* The api spec changes to allow aliases to be embeded on
GET /acquisitions/vendors
* Add/Delete alias when editing a vendor
* Display the aliases on the vendor show view
* Search vendors by aliases
* Display the aliases in the dropdown list of the vendors in the ERM
module

Test plan:
- Create a vendor, add it some aliases
- Edit the vendor, remove some aliases
=> Behaviour must be consistent
- Search the vendor in the acquisition module by its aliases
=> The vendor must be returned in the result
- Go to the ERM module, add a new agreement or license
=> Notice that the dropdown list of the vendors is displaying the
aliases, that make vendors searchable by their aliases

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #147649|0   |1
is obsolete||

--- Comment #27 from Jonathan Druart  ---
Created attachment 148452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148452&action=edit
Bug 33103: Add tests for Aliases Koha classes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #147648|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart  ---
Created attachment 148451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148451&action=edit
Bug 33103: Koha classes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #147647|0   |1
is obsolete||

--- Comment #25 from Jonathan Druart  ---
Created attachment 148450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148450&action=edit
Bug 33103: DBIC specific

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #147646|0   |1
is obsolete||

--- Comment #24 from Jonathan Druart  ---
Created attachment 148449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148449&action=edit
Bug 33103: DBIC changes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #147645|0   |1
is obsolete||

--- Comment #23 from Jonathan Druart  ---
Created attachment 148448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148448&action=edit
Bug 33103: DB changes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #22 from Jonathan Druart  ---
Created attachment 147827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147827&action=edit
Bug 33103: Deal with html tags

HTML tags won't be interpreted. However 

[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #21 from Jonathan Druart  ---
I need to investigate possible XSS here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Field  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #147630|0   |1
is obsolete||

--- Comment #20 from PTFS Europe Sandboxes  ---
Created attachment 147654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147654&action=edit
Bug 33103: Display the aliases in the dropdown list in ERM

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #147629|0   |1
is obsolete||

--- Comment #19 from PTFS Europe Sandboxes  ---
Created attachment 147653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147653&action=edit
Bug 33103: Add REST API tests

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #147628|0   |1
is obsolete||

--- Comment #18 from PTFS Europe Sandboxes  ---
Created attachment 147652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147652&action=edit
Bug 33103: Embed aliases in GET /vendors

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #147627|0   |1
is obsolete||

--- Comment #17 from PTFS Europe Sandboxes  ---
Created attachment 147651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147651&action=edit
Bug 33103: Make vendors searchable by aliases

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #147626|0   |1
is obsolete||

--- Comment #16 from PTFS Europe Sandboxes  ---
Created attachment 147650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147650&action=edit
Bug 33103: Add the ability to create vendor aliases

This patchset is adding the ability to create aliases for vendors. It
will then be easier to search for vendors.

* new DB table aqbookseller_aliases(id, vendor_id, alias)
* new pair of Koha classes Koha::Acquisition::Bookseller::Alias[es]
* new method to retrieve the aliases from the vendor
Koha::Acquisition::Bookseller->aliases
* The api spec changes to allow aliases to be embeded on
GET /acquisitions/vendors
* Add/Delete alias when editing a vendor
* Display the aliases on the vendor show view
* Search vendors by aliases
* Display the aliases in the dropdown list of the vendors in the ERM
module

Test plan:
- Create a vendor, add it some aliases
- Edit the vendor, remove some aliases
=> Behaviour must be consistent
- Search the vendor in the acquisition module by its aliases
=> The vendor must be returned in the result
- Go to the ERM module, add a new agreement or license
=> Notice that the dropdown list of the vendors is displaying the
aliases, that make vendors searchable by their aliases

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #147625|0   |1
is obsolete||

--- Comment #15 from PTFS Europe Sandboxes  ---
Created attachment 147649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147649&action=edit
Bug 33103: Add tests for Aliases Koha classes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #147624|0   |1
is obsolete||

--- Comment #14 from PTFS Europe Sandboxes  ---
Created attachment 147648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147648&action=edit
Bug 33103: Koha classes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #147623|0   |1
is obsolete||

--- Comment #13 from PTFS Europe Sandboxes  ---
Created attachment 147647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147647&action=edit
Bug 33103: DBIC specific

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #147622|0   |1
is obsolete||

--- Comment #12 from PTFS Europe Sandboxes  ---
Created attachment 147646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147646&action=edit
Bug 33103: DBIC changes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #147621|0   |1
is obsolete||

--- Comment #11 from PTFS Europe Sandboxes  ---
Created attachment 147645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147645&action=edit
Bug 33103: DB changes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||33104


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104
[Bug 33104] Add vendor Interfaces
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #10 from Jonathan Druart  ---
Created attachment 147630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147630&action=edit
Bug 33103: Display the aliases in the dropdown list in ERM

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #9 from Jonathan Druart  ---
Created attachment 147629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147629&action=edit
Bug 33103: Add REST API tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #8 from Jonathan Druart  ---
Created attachment 147628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147628&action=edit
Bug 33103: Embed aliases in GET /vendors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #7 from Jonathan Druart  ---
Created attachment 147627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147627&action=edit
Bug 33103: Make vendors searchable by aliases

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #6 from Jonathan Druart  ---
Created attachment 147626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147626&action=edit
Bug 33103: Add the ability to create vendor aliases

This patchset is adding the ability to create aliases for vendors. It
will then be easier to search for vendors.

* new DB table aqbookseller_aliases(id, vendor_id, alias)
* new pair of Koha classes Koha::Acquisition::Bookseller::Alias[es]
* new method to retrieve the aliases from the vendor
Koha::Acquisition::Bookseller->aliases
* The api spec changes to allow aliases to be embeded on
GET /acquisitions/vendors
* Add/Delete alias when editing a vendor
* Display the aliases on the vendor show view
* Search vendors by aliases
* Display the aliases in the dropdown list of the vendors in the ERM
module

Test plan:
- Create a vendor, add it some aliases
- Edit the vendor, remove some aliases
=> Behaviour must be consistent
- Search the vendor in the acquisition module by its aliases
=> The vendor must be returned in the result
- Go to the ERM module, add a new agreement or license
=> Notice that the dropdown list of the vendors is displaying the
aliases, that make vendors searchable by their aliases

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #5 from Jonathan Druart  ---
Created attachment 147625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147625&action=edit
Bug 33103: Add tests for Aliases Koha classes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #4 from Jonathan Druart  ---
Created attachment 147624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147624&action=edit
Bug 33103: Koha classes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #3 from Jonathan Druart  ---
Created attachment 147623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147623&action=edit
Bug 33103: DBIC specific

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #2 from Jonathan Druart  ---
Created attachment 147622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147622&action=edit
Bug 33103: DBIC changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

--- Comment #1 from Jonathan Druart  ---
Created attachment 147621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147621&action=edit
Bug 33103: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-03-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.field@ptfs-europe.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/