[Koha-bugs] [Bug 33105] Add vendor issues

2023-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Nick Clemens  changed:

   What|Removed |Added

 Blocks||35634


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35634
[Bug 35634] Permissions mismatch for vendor issues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to master|Needs documenting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-11-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||Caroline Cyr La Rose
contact||
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/750
 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-11-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Keywords|Manual  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|For vendors who, in |For vendors who, in
  release notes|particular, provide |particular, provide
   |electronic services (e.g.   |electronic services (e.g.
   |ejournal providers) it is   |eJournal providers) it is
   |useful to be able to record |useful to be able to record
   |service issues. This is |service issues.
   |important for recording |
   |vendor performance against  |This new
   |contract. This could|feature allows for
   |include, for example,   |recording such details, for
   |problems logging into   |example logging login
   |services, online|problems, service
   |availability etc.   |interruptions and incorrect
   ||availability.
   ||
   ||This is
   ||important as evidence when
   ||submitting contract
   ||negotiations and judging
   ||vendor performance against
   ||existing contracts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|For vendors who, in |For vendors who, in
  release notes|particular, provide |particular, provide
   |electronic services (e.g.   |electronic services (e.g.
   |eJournal providers) it is   |eJournal providers) it is
   |useful to be able to record |useful to be able to record
   |service issues.
|service issues.
   |
   |
   |This new|This new
   |feature allows for  |feature allows for
   |recording such details, for |recording such details, for
   |example logging login   |example logging login
   |problems, service   |problems, service
   |interruptions and incorrect |interruptions and incorrect
   |availability.
  |availability.
   |
   |
   |This is |This is
   |important as evidence when  |important as evidence when
   |submitting contract |submitting contract
   |negotiations and judging|negotiations and judging
   |vendor performance against  |vendor performance against
   |existing contracts. |existing contracts.
   ||
   ||**Sponsored by** *Bywater
   ||Solutions* and *PTFS Europe
   ||Ltd*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #149556|0   |1
is obsolete||

--- Comment #20 from Marcel de Rooy  ---
Created attachment 152894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152894&action=edit
Bug 33105: DB changes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #149559|0   |1
is obsolete||

--- Comment #21 from Marcel de Rooy  ---
Created attachment 152895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152895&action=edit
Bug 33105: Add Koha object classes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #149560|0   |1
is obsolete||

--- Comment #22 from Marcel de Rooy  ---
Created attachment 152896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152896&action=edit
Bug 33105: Add vendor issues

This patch is the main patch of this patch set, it contains the
controller acqui/vendor_issues.pl, its corresponding template, and some
links to this script.

It adds:
* A new DB table aqbookseller_issues linked with the aqbooksellers table
* A new subpermission acquisition.issue_manage
* A new authorised value category VENDOR_ISSUE_TYPE and two examples
MAINTENANCE and OUTAGE
* A new controller couple acqui/vendor_issues.[pl,tt]

Test plan:
0. Apply the patches, run updatedatabase and restart_all
1. Go to the acquisition module, create a new vendor or use an existing
one
2. Create a couple of issues for this vendor
3. Edit/Delete and search for those issues

This is the basics for tracking issues with vendors.
Suggestions welcome, on follow-up bug reports.

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #149561|0   |1
is obsolete||

--- Comment #23 from Marcel de Rooy  ---
Created attachment 152897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152897&action=edit
Bug 33105: REST API specs

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #149562|0   |1
is obsolete||

--- Comment #24 from Marcel de Rooy  ---
Created attachment 152898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152898&action=edit
Bug 33105: Add tests

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #25 from Marcel de Rooy  ---
Created attachment 152899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152899&action=edit
Bug 33105: [DBIx] Schema changes

Former patches did not apply anymore. Refreshed them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #149558|0   |1
is obsolete||

--- Comment #26 from Marcel de Rooy  ---
Created attachment 152900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152900&action=edit
Bug 33105: DBIC specific

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #27 from Marcel de Rooy  ---
Not able to finish now. Rebased/refreshed dbix stuff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #149557|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #28 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #27)
> Not able to finish now. Rebased/refreshed dbix stuff.

Continuing here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #29 from Marcel de Rooy  ---
acqui/vendor_issues.pl demonstrates a point that is larger than this script:
$issue = Koha::Acquisition::Bookseller::Issues->find($issue_id);
We have a name clash with the issues table, so it would have been nicer to
specify vendor_issue here in naming variables.
No blocker just noting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #30 from Marcel de Rooy  ---
  vendor_id:
type:
  - string
  started_on:
type:
  - string
  ended_on:
type:
  - string

Was expecting a numeric id and dates ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #31 from Marcel de Rooy  ---
Plural or singular? Confusion !

+  vendor_issue:
+$ref: ./definitions/vendor_issue.yaml
+  "/acquisitions/vendors/{vendor_id}/issues":
+$ref:
"./paths/acquisitions_vendor_issues.yaml#/~1acquisitions~1vendors~1{vendor_id}~1issues"

Wny vendor and acquisition_vendor btw ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #32 from Marcel de Rooy  ---
TODO kohastructure

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #33 from Marcel de Rooy  ---
Can't call method "issues" on an undefined value at
/usr/share/koha/acqui/vendor_issues.pl line 103.  at
/usr/share/koha/acqui/vendor_issues.pl line 102
When there is no vendor. Tried to use output_and_exit. But it needs more
attention.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #34 from Marcel de Rooy  ---
Created attachment 153117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153117&action=edit
Bug 33105: (QA follow-up) Small changes in dbrev

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #35 from Marcel de Rooy  ---
Created attachment 153118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153118&action=edit
Bug 33105: (QA follow-up) Changes for Koha objects

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #36 from Marcel de Rooy  ---
Created attachment 153119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153119&action=edit
Bug 33105: (QA follow-up) REST API

Includes removing q_header.
Inconsistent use of quotes for response codes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #37 from Marcel de Rooy  ---
This is not ready yet. Wonder why this got signed off?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #38 from Jonathan Druart  ---
Created attachment 153122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153122&action=edit
Bug 33105: Fix vendor api spec

vendor ID must be integer and date attributes should specify the format
accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #39 from Jonathan Druart  ---
Created attachment 153123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153123&action=edit
Bug 33105: Redirect to 404 if no vendor exists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #40 from Jonathan Druart  ---
(In reply to Marcel de Rooy from comment #29)
> acqui/vendor_issues.pl demonstrates a point that is larger than this script:
> $issue = Koha::Acquisition::Bookseller::Issues->find($issue_id);
> We have a name clash with the issues table, so it would have been nicer to
> specify vendor_issue here in naming variables.
> No blocker just noting.

well, 'issue' in the code should be checkout when it's about checkouts. If you
see $vendor->issue you know given the context that it's about vendor's issues,
not checkout.
I can rename if you want but I don't think it's needed.

(In reply to Marcel de Rooy from comment #30)
>   vendor_id:
> type:
>   - string
>   started_on:
> type:
>   - string
>   ended_on:
> type:
>   - string
> 
> Was expecting a numeric id and dates ?

vendor_id must be integer, yes.
dates have a type=string. Could have a format=date however, I totally
overlooked that.
Done in commit "Fix vendor api spec"

(In reply to Marcel de Rooy from comment #31)
> Plural or singular? Confusion !

Where? vendor_issue.yaml is the definition file for a given issue, hence the
singular.
acquisitions_vendor_issues.yaml is the path for the /issues endpoint. It's
following the convention.

> +  vendor_issue:
> +$ref: ./definitions/vendor_issue.yaml
> +  "/acquisitions/vendors/{vendor_id}/issues":
> +$ref:
> "./paths/acquisitions_vendor_issues.yaml#/
> ~1acquisitions~1vendors~1{vendor_id}~1issues"
> 
> Wny vendor and acquisition_vendor btw ?

"acquisitions_vendor_issues" to copy "acquisitions_orders.yaml" and keep
consistency. Same for the definition file: vendor.yaml vendor_alias.yaml
vendor_issue.yaml order.yaml
We could/should all prefixed them with 'acquisitions', but that's not for this
bug.

(In reply to Marcel de Rooy from comment #32)
> TODO kohastructure

What's missing there?

(In reply to Marcel de Rooy from comment #33)
> Can't call method "issues" on an undefined value at
> /usr/share/koha/acqui/vendor_issues.pl line 103.  at
> /usr/share/koha/acqui/vendor_issues.pl line 102
> When there is no vendor. Tried to use output_and_exit. But it needs more
> attention.

Done in "Redirect to 404 if no vendor exists"

(In reply to Marcel de Rooy from comment #37)
> This is not ready yet. Wonder why this got signed off?

Because it was working according to the test plan? :)

Thanks for the follow-ups, they all make sense!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #41 from Marcel de Rooy  ---
Revisiting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #42 from Marcel de Rooy  ---
> (In reply to Marcel de Rooy from comment #37)
> > This is not ready yet. Wonder why this got signed off?
> 
> Because it was working according to the test plan? :)

Hmm. A test plan can be incomplete.
Here is another problem:
Add an issue. Delete it. Say no. Response is 404. That is not good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #153123|0   |1
is obsolete||

--- Comment #43 from Jonathan Druart  ---
Created attachment 153125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153125&action=edit
Bug 33105: Redirect to 404 if no vendor exists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #44 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #40)
> (In reply to Marcel de Rooy from comment #32)
> > TODO kohastructure
> 
> What's missing there?
> 

Nothing. Now I remember that I was searching for vendor_issues in it. And it
should be aqbookseller_issues, so nice ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #45 from Marcel de Rooy  ---
REST API problem

/api/v1/acquisitions/vendors/7/issues is working fine (you use it on the form)
but /api/v1/acquisitions/vendors/7/issues/4 or the single GET does not work.
Responds with 404.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #46 from Marcel de Rooy  ---
Same problem for DELETE via REST API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #152894|0   |1
is obsolete||

--- Comment #47 from Marcel de Rooy  ---
Created attachment 153126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153126&action=edit
Bug 33105: DB changes

Signed-off-by: Jonathan Field 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #152895|0   |1
is obsolete||

--- Comment #48 from Marcel de Rooy  ---
Created attachment 153127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153127&action=edit
Bug 33105: Add Koha object classes

Signed-off-by: Jonathan Field 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #152896|0   |1
is obsolete||

--- Comment #49 from Marcel de Rooy  ---
Created attachment 153128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153128&action=edit
Bug 33105: Add vendor issues

This patch is the main patch of this patch set, it contains the
controller acqui/vendor_issues.pl, its corresponding template, and some
links to this script.

It adds:
* A new DB table aqbookseller_issues linked with the aqbooksellers table
* A new subpermission acquisition.issue_manage
* A new authorised value category VENDOR_ISSUE_TYPE and two examples
MAINTENANCE and OUTAGE
* A new controller couple acqui/vendor_issues.[pl,tt]

Test plan:
0. Apply the patches, run updatedatabase and restart_all
1. Go to the acquisition module, create a new vendor or use an existing
one
2. Create a couple of issues for this vendor
3. Edit/Delete and search for those issues

This is the basics for tracking issues with vendors.
Suggestions welcome, on follow-up bug reports.

Signed-off-by: Jonathan Field 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #152897|0   |1
is obsolete||

--- Comment #50 from Marcel de Rooy  ---
Created attachment 153129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153129&action=edit
Bug 33105: REST API specs

Signed-off-by: Jonathan Field 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #152898|0   |1
is obsolete||

--- Comment #51 from Marcel de Rooy  ---
Created attachment 153130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153130&action=edit
Bug 33105: Add tests

Signed-off-by: Jonathan Field 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #152899|0   |1
is obsolete||

--- Comment #52 from Marcel de Rooy  ---
Created attachment 153131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153131&action=edit
Bug 33105: [DBIx] Schema changes

Former patches did not apply anymore. Refreshed them.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #152900|0   |1
is obsolete||

--- Comment #53 from Marcel de Rooy  ---
Created attachment 153132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153132&action=edit
Bug 33105: DBIC specific

Signed-off-by: Jonathan Field 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #153117|0   |1
is obsolete||

--- Comment #54 from Marcel de Rooy  ---
Created attachment 153133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153133&action=edit
Bug 33105: (QA follow-up) Small changes in dbrev

Similar edit in kohastructure added.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #153118|0   |1
is obsolete||

--- Comment #55 from Marcel de Rooy  ---
Created attachment 153134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153134&action=edit
Bug 33105: (QA follow-up) Changes for Koha objects

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #153119|0   |1
is obsolete||

--- Comment #56 from Marcel de Rooy  ---
Created attachment 153135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153135&action=edit
Bug 33105: (QA follow-up) REST API

Includes removing q_header.
Inconsistent use of quotes for response codes.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #153122|0   |1
is obsolete||

--- Comment #57 from Marcel de Rooy  ---
Created attachment 153136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153136&action=edit
Bug 33105: Fix vendor api spec

vendor ID must be integer and date attributes should specify the format
accordingly.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #153125|0   |1
is obsolete||

--- Comment #58 from Marcel de Rooy  ---
Created attachment 153137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153137&action=edit
Bug 33105: Redirect to 404 if no vendor exists

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Severity|enhancement |new feature
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||Manual,
   ||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Jonathan Field  changed:

   What|Removed |Added

  Documentation||For vendors who, in
 submission||particular, provide
   ||electronic services (e.g.
   ||ejournal providers) it is
   ||useful to be able to record
   ||service issues. This is
   ||important for recording
   ||vendor performance against
   ||contract.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Jonathan Field  changed:

   What|Removed |Added

  Text to go in the||For vendors who, in
  release notes||particular, provide
   ||electronic services (e.g.
   ||ejournal providers) it is
   ||useful to be able to record
   ||service issues. This is
   ||important for recording
   ||vendor performance against
   ||contract. This could
   ||include, for example,
   ||problems logging into
   ||services, online
   ||availability etc.
  Documentation|For vendors who, in |
 submission|particular, provide |
   |electronic services (e.g.   |
   |ejournal providers) it is   |
   |useful to be able to record |
   |service issues. This is |
   |important for recording |
   |vendor performance against  |
   |contract.   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #59 from Tomás Cohen Arazi  ---
Not going to block this, but we added the 'OPAC concerns' and now the 'vendor
issues'. Should we think of a more generic approach?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #60 from Jonathan Druart  ---
(In reply to Tomás Cohen Arazi from comment #59)
> Not going to block this, but we added the 'OPAC concerns' and now the
> 'vendor issues'. Should we think of a more generic approach?

Hum I don't think so, they are two completely different things. One is linked
with the acquisition module for external entities, OPAC concerns is for OPAC
users. I don't see how we could merge them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #61 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #60)
> (In reply to Tomás Cohen Arazi from comment #59)
> > Not going to block this, but we added the 'OPAC concerns' and now the
> > 'vendor issues'. Should we think of a more generic approach?
> 
> Hum I don't think so, they are two completely different things. One is
> linked with the acquisition module for external entities, OPAC concerns is
> for OPAC users. I don't see how we could merge them.

Besides the UI differences, I see 'ticket type X' and 'ticket type Y'. I had
the same concerns about the 'OPAC record concerns ' feature as being too
specific by design.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #62 from Jonathan Druart  ---
(In reply to Tomás Cohen Arazi from comment #61)
> (In reply to Jonathan Druart from comment #60)
> > (In reply to Tomás Cohen Arazi from comment #59)
> > > Not going to block this, but we added the 'OPAC concerns' and now the
> > > 'vendor issues'. Should we think of a more generic approach?
> > 
> > Hum I don't think so, they are two completely different things. One is
> > linked with the acquisition module for external entities, OPAC concerns is
> > for OPAC users. I don't see how we could merge them.
> 
> Besides the UI differences, I see 'ticket type X' and 'ticket type Y'. I had
> the same concerns about the 'OPAC record concerns ' feature as being too
> specific by design.

The table name was not specific: "tickets" :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #63 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #62)
> (In reply to Tomás Cohen Arazi from comment #61)
> > (In reply to Jonathan Druart from comment #60)
> > > (In reply to Tomás Cohen Arazi from comment #59)
> > > > Not going to block this, but we added the 'OPAC concerns' and now the
> > > > 'vendor issues'. Should we think of a more generic approach?
> > > 
> > > Hum I don't think so, they are two completely different things. One is
> > > linked with the acquisition module for external entities, OPAC concerns is
> > > for OPAC users. I don't see how we could merge them.
> > 
> > Besides the UI differences, I see 'ticket type X' and 'ticket type Y'. I had
> > the same concerns about the 'OPAC record concerns ' feature as being too
> > specific by design.
> 
> The table name was not specific: "tickets" :D

The table name got the right name, that's true. But we have 

concerns.pl
concerns.tt

and all the tools are named 'catalog_concern.*'. Including the admin pages.

Not complaining, just saying that we might need to think of a more general
approach at some point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #64 from Martin Renvoize  ---
I think I left follow-up bugs to generalise that.. I was heading towards a more
generalised enquiry management flow but I had to also keep the sponsor happy..
hense the API design trying hard to generalise and then my aim was to migrate
to vue and a new 'enquiries' module once some of the vue stuff had settled (at
the time I coded catalogue concerns, we'd not made anywhere near the progress
in vue).

I'd love to see a much more generalise enquiries/workflows entity and am happy
to contribute in that space.. we're currently working on sponsorship for it
here at ptfs-e.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||34255


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255
[Bug 34255] Add an enquiry/request/workflow management module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #65 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #60)
> (In reply to Tomás Cohen Arazi from comment #59)
> > Not going to block this, but we added the 'OPAC concerns' and now the
> > 'vendor issues'. Should we think of a more generic approach?
> 
> Hum I don't think so, they are two completely different things. One is
> linked with the acquisition module for external entities, OPAC concerns is
> for OPAC users. I don't see how we could merge them.

A generic approach would only make sense tome if the workflow around such
concerns and issues is kind of the same.

The fact that we have e.g. lists and patron lists does not mean that they
should be merged in one table. Etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #66 from Katrin Fischer  ---
I feel like the 'OPAC problems' and 'Catalog concerns' are a closer match than
the vendor issues. 

At the moment the vendor issues are not about communicating problems, but about
tracking them, while the other two features are both about reporting something
to the library with the ability to reply/resolve. I think it would make sense
merging them first and leave this be.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|34255   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255
[Bug 34255] Add an enquiry/request/workflow management module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||34255


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255
[Bug 34255] Add an enquiry/request/workflow management module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #67 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #68 from Jonathan Druart  ---
Created attachment 153730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153730&action=edit
Bug 33105: (follow-up) DB changes

boooh!

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #69 from Jonathan Druart  ---
Created attachment 153731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153731&action=edit
Bug 33105: Fix Auth/Permissions.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #70 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #68)
> Created attachment 153730 [details] [review]
> Bug 33105: (follow-up) DB changes
> 
> boooh!
> 
> Signed-off-by: Jonathan Druart 

This has been pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|release-notes-needed|additional_work_needed

--- Comment #71 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #69)
> Created attachment 153731 [details] [review]
> Bug 33105: Fix Auth/Permissions.t

Still need to be pushed.

I am not sure those tests are really useful...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #72 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #71)
> (In reply to Jonathan Druart from comment #69)
> > Created attachment 153731 [details] [review] [review]
> > Bug 33105: Fix Auth/Permissions.t
> 
> Still need to be pushed.
> 
> I am not sure those tests are really useful...

Pushed, thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #73 from Fridolin Somers  ---
New feature not pushed to 23.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-03-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.field@ptfs-europe.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #1 from Jonathan Druart  ---
Created attachment 149509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149509&action=edit
Bug 33105: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #2 from Jonathan Druart  ---
Created attachment 149510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149510&action=edit
Bug 33105: DBIC schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #3 from Jonathan Druart  ---
Created attachment 149511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149511&action=edit
Bug 33105: DBIC specific

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #4 from Jonathan Druart  ---
Created attachment 149512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149512&action=edit
Bug 33105: Add Koha object classes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #5 from Jonathan Druart  ---
Created attachment 149513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149513&action=edit
Bug 33105: Add vendor issues

This patch is the main patch of this patch set, it contains the
controller acqui/vendor_issues.pl, its corresponding template, and some
links to this script.

It adds:
* A new DB table aqbookseller_issues linked with the aqbooksellers table
* A new subpermission acquisition.issue_manage
* A new authorised value category VENDOR_ISSUE_TYPE and two examples
MAINTENANCE and OUTAGE
* A new controller couple acqui/vendor_issues.[pl,tt]

Test plan:
0. Apply the patches, run updatedatabase and restart_all
1. Go to the acquisition module, create a new vendor or use an existing
one
2. Create a couple of issues for this vendor
3. Edit/Delete and search for those issues

This is the basics for tracking issues with vendors.
Suggestions welcome, on follow-up bug reports.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #6 from Jonathan Druart  ---
Created attachment 149514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149514&action=edit
Bug 33105: REST API specs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #7 from Jonathan Druart  ---
Created attachment 149515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149515&action=edit
Bug 33105: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||33104


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104
[Bug 33104] Add vendor interfaces
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Jonathan Field  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #8 from Jonathan Field  ---
Deletion is currently failing due to a typo in vendor_issues.pl

cgi-bin/koha/acqui/vendor_iddues.pl?op=delete_confirm&issue_id=1

iddues instead of issues. Looking good otherwise!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #149513|0   |1
is obsolete||
 Attachment #149514|0   |1
is obsolete||
 Attachment #149515|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  ---
Created attachment 149530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149530&action=edit
Bug 33105: Add vendor issues

This patch is the main patch of this patch set, it contains the
controller acqui/vendor_issues.pl, its corresponding template, and some
links to this script.

It adds:
* A new DB table aqbookseller_issues linked with the aqbooksellers table
* A new subpermission acquisition.issue_manage
* A new authorised value category VENDOR_ISSUE_TYPE and two examples
MAINTENANCE and OUTAGE
* A new controller couple acqui/vendor_issues.[pl,tt]

Test plan:
0. Apply the patches, run updatedatabase and restart_all
1. Go to the acquisition module, create a new vendor or use an existing
one
2. Create a couple of issues for this vendor
3. Edit/Delete and search for those issues

This is the basics for tracking issues with vendors.
Suggestions welcome, on follow-up bug reports.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #10 from Jonathan Druart  ---
Created attachment 149531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149531&action=edit
Bug 33105: REST API specs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #11 from Jonathan Druart  ---
Created attachment 149532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149532&action=edit
Bug 33105: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

--- Comment #12 from Jonathan Druart  ---
(In reply to Jonathan Field from comment #8)
> Deletion is currently failing due to a typo in vendor_issues.pl

oops, should be fixed now!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #149509|0   |1
is obsolete||

--- Comment #13 from PTFS Europe Sandboxes  ---
Created attachment 149556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149556&action=edit
Bug 33105: DB changes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #149510|0   |1
is obsolete||

--- Comment #14 from PTFS Europe Sandboxes  ---
Created attachment 149557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149557&action=edit
Bug 33105: DBIC schema changes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #149511|0   |1
is obsolete||

--- Comment #15 from PTFS Europe Sandboxes  ---
Created attachment 149558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149558&action=edit
Bug 33105: DBIC specific

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #149512|0   |1
is obsolete||

--- Comment #16 from PTFS Europe Sandboxes  ---
Created attachment 149559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149559&action=edit
Bug 33105: Add Koha object classes

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #149530|0   |1
is obsolete||

--- Comment #17 from PTFS Europe Sandboxes  ---
Created attachment 149560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149560&action=edit
Bug 33105: Add vendor issues

This patch is the main patch of this patch set, it contains the
controller acqui/vendor_issues.pl, its corresponding template, and some
links to this script.

It adds:
* A new DB table aqbookseller_issues linked with the aqbooksellers table
* A new subpermission acquisition.issue_manage
* A new authorised value category VENDOR_ISSUE_TYPE and two examples
MAINTENANCE and OUTAGE
* A new controller couple acqui/vendor_issues.[pl,tt]

Test plan:
0. Apply the patches, run updatedatabase and restart_all
1. Go to the acquisition module, create a new vendor or use an existing
one
2. Create a couple of issues for this vendor
3. Edit/Delete and search for those issues

This is the basics for tracking issues with vendors.
Suggestions welcome, on follow-up bug reports.

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #149531|0   |1
is obsolete||

--- Comment #18 from PTFS Europe Sandboxes  ---
Created attachment 149561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149561&action=edit
Bug 33105: REST API specs

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #149532|0   |1
is obsolete||

--- Comment #19 from PTFS Europe Sandboxes  ---
Created attachment 149562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149562&action=edit
Bug 33105: Add tests

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor Issues

2023-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Jonathan Field  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add vendor Issues   |Add vendor issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-05-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105
Bug 33105 depends on bug 33104, which changed state.

Bug 33104 Summary: Add vendor interfaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/