[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED
 CC||lu...@bywatersolutions.com

--- Comment #17 from Lucas Gass  ---
Not needed in 22.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #16 from Martin Renvoize  ---
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.05.00|23.05.00,22.11.04
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #15 from Martin Renvoize  ---
oop.. wrong bug!.. ignore that.. this one is still in the queue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #14 from Martin Renvoize  ---
Final follow-up pushed to 22.11.x for 22.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

--- Comment #13 from Jonathan Druart  ---
Pushed to master for 23.05. We want jenkins happy to start the hackfest :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #148512|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  ---
Created attachment 148631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148631=edit
Bug 33282: Feed an array of titles so that no dialog message appears

Including but not limited to the one we're testing for

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32898,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33235

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|pedro.amo...@ptfs-europe.co
   ||m

--- Comment #11 from Jonathan Druart  ---
I've got the failure once (using cypress open), then no more.

I think we should move forward with these patches, and fix the random failure
separately.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #10 from Jonathan Druart  ---
Created attachment 148512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148512=edit
Bug 33282: Feed an array of titles so that no dialog message appears, including
but not limited to the one we're testing for

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #9 from Jonathan Druart  ---
Created attachment 148511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148511=edit
Bug 33282: Move get_title to index.js to be invoked by different specs

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #8 from Jonathan Druart  ---
Created attachment 148510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148510=edit
Bug 33282: Remove useless intercept

JD amended patch: replace "redundant" with "useless". It's not the same
intercept, but we don't need the one removed by this patch.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #148427|0   |1
is obsolete||
 Attachment #148428|0   |1
is obsolete||
 Attachment #148429|0   |1
is obsolete||
 Attachment #148430|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  ---
Created attachment 148509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148509=edit
Bug 33282: Rename Dialog.spec.ts to Dialog_spec.ts

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #6 from Jonathan Druart  ---
(In reply to Pedro Amorim from comment #5)
> This is not done yet, there's something weird happening with
> Packages_specs.ts.
> It doesn't fail running cypress open, but sometimes fails running cypress
> through CLI (headless), it's hard to pinpoint because it doesn't always fail.
> 
> I think it's something to do with the loading dialog modal.
> Following the tests in the browser, the "Loading..." dialog modal is always
> present, and it seems to sometimes block a click() in Packages_specs.ts.
> Instead of just adding {force:true} to the click(), I'm trying to figure out
> why "Loading..." modal never stops showing with Cypress on the browser, but
> haven't figured it out yet.

Weird!

I've noticed a JS/DT error: 
"(alert) Something went wrong when loading the table. 200: OK."

This is not expected. But it appears even when the tests pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #5 from Pedro Amorim  ---
This is not done yet, there's something weird happening with Packages_specs.ts.
It doesn't fail running cypress open, but sometimes fails running cypress
through CLI (headless), it's hard to pinpoint because it doesn't always fail.

I think it's something to do with the loading dialog modal.
Following the tests in the browser, the "Loading..." dialog modal is always
present, and it seems to sometimes block a click() in Packages_specs.ts.
Instead of just adding {force:true} to the click(), I'm trying to figure out
why "Loading..." modal never stops showing with Cypress on the browser, but
haven't figured it out yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #4 from Pedro Amorim  ---
Created attachment 148430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148430=edit
Bug 33282: Feed an array of titles so that no dialog message appears, including
but not limited to the one we're testing for

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #3 from Pedro Amorim  ---
Created attachment 148429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148429=edit
Bug 33282: Move get_title to index.js to be invoked by different specs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #2 from Pedro Amorim  ---
Created attachment 148428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148428=edit
Bug 33282: Remove redundant intercept

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

--- Comment #1 from Pedro Amorim  ---
Created attachment 148427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148427=edit
Bug 33282: Rename Dialog.spec.ts to Dialog_spec.ts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33282] Cypress tests are failing

2023-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282

Pedro Amorim  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/