[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #32 from Lucas Gass --- Merge conflicts in 22.05.x, no backport. Please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #31 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.06 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #30 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Marcel de Rooy changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de|m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Marcel de Rooy changed: What|Removed |Added Attachment #150475|0 |1 is obsolete|| --- Comment #29 from Marcel de Rooy --- Created attachment 151127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151127=edit Bug 33445: (follow-up) Allow all search fields to be passed through and returned when trying another search It seems the form didn't populate all fields form data passed in. This patch corrects that Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Marcel de Rooy changed: What|Removed |Added Attachment #150474|0 |1 is obsolete|| --- Comment #28 from Marcel de Rooy --- Created attachment 151126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151126=edit Bug 33445: (follow-up) Pass form values through when clicking 'Try another search' We didn't include anything except the authid id in the try again form, this patch extends to cover all the fields Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Marcel de Rooy changed: What|Removed |Added Attachment #150473|0 |1 is obsolete|| --- Comment #27 from Marcel de Rooy --- Created attachment 151125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151125=edit Bug 33445: Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1 - Without the patch, edit a personal name authority record 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name 3 - Click "Replace record via Z39.50/SRU search" 4 - Note that prefilled search field contains the original value, not your name. 5 - Replace the Author (personal) field with your name in the search form 6 - choose a search target, and click Search. 7 - Note that the results of the search are for the original value, not your name 8 - From the details page of a record, click 'Edit -> Replace record via Z3950' 9 - Note form is prefilled 10 - Change value as in 5 and search 11 - Note original term was searched 12 - Apply patch, restart all 13 - Repeat searches as before 14 - Confirm that form is prefilled with record or the updated value 15 - Confirm your entered search terms are always searched Signed-off-by: Phil Ringnalda Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #26 from David Nind --- Apologies for the noise - somehow managed to add the patch with the 'nt' when I signed off. Amended the patch, so should now be correct! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What|Removed |Added Attachment #150472|0 |1 is obsolete|| --- Comment #25 from David Nind --- Created attachment 150475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150475=edit Bug 33445: (follow-up) Allow all search fields to be passed through and returned when trying another search It seems the form didn't populate all fields form data passed in. This patch corrects that Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What|Removed |Added Attachment #150471|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 150474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150474=edit Bug 33445: (follow-up) Pass form values through when clicking 'Try another search' We didn't include anything except the authid id in the try again form, this patch extends to cover all the fields Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What|Removed |Added Attachment #150470|0 |1 is obsolete|| --- Comment #23 from David Nind --- Created attachment 150473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150473=edit Bug 33445: Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1 - Without the patch, edit a personal name authority record 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name 3 - Click "Replace record via Z39.50/SRU search" 4 - Note that prefilled search field contains the original value, not your name. 5 - Replace the Author (personal) field with your name in the search form 6 - choose a search target, and click Search. 7 - Note that the results of the search are for the original value, not your name 8 - From the details page of a record, click 'Edit -> Replace record via Z3950' 9 - Note form is prefilled 10 - Change value as in 5 and search 11 - Note original term was searched 12 - Apply patch, restart all 13 - Repeat searches as before 14 - Confirm that form is prefilled with record or the updated value 15 - Confirm your entered search terms are always searched Signed-off-by: Phil Ringnalda Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #22 from David Nind --- (In reply to Nick Clemens from comment #18) > (In reply to David Nind from comment #16) > > (In reply to Phil Ringnalda from comment #15) > > > > Was just retesting - the nt appears at the top left of the Z3950 search > > window. > > That was a slip, new patch attached Thanks Nick! Now signed off. I added some values to the keyword input field, and these were retained (including 'Try another search'. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What|Removed |Added Attachment #150469|0 |1 is obsolete|| --- Comment #21 from David Nind --- Created attachment 150472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150472=edit Bug 33445: (follow-up) Allow all search fields to be passed through and returned when trying another search It seems the form didn't populate all fields form data passed in. This patch corrects that Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What|Removed |Added Attachment #150467|0 |1 is obsolete|| --- Comment #20 from David Nind --- Created attachment 150471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150471=edit Bug 33445: (follow-up) Pass form values through when clicking 'Try another search' We didn't include anything except the authid id in the try again form, this patch extends to cover all the fields Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What|Removed |Added Attachment #150466|0 |1 is obsolete|| --- Comment #19 from David Nind --- Created attachment 150470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150470=edit Bug 33445: Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1 - Without the patch, edit a personal name authority record 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name 3 - Click "Replace record via Z39.50/SRU search" 4 - Note that prefilled search field contains the original value, not your name. 5 - Replace the Author (personal) field with your name in the search form 6 - choose a search target, and click Search. 7 - Note that the results of the search are for the original value, not your name 8 - From the details page of a record, click 'Edit -> Replace record via Z3950' 9 - Note form is prefilled 10 - Change value as in 5 and search 11 - Note original term was searched 12 - Apply patch, restart all 13 - Repeat searches as before 14 - Confirm that form is prefilled with record or the updated value 15 - Confirm your entered search terms are always searched Signed-off-by: Phil Ringnalda Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #18 from Nick Clemens --- (In reply to David Nind from comment #16) > (In reply to Phil Ringnalda from comment #15) > > Was just retesting - the nt appears at the top left of the Z3950 search > window. That was a slip, new patch attached -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Nick Clemens changed: What|Removed |Added Attachment #150468|0 |1 is obsolete|| --- Comment #17 from Nick Clemens --- Created attachment 150469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150469=edit Bug 33445: (follow-up) Allow all search fields to be passed through and returned when trying another search It seems the form didn't populate all fields form data passed in. This patch corrects that -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #16 from David Nind --- (In reply to Phil Ringnalda from comment #15) > Comment on attachment 150468 [details] [review] > Bug 33445: (follow-up) Allow all search fields to be passed through and > returned when trying another search > > >-[% USE raw %] > >+nt[% USE raw %] > > Haven't looked at whether that nt belonged somewhere else, but it doesn't > look right there. Was just retesting - the nt appears at the top left of the Z3950 search window. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #15 from Phil Ringnalda --- Comment on attachment 150468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150468 Bug 33445: (follow-up) Allow all search fields to be passed through and returned when trying another search >-[% USE raw %] >+nt[% USE raw %] Haven't looked at whether that nt belonged somewhere else, but it doesn't look right there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Nick Clemens changed: What|Removed |Added Attachment #150419|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #14 from Nick Clemens --- Created attachment 150468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150468=edit Bug 33445: (follow-up) Allow all search fields to be passed through and returned when trying another search It seems the form didn't populate all fields form data passed in. This patch corrects that -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #13 from Nick Clemens --- Created attachment 150467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150467=edit Bug 33445: (follow-up) Pass form values through when clicking 'Try another search' We didn't include anything except the authid id in the try again form, this patch extends to cover all the fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #12 from Nick Clemens --- Created attachment 150466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150466=edit Bug 33445: Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1 - Without the patch, edit a personal name authority record 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name 3 - Click "Replace record via Z39.50/SRU search" 4 - Note that prefilled search field contains the original value, not your name. 5 - Replace the Author (personal) field with your name in the search form 6 - choose a search target, and click Search. 7 - Note that the results of the search are for the original value, not your name 8 - From the details page of a record, click 'Edit -> Replace record via Z3950' 9 - Note form is prefilled 10 - Change value as in 5 and search 11 - Note original term was searched 12 - Apply patch, restart all 13 - Repeat searches as before 14 - Confirm that form is prefilled with record or the updated value 15 - Confirm your entered search terms are always searched Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- (In reply to David Nind from comment #10) > I was testing at the same time as Phil (using KTD): > > 1. Everything works as per the test plan. > > 2. However, after applying the patch and repeating the searches: >- for Step 6, after getting no results using my name and clicking on "Try > another search", the name in the field reverts to the original record name > and not my name >- for Step 10, the same as step 6 - which is probably correct (but I'm > not sure...) >- feel free to change the status to Failed QA if this is not the expected > behavour (I would probably have failed QA if there wasn't already a sign off) > > 3. I tested using MARC21 and UNIMARC instances. Hi Nick, could you please have a look at David's notes here? I believe we'd always want the new name, so that would be one last glitch to fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | Keywords||regression -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #10 from David Nind --- I was testing at the same time as Phil (using KTD): 1. Everything works as per the test plan. 2. However, after applying the patch and repeating the searches: - for Step 6, after getting no results using my name and clicking on "Try another search", the name in the field reverts to the original record name and not my name - for Step 10, the same as step 6 - which is probably correct (but I'm not sure...) - feel free to change the status to Failed QA if this is not the expected behavour (I would probably have failed QA if there wasn't already a sign off) 3. I tested using MARC21 and UNIMARC instances. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Phil Ringnalda changed: What|Removed |Added Attachment #149624|0 |1 is obsolete|| Attachment #150368|0 |1 is obsolete|| --- Comment #9 from Phil Ringnalda --- Created attachment 150419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150419=edit Bug 33445: [alternate] Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1 - Without the patch, edit a personal name authority record 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name 3 - Click "Replace record via Z39.50/SRU search" 4 - Note that prefilled search field contains the original value, not your name. 5 - Replace the Author (personal) field with your name in the search form 6 - choose a search target, and click Search. 7 - Note that the results of the search are for the original value, not your name 8 - From the details page of a record, click 'Edit -> Replace record via Z3950' 9 - Note form is prefilled 10 - Change value as in 5 and search 11 - Note original term was searched 12 - Apply patch, restart all 13 - Repeat searches as before 14 - Confirm that form is prefilled with record or the updated value 15 - Confirm your entered search terms are always searched Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Phil Ringnalda changed: What|Removed |Added Assignee|p...@chetcolibrary.org |n...@bywatersolutions.com --- Comment #8 from Phil Ringnalda --- That does still retain one behavior change, altering the meaning of the "Try another search" button on search results from the historic "Try a different search starting from scratch with an empty form" to "Try another search starting with a form prefilled from the saved record" but I can't object too much to that, since I have always avoided the another search from scratch button, preferring to use the browser's back button if I'm only a page or two forward, or just closing and reopening the popup if I'm several pages deep. According to my concept of the meaning of "stable" we should still revert back down to oldoldstable and then land this on master, but obviously my concept of stable is very different from Koha's. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Rather than revert, I think we need to ensure we handle record values when needed, and the form values when searching. I attached an alternate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Nick Clemens changed: What|Removed |Added Attachment #150367|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 150368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150368=edit Bug 33445: [alternate] Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1 - Without the patch, edit a personal name authority record 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name 3 - Click "Replace record via Z39.50/SRU search" 4 - Note that prefilled search field contains the original value, not your name. 5 - Replace the Author (personal) field with your name in the search form 6 - choose a search target, and click Search. 7 - Note that the results of the search are for the original value, not your name 8 - From the details page of a record, click 'Edit -> Replace record via Z3950' 9 - Note form is prefilled 10 - Change value as in 5 and search 11 - Note original term was searched 12 - Apply patch, restart all 13 - Repeat searches as before 14 - Confirm that form is prefilled with record or the updated value 15 - Confirm your entered search terms are always searched -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #5 from Nick Clemens --- Created attachment 150367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150367=edit Bug 33445: [alternate] Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1. Without the patch, edit a personal name authority record, replacing the value in 100 subfield a (200 subfield a for UNIMARC) with your own name. 2. Click "Replace record via Z39.50/SRU search" and note that the prefilled search field contains the original value, not your name. 3. Replace the Author (personal) field with your name again, choose a search target, and click Search. 4. Note that the results of the search are for the original value, not for your name. 5. Apply patch, repeat, noting that the search form is prefilled with your change made in the editor, and any changes you make in the search form are reflected in what the search results return. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Nick Clemens changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #4 from Katrin Fischer --- Hi Phil, if you are working on a patch, please remember to make yourself Assignee of the bug. It helps to avoid doubled up work among other things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |p...@chetcolibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. I have signed off based on what is in the test plan working. I'm not familiar enough with authorities, and how it should work, to comment on that. 2. I think the bug title/description needs fixing - see https://wiki.koha-community.org/wiki/Commit_messages#Subject_line -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What|Removed |Added Attachment #149504|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 149624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149624=edit Revert "Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail)" This reverts commit 26c26164ba78029cb99fa99662f9e0a8ce9557df. Test plan: 1. Without the patch, edit a personal name authority record, replacing the value in 100 subfield a (200 subfield a for UNIMARC) with your own name. 2. Click "Replace record via Z39.50/SRU search" and note that the prefilled search field contains the original value, not your name. 3. Replace the Author (personal) field with your name again, choose a search target, and click Search. 4. Note that the results of the search are for the original value, not for your name. 5. Apply patch, repeat, noting that the search form is prefilled with your change made in the editor, and any changes you make in the search form are reflected in what the search results return. https://bugs.koha-community.org/show_bug.cgi?id=33445 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #1 from Phil Ringnalda --- Created attachment 149504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149504=edit Revert "Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail)" This reverts commit 26c26164ba78029cb99fa99662f9e0a8ce9557df. Test plan: 1. Without the patch, edit a personal name authority record, replacing the value in 100 subfield a (200 subfield a for UNIMARC) with your own name. 2. Click "Replace record via Z39.50/SRU search" and note that the prefilled search field contains the original value, not your name. 3. Replace the Author (personal) field with your name again, choose a search target, and click Search. 4. Note that the results of the search are for the original value, not for your name. 5. Apply patch, repeat, noting that the search form is prefilled with your change made in the editor, and any changes you make in the search form are reflected in what the search results return. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Phil Ringnalda changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
