[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Lucas Gass changed: What|Removed |Added Attachment #161023|0 |1 is obsolete|| --- Comment #8 from Lucas Gass --- Created attachment 161473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161473=edit Bug 33452: Improve display of applied filters and results table This makes various improvements on the display of the results: * Filters didn't display the value that was filtered on * Filter labels were not translatable * Results table showed line/column using untranslatable codes * Results table showed library and patron category codes instead of descriptions To test: * Use the various filters in the form * Use various combinations of row/column * Verify it all works as expected and display is much improved Note: * In the filters, the code for extended patron attributs will be used as label. * In the results table only patron category codes and library codes translate to descriptions. Other values from pull downs haven't been implemented yet. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Lucas Gass changed: What|Removed |Added Attachment #161022|0 |1 is obsolete|| --- Comment #7 from Lucas Gass --- Created attachment 161472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161472=edit Bug 33452: Update patron statistics search form and result list This makes changes to terminology, spelling and capitalization. Terminology used should be the same as on the normal patron form. To test: * Go to Reports > Patrons statistics * Compare search form before and after patch. List of changes: * Gender: * Add option 'Other' * Change men and women to 'Male' and 'Female' * Sort*: * Labels changed from "Sortx" to "Sort x" * Note: to see Sort 1 you need to add an AV for bsort1 * Patron status: * Options changed to start with a capital letter * 'Lost' changed to 'Lost card' * Patron activity: * Options changed to start with a capital letter * 'no active' changed to 'Not active' * Patron attributes: * Switched code and description in label, so description is first * Do a search, compare result table before and after patch. * Added white background (page-section) to results Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Lucas Gass changed: What|Removed |Added Attachment #161021|0 |1 is obsolete|| --- Comment #6 from Lucas Gass --- Created attachment 161471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161471=edit Bug 33452: Reindent borrowers_stats.tt This patch only contains whitespace changes, including switching from tabs to 4 spaces for indenting consistently. To test: * There shoudl be no change in appearance and behavior Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 --- Comment #5 from Katrin Fischer --- Hi Brendan, thanks for testing! As this already includes a lot of different changes, I think it would make it a little easier to put any additional ones into a separate bug report that is dependent on this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Brendan Lawlor changed: What|Removed |Added CC||blaw...@clamsnet.org --- Comment #4 from Brendan Lawlor --- I tested this out and the changes to the form labels and the display of the table look good to me. It's especially nice that the filters display accurately above the results table. While I was testing and looking at the code I noticed another small improvement could be made to the results table by right aligning the elements that have numerical data. It's easily done by adding class="text-right" in a few places. Question about Bugzilla testing and submitting patches: would it be ok to add an attachment to this bug with the proposed alignment change? or should I just sign off on this bug and file a new bug for the numerical alignment and attach that change separately? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Victor Grousset/tuxayo changed: What|Removed |Added Keywords||Sandbox -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Katrin Fischer changed: What|Removed |Added Component|Patrons |Reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 --- Comment #3 from Katrin Fischer --- Created attachment 161023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161023=edit Bug 33452: Improve display of applied filters and results table This makes various improvements on the display of the results: * Filters didn't display the value that was filtered on * Filter labels were not translatable * Results table showed line/column using untranslatable codes * Results table showed library and patron category codes instead of descriptions To test: * Use the various filters in the form * Use various combinations of row/column * Verify it all works as expected and display is much improved Note: * In the filters, the code for extended patron attributs will be used as label. * In the results table only patron category codes and library codes translate to descriptions. Other values from pull downs haven't been implemented yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 --- Comment #2 from Katrin Fischer --- Created attachment 161022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161022=edit Bug 33452: Update patron statistics search form and result list This makes changes to terminology, spelling and capitalization. Terminology used should be the same as on the normal patron form. To test: * Go to Reports > Patrons statistics * Compare search form before and after patch. List of changes: * Gender: * Add option 'Other' * Change men and women to 'Male' and 'Female' * Sort*: * Labels changed from "Sortx" to "Sort x" * Note: to see Sort 1 you need to add an AV for bsort1 * Patron status: * Options changed to start with a capital letter * 'Lost' changed to 'Lost card' * Patron activity: * Options changed to start with a capital letter * 'no active' changed to 'Not active' * Patron attributes: * Switched code and description in label, so description is first * Do a search, compare result table before and after patch. * Added white background (page-section) to results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 --- Comment #1 from Katrin Fischer --- Created attachment 161021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161021=edit Bug 33452: Reindent borrowers_stats.tt This patch only contains whitespace changes, including switching from tabs to 4 spaces for indenting consistently. To test: * There shoudl be no change in appearance and behavior -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Katrin Fischer changed: What|Removed |Added Blocks||35806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35806 [Bug 35806] Patron statistics report should treat sort 1 and sort 2 the same -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33452] Update patron statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Katrin Fischer changed: What|Removed |Added Summary|Patron statistics results |Update patron statistics |is missing page-section |report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
