[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Aude Charillon changed: What|Removed |Added Status|Needs documenting |RESOLVED CC||aude.charillon@ptfs-europe. ||com Resolution|--- |FIXED --- Comment #35 from Aude Charillon --- No need for any changes to the manual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Bug 33483 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize changed: What|Removed |Added Status|Pushed to stable|Needs documenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #34 from Martin Renvoize --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.06 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Bug 33483 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Bug 33483 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #33 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #32 from Martin Renvoize --- All working as expected and code reads reasonably. I think I would have liked to have seen the KohaTable flexibility improvements on their own bug as Matt had done, but I also don't want to block this one moving through, and we're early enough in the Vue/ERM side of things that I think we're OK this way. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483
Martin Renvoize changed:
What|Removed |Added
Attachment #149569|0 |1
is obsolete||
--- Comment #31 from Martin Renvoize ---
Created attachment 149852
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149852&action=edit
Bug 33483: Prevent 400 when more than 1 agreement is linked
We were passing package_agreements.agreement and the server returned
Object { message: "Properties not allowed: agreement.", path:
"/body/package_agreements/0" }
Signed-off-by: Pedro Amorim
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize changed: What|Removed |Added Attachment #149568|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 149851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149851&action=edit Bug 33483: (follow-up) Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Pedro Amorim Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize changed: What|Removed |Added Attachment #149567|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 149850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149850&action=edit Bug 33483: Restore 'select' We are not supposed to see edit and delete buttons, but select instead, to pick an agreement. Regression introduced by commit 809f90d394fdef8142fdf8f4a6e825dc14a132d4 Bug 33066: Remove build_datatable Signed-off-by: Jonathan Druart Signed-off-by: Pedro Amorim Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize changed: What|Removed |Added Attachment #149566|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 149849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149849&action=edit Bug 33483: Make KohaTable accept customizable actions button We have hardcoded some buttons: edit, delete But we could need specific buttons. Signed-off-by: Jonathan Druart Signed-off-by: Pedro Amorim Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize changed: What|Removed |Added Attachment #149565|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 149848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149848&action=edit Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Jonathan Druart Signed-off-by: Pedro Amorim Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize changed: What|Removed |Added Attachment #149564|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 149847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149847&action=edit Bug 33483: Fix link EBSCO package with local agreements Bug 33066 broke that, we need to set 'initialized'. Test plan: Turn on EBSCO provider, search for a package and click "Add new agreement". The modal must open with the list of agreements. Signed-off-by: Pedro Amorim Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart changed: What|Removed |Added Severity|major |critical --- Comment #25 from Jonathan Druart --- We really need this ASAP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #24 from Jonathan Druart --- (In reply to Martin Renvoize from comment #21) > Hmmm.. I'd love to see some tests around this whole area... And also note that these patches are actually fixing several tests that are currently failing on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart changed: What|Removed |Added Blocks||33416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 [Bug 33416] Agreements.ts is failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart changed: What|Removed |Added Blocks||33490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 [Bug 33490] Agreements - Filter by expired results in error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Matt Blenkinsop changed: What|Removed |Added CC||matt.blenkinsop@ptfs-europe ||.com --- Comment #23 from Matt Blenkinsop --- *** Bug 33529 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #22 from Jonathan Druart --- (In reply to Martin Renvoize from comment #21) > Hmmm.. I'd love to see some tests around this whole area... See bug 33492. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #21 from Martin Renvoize --- Hmmm.. I'd love to see some tests around this whole area... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #20 from Pedro Amorim --- Tested last patch, can confirm it fixes the 400 error when adding a 2nd agreement to an EBSCO package. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483
Pedro Amorim changed:
What|Removed |Added
Attachment #149555|0 |1
is obsolete||
--- Comment #19 from Pedro Amorim ---
Created attachment 149569
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149569&action=edit
Bug 33483: Prevent 400 when more than 1 agreement is linked
We were passing package_agreements.agreement and the server returned
Object { message: "Properties not allowed: agreement.", path:
"/body/package_agreements/0" }
Signed-off-by: Pedro Amorim
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim changed: What|Removed |Added Attachment #149529|0 |1 is obsolete|| --- Comment #18 from Pedro Amorim --- Created attachment 149568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149568&action=edit Bug 33483: (follow-up) Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim changed: What|Removed |Added Attachment #149528|0 |1 is obsolete|| --- Comment #17 from Pedro Amorim --- Created attachment 149567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149567&action=edit Bug 33483: Restore 'select' We are not supposed to see edit and delete buttons, but select instead, to pick an agreement. Regression introduced by commit 809f90d394fdef8142fdf8f4a6e825dc14a132d4 Bug 33066: Remove build_datatable Signed-off-by: Jonathan Druart Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim changed: What|Removed |Added Attachment #149527|0 |1 is obsolete|| --- Comment #16 from Pedro Amorim --- Created attachment 149566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149566&action=edit Bug 33483: Make KohaTable accept customizable actions button We have hardcoded some buttons: edit, delete But we could need specific buttons. Signed-off-by: Jonathan Druart Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim changed: What|Removed |Added Attachment #149470|0 |1 is obsolete|| --- Comment #15 from Pedro Amorim --- Created attachment 149565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149565&action=edit Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Jonathan Druart Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim changed: What|Removed |Added Attachment #149455|0 |1 is obsolete|| --- Comment #14 from Pedro Amorim --- Created attachment 149564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149564&action=edit Bug 33483: Fix link EBSCO package with local agreements Bug 33066 broke that, we need to set 'initialized'. Test plan: Turn on EBSCO provider, search for a package and click "Add new agreement". The modal must open with the list of agreements. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim changed: What|Removed |Added Status|ASSIGNED|Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim changed: What|Removed |Added Blocks||33507 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33507 [Bug 33507] EBSCO packages - Dont list already related agreements when adding a new agreement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483
--- Comment #13 from Jonathan Druart ---
Created attachment 149555
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149555&action=edit
Bug 33483: Prevent 400 when more than 1 agreement is linked
We were passing package_agreements.agreement and the server returned
Object { message: "Properties not allowed: agreement.", path:
"/body/package_agreements/0" }
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #12 from Pedro Amorim --- I think there's a bug when adding more than one agreement to an EBSCO package (getting error 400 but need to double-check this), I also think we should only list agreements that are not already related to said package, i.e. when adding subsequent agreements to the same packages, the ones already related do not show up in the "to-relate" list. Working on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #11 from Jonathan Druart --- Created attachment 149529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149529&action=edit Bug 33483: (follow-up) Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #10 from Jonathan Druart --- Created attachment 149528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149528&action=edit Bug 33483: Restore 'select' We are not supposed to see edit and delete buttons, but select instead, to pick an agreement. Regression introduced by commit 809f90d394fdef8142fdf8f4a6e825dc14a132d4 Bug 33066: Remove build_datatable Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart changed: What|Removed |Added Attachment #149471|0 |1 is obsolete|| Attachment #149472|0 |1 is obsolete|| Attachment #149473|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 149527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149527&action=edit Bug 33483: Make KohaTable accept customizable actions button We have hardcoded some buttons: edit, delete But we could need specific buttons. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #8 from Jonathan Druart --- Created attachment 149473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149473&action=edit Bug 33483: (follow-up) Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #7 from Jonathan Druart --- Created attachment 149472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149472&action=edit Bug 33483: Restore 'select' We are not supposed to see edit and delete buttons, but select instead, to pick an agreement. Regression introduced by commit 809f90d394fdef8142fdf8f4a6e825dc14a132d4 Bug 33066: Remove build_datatable Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #6 from Jonathan Druart --- Created attachment 149471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149471&action=edit Bug 33483: Make KohaTable accept customizable actions button We have hardcoded some buttons: edit, delete But we could need specific buttons. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart changed: What|Removed |Added Attachment #149456|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 149470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149470&action=edit Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim changed: What|Removed |Added Attachment #149452|0 |1 is obsolete|| --- Comment #4 from Pedro Amorim --- Created attachment 149456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149456&action=edit Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim changed: What|Removed |Added Attachment #149437|0 |1 is obsolete|| --- Comment #3 from Pedro Amorim --- Created attachment 149455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149455&action=edit Bug 33483: Fix link EBSCO package with local agreements Bug 33066 broke that, we need to set 'initialized'. Test plan: Turn on EBSCO provider, search for a package and click "Add new agreement". The modal must open with the list of agreements. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim changed: What|Removed |Added Blocks||33491 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 [Bug 33491] EBSCO Packages - Add new agreement UI has some issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #2 from Pedro Amorim --- Created attachment 149452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149452&action=edit Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #1 from Jonathan Druart --- Created attachment 149437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149437&action=edit Bug 33483: Fix link EBSCO package with local agreements Bug 33066 broke that, we need to set 'initialized'. Test plan: Turn on EBSCO provider, search for a package and click "Add new agreement". The modal must open with the list of agreements. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
