[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard changed: What|Removed |Added Depends on||31378 Resolution|--- |FIXED Status|Pushed to stable|RESOLVED --- Comment #10 from Owen Leonard --- Depends on Bug 31378 - Add a generic OAuth2/OIDC client implementation, not in 22.05.x. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 [Bug 31378] Add a generic OAuth2/OIDC client implementation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Caroline Cyr La Rose changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #1 from Caroline Cyr La Rose --- I just noticed there is more than one sentence with the term "presedence". The same way, the longest match will take presedence over the shorter one, so '*teacher.university.com' will take presedence over '*.university.com' if the email is 'u...@math.teacher.university.com' Each sentence is repeated twice in the file, for a total of 8 occurrences of "presedence" to correct. I also noticed that one of the sentences has superfluous words. Exact matches have presedence over asterix ones, so if the 'library.com' domain will take presedence over '*library.com' when the email is 'someb...@library.com' "so if the" in the other sentence that is the same is simply "so". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #2 from Owen Leonard --- Created attachment 151008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151008&action=edit Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the s inside that block of help text to in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #3 from Caroline Cyr La Rose --- Thanks Owen for the correction! Does the div vs p affect the space between the lines? I noticed that when adding a new domain, the lines are all smushed together, but when editing an existing domain, the lines are spaced out, making it easier to read. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #4 from Owen Leonard --- Whoops, my patch is incomplete! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard changed: What|Removed |Added Attachment #151008|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 151010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151010&action=edit Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the s inside that block of help text to in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Caroline Cyr La Rose changed: What|Removed |Added Attachment #151010|0 |1 is obsolete|| --- Comment #6 from Caroline Cyr La Rose --- Created attachment 151017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151017&action=edit Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the s inside that block of help text to in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Marcel de Rooy changed: What|Removed |Added Attachment #151017|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 151122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151122&action=edit Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the s inside that block of help text to in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.06 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #9 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
