[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Sophie MEYNIEUX changed: What|Removed |Added CC||sophie.meyni...@biblibre.co ||m --- Comment #10 from Sophie MEYNIEUX --- what is the value of x please ? for 22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 --- Comment #11 from Sophie MEYNIEUX --- Found, thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30580 Depends on||24295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 --- Comment #1 from Nick Clemens --- Created attachment 151386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151386&action=edit Bug 33761: Unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 --- Comment #2 from Nick Clemens --- Created attachment 151387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151387&action=edit Bug 33761: Alter query to remove items with active transfers from available list Current code removes all items without an active transfer, and any with completed transfers. This patch moves the conditionals for transfers into the join, then adds a new condition to remove items with active transfers. To test: 1 - Apply unit test patch only 2 - prove -v t/db_dependent/HoldsQueue.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/HoldsQueue.t 6 - Success! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Martin Renvoize changed: What|Removed |Added Attachment #151386|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 151413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151413&action=edit Bug 33761: Unit test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Martin Renvoize changed: What|Removed |Added Attachment #151387|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 151414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151414&action=edit Bug 33761: Alter query to remove items with active transfers from available list Current code removes all items without an active transfer, and any with completed transfers. This patch moves the conditionals for transfers into the join, then adds a new condition to remove items with active transfers. To test: 1 - Apply unit test patch only 2 - prove -v t/db_dependent/HoldsQueue.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/HoldsQueue.t 6 - Success! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch --- Comment #5 from Martin Renvoize --- Thanks for the prompt fix here Nick. Tested and working.. kinda silly I missed it until now. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Martin Renvoize changed: What|Removed |Added Keywords||rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- As this is critical.. lets go straight for PQA here.. It's a clear and simple fix with solid unit tests. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com --- Comment #8 from Laura Escamilla --- Can this be backported to 22.11.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Jonathan Druart changed: What|Removed |Added Keywords|rel_23_05_candidate | CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.07 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 --- Comment #9 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
