[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 Martin Renvoize changed: What|Removed |Added Version(s)|23.11.00|23.11.00,23.05.02 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 --- Comment #6 from Martin Renvoize --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 --- Comment #7 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 Andreas Roussos changed: What|Removed |Added Assignee|oleon...@myacpl.org |a.rous...@dataly.gr Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 Andreas Roussos changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 --- Comment #1 from Andreas Roussos --- Created attachment 152337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152337&action=edit Bug 34005: Move button toggling code outside JS for loop When OpacHighlightedWords is set to "Highlight", if you search in the OPAC and the number of keywords is odd (1, 3, 5, etc.), then the "Unhighlight" / "Highlight" button will stop working after a couple of clicks. The relevant commit is 9cb89b46397 from v20.11.00, where the code responsible for toggling the "Unhighlight" / "Highlight" button was moved inside the JS for loop that cycles through each term in the array of search terms. This explains why the toggling only works when an even number of search terms is being used. This patch fixes that, by placing the button toggling code in its original position (outside the JavaScript for loop of the highlightOn() function). Test plan: 0) If required, set OpacHighlightedWords to "Highlight". 1) Search for "history" in the OPAC, and view the details page of one of the results. Click on the "Unhighlight" button a few times -- after a couple of clicks the button text will stop toggling and you won't be able to remove the keyword highlight any more. 2) Apply this patch. 3) Repeat step 1): this time you should be able to toggle the search keyword highlighting no matter how many times you click on the "Unhighlight" / "Highlight" button. 4) Repeat step 1), but this time search for "century history": you should be able to toggle search keyword highlighting in the details page on and off repeatedly without any problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 Lucas Gass changed: What|Removed |Added Attachment #152337|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 152338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152338&action=edit Bug 34005: Move button toggling code outside JS for loop When OpacHighlightedWords is set to "Highlight", if you search in the OPAC and the number of keywords is odd (1, 3, 5, etc.), then the "Unhighlight" / "Highlight" button will stop working after a couple of clicks. The relevant commit is 9cb89b46397 from v20.11.00, where the code responsible for toggling the "Unhighlight" / "Highlight" button was moved inside the JS for loop that cycles through each term in the array of search terms. This explains why the toggling only works when an even number of search terms is being used. This patch fixes that, by placing the button toggling code in its original position (outside the JavaScript for loop of the highlightOn() function). Test plan: 0) If required, set OpacHighlightedWords to "Highlight". 1) Search for "history" in the OPAC, and view the details page of one of the results. Click on the "Unhighlight" button a few times -- after a couple of clicks the button text will stop toggling and you won't be able to remove the keyword highlight any more. 2) Apply this patch. 3) Repeat step 1): this time you should be able to toggle the search keyword highlighting no matter how many times you click on the "Unhighlight" / "Highlight" button. 4) Repeat step 1), but this time search for "century history": you should be able to toggle search keyword highlighting in the details page on and off repeatedly without any problems. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 Martin Renvoize changed: What|Removed |Added Attachment #152338|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 152677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152677&action=edit Bug 34005: Move button toggling code outside JS for loop When OpacHighlightedWords is set to "Highlight", if you search in the OPAC and the number of keywords is odd (1, 3, 5, etc.), then the "Unhighlight" / "Highlight" button will stop working after a couple of clicks. The relevant commit is 9cb89b46397 from v20.11.00, where the code responsible for toggling the "Unhighlight" / "Highlight" button was moved inside the JS for loop that cycles through each term in the array of search terms. This explains why the toggling only works when an even number of search terms is being used. This patch fixes that, by placing the button toggling code in its original position (outside the JavaScript for loop of the highlightOn() function). Test plan: 0) If required, set OpacHighlightedWords to "Highlight". 1) Search for "history" in the OPAC, and view the details page of one of the results. Click on the "Unhighlight" button a few times -- after a couple of clicks the button text will stop toggling and you won't be able to remove the keyword highlight any more. 2) Apply this patch. 3) Repeat step 1): this time you should be able to toggle the search keyword highlighting no matter how many times you click on the "Unhighlight" / "Highlight" button. 4) Repeat step 1), but this time search for "century history": you should be able to toggle search keyword highlighting in the details page on and off repeatedly without any problems. Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Clear and working fix, Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
