[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Lucas Gass changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 --- Comment #8 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in|| Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 --- Comment #7 from Martin Renvoize --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Martin Renvoize changed: What|Removed |Added Version(s)|23.11.00|23.11.00,23.05.02 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 --- Comment #5 from Pedro Amorim --- (In reply to Katrin Fischer from comment #4) > I'll treat this as a QA follow-up for bug 34092. Thanks Katrin, that makes sense, it's exactly what this is! And thanks for spotting this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer --- I'll treat this as a QA follow-up for bug 34092. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Katrin Fischer changed: What|Removed |Added Attachment #153441|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 153448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153448=edit Bug 34256: Fix regression from 34092 It appears search_fields variable got lost somewhere in my own rebases. search_fields variable was not being considered as it should, in the function. I think this patch fixes it. This showed in the borrowernumer no longer being searchable: * Use search filters in patron search * Set 'Search field' to borrowernumber * Search for 19 (Henry) or 41 (koha) in sample data * No results :( * Apply patch * Search leads to the patron record again Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Martin Renvoize changed: What|Removed |Added Blocks||29822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 --- Comment #2 from Pedro Amorim --- Created attachment 153441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153441=edit 34256: Fix regression from 34092 It appears search_fields variable got lost somewhere in my own rebases. search_fields variable was not being considered as it should, in the function. I think this patch fixes it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Pedro Amorim changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Katrin Fischer changed: What|Removed |Added Depends on||34092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256
Andreas Roussos changed:
What|Removed |Added
CC||a.rous...@dataly.gr
See Also||https://bugs.koha-community
||.org/bugzilla3/show_bug.cgi
||?id=34067,
||https://bugs.koha-community
||.org/bugzilla3/show_bug.cgi
||?id=34092
--- Comment #1 from Andreas Roussos ---
(In reply to Katrin Fischer from comment #0)
> The sample data has patrons with borrowernumbers 51 and 19. Neither is found
> when you select borrowernumber and starts with in the search filters.
I can reproduce this on the current master, too.
> I am sure this was a regression on one point, because I have used this
> feature before.
The relevant commit is a9f8db17fe from Bug 34092 ("Move search-patron.inc
logic into buildPatronSearchQuery"). See also Bug 34067.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
