[Koha-bugs] [Bug 34340] Point of sale email template is showing 0.00 in the tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Bug 34340 depends on bug 34332, which changed state. Bug 34332 Summary: Syntax error in point of sale email template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34332 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of sale email template is showing 0.00 in the tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 --- Comment #9 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of sale email template is showing 0.00 in the tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in|| Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of sale email template is showing 0.00 in the tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|23.11.00|23.11.00,23.05.04 released in|| Status|Pushed to master|Pushed to stable --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of sale email template is showing 0.00 in the tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of sale email template is showing 0.00 in the tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of sale email template is showing 0.00 in the tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Katrin Fischer changed: What|Removed |Added Attachment #154344|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 154765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154765=edit Bug 34340: Changed "Tendered" to the correct input id which is "Collected" Must also apply bug 34332 - fixed a syntax error for the pos email template To test: 1. Configure your Koha to enable the point of sale system (i.e. enable syspref, set up a register, set up an item to sell). 2. Complete a transaction in the POS system. 3. Click on the “Email receipt” button next to the “Print receipt” option and enter an email address and confirm that the email is sent. 4. Check the “Tendered” field. It is showing up as 0.00 and not reflecting the actual amount that was tendered. 5. Apply patch 6. Repeat steps 2 & 3 7. The emailed receipt is now showing the correct tendered amount. 8. Sign off! Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of sale email template is showing 0.00 in the tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of sale email template is showing 0.00 in the tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | Summary|Point of Sale email |Point of sale email |template is showing 0.00 in |template is showing 0.00 in |the Tendered field |the tendered field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 --- Comment #5 from David Nind --- Testing notes (using KTD): 1. Needed to set up KTD so that email could be sent.[1] 2. For the updated notice to appear, I needed to do a reset_all then setup POS again. I'm not sure how this will affect upgrades, or if there is a way for updated notices to be applied - does this require a database update as well? 3. In additional, while this does fix the problem, all the other fields in the email notice are empty.[2] This was the case before the patch was applied. Does this need a separate bug to fix this? I have also included the notice as it is for me after the patch in KTD.[3] [1] To test sending emails using a Google account, edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where = your Google email address; = your APP password, not your Google account password): smtp.gmail.com 587 5 STARTTLS GOOGLEACCOUNTUSER GOOGLEAPPPASSWORD 1 [2] Email notice with Tendered amount fixed: Transaction ID: Operator ID: Payment type: Payment receipt Description of charges Amount Total: 0.00 Tendered:30.00 Change given:0.00 [3] Current email notice (HTRML) for Point of sale receipt: [% USE KohaDates %] [% USE Branches %] [% USE Price %] [% PROCESS "accounts.inc" %] [% IF ( LibraryName ) %] [% LibraryName | html %] [% END %] [% IF credit.library %] [% payment.library.branchname | html %] [% END %] [% payment.date | $KohaDates %] Transaction ID: [% payment.accountlines_id %] Operator ID: [% payment.manager_id %] Payment type: [% payment.payment_type %] Payment receipt Description of charges Amount [% FOREACH offset IN payment.credit_offsets %] [% PROCESS account_type_description account=debit %] [% debit.amount * -1 | $Price %] [% END %] Total: [% payment.amount * -1 | $Price %] Tendered: [% collected | $Price %] Change given: [% change | $Price %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Not sure what happened, but when I did the git bz attach -e 34340 HEAD, the text of the bug including the test plan was not included. I amended the commit message and reattached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 David Nind changed: What|Removed |Added Attachment #154343|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 154344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154344=edit Bug 34340: Changed "Tendered" to the correct input id which is "Collected" Must also apply bug 34332 - fixed a syntax error for the pos email template To test: 1. Configure your Koha to enable the point of sale system (i.e. enable syspref, set up a register, set up an item to sell). 2. Complete a transaction in the POS system. 3. Click on the “Email receipt” button next to the “Print receipt” option and enter an email address and confirm that the email is sent. 4. Check the “Tendered” field. It is showing up as 0.00 and not reflecting the actual amount that was tendered. 5. Apply patch 6. Repeat steps 2 & 3 7. The emailed receipt is now showing the correct tendered amount. 8. Sign off! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 David Nind changed: What|Removed |Added Attachment #153790|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 154343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154343=edit Bug 34340: Changed "Tendered" to the correct input id which is "Collected" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Laura Escamilla changed: What|Removed |Added Depends on||34332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34332 [Bug 34332] Syntax error in point of sale email template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 --- Comment #1 from Laura Escamilla --- Created attachment 153790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153790=edit Bug 34340: Changed "Tendered" to the correct input id which is "Collected" Must also apply bug 34332 - fixed a syntax error for the pos email template To test: 1. Configure your Koha to enable the point of sale system (i.e. enable syspref, set up a register, set up an item to sell). 2. Complete a transaction in the POS system. 3. Click on the “Email receipt” button next to the “Print receipt” option and enter an email address and confirm that the email is sent. 4. Check the “Tendered” field. It is showing up as 0.00 and not reflecting the actual amount that was tendered. 5. Apply patch 6. Repeat steps 2 & 3 7. The emailed receipt is now showing the correct tendered amount. 8. Sign off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Laura Escamilla changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Laura Escamilla changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/