[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 --- Comment #11 from Jacob O'Mara --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Jacob O'Mara changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.11 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.11.00|23.11.00,23.05.05 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #10 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Katrin Fischer changed: What|Removed |Added Attachment #156285|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 156386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156386=edit Bug 34489: Fix timezone problem in Patrons.t See also bug 34930. Using same approach. Test plan: export TZ='Europe/Amsterdam' prove t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from Marcel de Rooy --- Trivial: Self SO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 --- Comment #6 from Marcel de Rooy --- Created attachment 156285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156285=edit Bug 34489: Fix timezone problem in Patrons.t See also bug 34930. Using same approach. Test plan: export TZ='Europe/Amsterdam' prove t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Marcel de Rooy changed: What|Removed |Added Attachment #154318|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Comment on attachment 154318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154318 Bug 34489: Testing Will be following same approach as on bug 34930 now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489
--- Comment #4 from Marcel de Rooy ---
This might be in the same category:
t/db_dependent/api/v1/patrons.t
not ok 6 - Filtering by date-time works
# Failed test 'Filtering by date-time works'
# at t/db_dependent/api/v1/patrons.t line 123.
# got: undef
# expected: '2253'
my $last_seen_rfc3339 = $last_seen . "z";
$t->get_ok("//$userid:$password@/api/v1/patrons?last_seen=" .
$last_seen_rfc3339 . "=" . $patron->cardnumber)
>status_is(200)
>json_is( '/0/patron_id' => $patron->id, 'Filtering by date-time works' );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Marcel de Rooy changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 --- Comment #3 from Marcel de Rooy --- dt_from_string is rather weird with time zones. Why not pass now in server_tz ? See testing patch too. Some tests in DateUtils.t are just wrong. Try testing in Pacific/Fiji. Having a difference of 13 hours, will make one of the rfc3339 tests fail. The test is wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 --- Comment #2 from Marcel de Rooy --- Created attachment 154318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154318=edit Bug 34489: Testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 --- Comment #1 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #0) > Adding a tzset to UTC in the test as a workaround. Bug 25621 suggests > patching DateUtils.pm as a definitive solution? No tzset is not satisfactory. What about removing floating from get_age ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25621 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Marcel de Rooy changed: What|Removed |Added Summary|Koha/Patrons.t: Run get_age |Koha/Patrons.t: Subtests |and is_valid_age in UTC |get_age and is_valid_age do ||not pass in another ||timezone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
