[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Bug 34592 depends on bug 28726, which changed state. Bug 28726 Summary: Add sort1 and sort2 to patron card creator patron search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 --- Comment #9 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Fridolin Somers changed: What|Removed |Added Version(s)|23.11.00|23.11.00,23.05.04 released in|| Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #7 from Jonathan Druart --- Any changes to patron search should add selenium tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Katrin Fischer changed: What|Removed |Added Attachment #154802|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 154806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154806=edit Bug 34592: Patron Search filter fields needs to be at least an empty array If buildPatronSearchQuery() doesn't return an empty array when it exits early, then the code that adds the sort fields to the filters will fail. Test plan: - If there is not all ready a patron with a sort1 or sort2 value from the bSort1 or bSort2 authorized values, add an authorized value if necessary. - Add a patron if necessary, and set the patrons sort field to the added value. - In Tools -> Patron card creator start a new card batch. - Click on Add Patron(s) to open the patron search window. - Pick the value in either the sort1 or sort2 drop down. - Submit the page. The page will reload and there won't be results. - Apply the patch, close the patron search window, clear the browser cache, reload the "New patron card batch" page, and open the patron search window again. - Repeat the search. There will be results. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Owen Leonard changed: What|Removed |Added Attachment #154742|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 154802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154802=edit Bug 34592: Patron Search filter fields needs to be at least an empty array If buildPatronSearchQuery() doesn't return an empty array when it exits early, then the code that adds the sort fields to the filters will fail. Test plan: - If there is not all ready a patron with a sort1 or sort2 value from the bSort1 or bSort2 authorized values, add an authorized value if necessary. - Add a patron if necessary, and set the patrons sort field to the added value. - In Tools -> Patron card creator start a new card batch. - Click on Add Patron(s) to open the patron search window. - Pick the value in either the sort1 or sort2 drop down. - Submit the page. The page will reload and there won't be results. - Apply the patch, close the patron search window, clear the browser cache, reload the "New patron card batch" page, and open the patron search window again. - Repeat the search. There will be results. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Michael Hafen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Michael Hafen changed: What|Removed |Added Attachment #154703|0 |1 is obsolete|| --- Comment #3 from Michael Hafen --- Created attachment 154742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154742=edit ug 34592: Patron Search filter fields needs to be at least an empty array (Sorry. I don't know how that happened.) If buildPatronSearchQuery() doesn't return an empty array when it exits early, then the code that adds the sort fields to the filters will fail. Test plan: If there is not all ready a patron with a sort1 or sort2 value from the bSort1 or bSort2 authorized values, add an authorized value if necessary, add a patron if necessary, and set the patrons sort field to the added value. In Tools -> Patron card creator start a new card batch. Click on Add Patron(s) to open the patron search window. pick the value in either the sort1 or sort2 drop down. Submit the page. The page will reload and there won't be results. Apply the patch, close the patron search window, clear the browser cache, reload the "New patron card batch" page, and open the patron search window again. Repeat the search. There will be results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- The attachment has only a test plan, no patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The patron search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Katrin Fischer changed: What|Removed |Added Summary|The Patron Search window, |The patron search window, |given just a sort field |given just a sort field |value, doesn't work |value, doesn't work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34592] The Patron Search window, given just a sort field value, doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34592 Michael Hafen changed: What|Removed |Added Assignee|cnighswon...@foundations.ed |michael.ha...@washk12.org |u | Status|NEW |Needs Signoff --- Comment #1 from Michael Hafen --- Created attachment 154703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154703=edit Bug 34592: Patron Search filter fields needs to be at least an empty array -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
