[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

--- Comment #16 from Katrin Fischer  ---
(In reply to Kyle M Hall from comment #11)
> > Most of these are cosmetic and should be quick to follow-up:
> > 
> > 1) Needs a follow-up to fix documentation.
> > 
> > +=head3 populate_empty_callnumbers
> > +
> > +Controller function that handles deleting a biblio object
> 
> Fixed!

Yes, but introducing more wrong terminology (see 2). 


> > 2) Spelling
> > 
> > In the item form and the holding table we are using 'call number', but the
> > patch uses 'callnumber'. I believe we should follow the GUI. 
> > 
> > See also: https://wiki.koha-community.org/wiki/Terminology
> 
> Fixed!

Not quite, see my follow-up.


> > 3) I feel we should include the call number that would be used in the
> > confirmation question. 
> > 
> > if ( confirm(__('Are you sure you want to populate callnumbers for all items
> > without a callnumber on this record?')) ) 
> 
> Wow, that was more work than I expected but I was able to make that happen!

Sorry, but I believe it's worth it! And it works nicely too.

> > 4) Please no line breaks in translatable strings!
> > 
> > This is a known issue with Pootle, not sure about Weblate, but translators
> > often might not know what it is and accidentally remove it.
> > 
> > msg += __('\nReload the page?');
> > let msg = __('Item populated with the callnumber "%s"\nReload the
> > page?').format(callnumber);

You did:
+msg += " " + __('Reload the page?');

You could just have done this to keep your line break:

+msg += "\n" + __('Reload the page?');

We can do line breaks, they just should not be with the translated string :)

> I think I've fixed this based on your description. We should add a coding
> guideline for this.

I thought we had one, but it might be lost in time. I fixed a ton of those
strings back in the day. This one goes in the right direction, even if it uses
HTML formatting: JS3: Avoid strings which mix text and markup


> > 4) Button in the holdings table
> > 
> > The button for every single item in the holdings table takes up quite a bit
> > of space. I wonder if we could find a way to make this work a little better.
> > Maybe a split button with Edit as the main action?
> Done!

Yes, but it no longer works :(
POST
http://localhost:8081/api/v1/biblios/undefined/items/undefined/populate_empty_callnumbers

The undefined don't look good.

> > 
> > 5) Button in the detail page's toolbar (not blocker)
> > 
> > Why not move this into the edit menu?
> 
> Done!

Yes, but it no longer works :(
POST
http://localhost:8081/api/v1/biblios/undefined/items/populate_empty_callnumbers


> > 
> > 4) Maintenance script? (not blocker)
> > 
> > I wonder about the use case to require such a one by one change. If you have
> > itemcallnumber set, this would only apply to items that have been created
> > before, that have been imported or otherwise added from outside of Koha. 
> > 
> > Are there plans for a maintenance script to do this in batch?
> 
> There are no plans for a maintenance script but I'd be happy to make one on
> a followup bug report if you can provide the parameters you'd like to see!

I don't need one, I was just wondering if there was more planned around this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

--- Comment #15 from Katrin Fischer  ---
Created attachment 158572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158572=edit
Bug 34784: (QA follow-up) Terminology: callnumber, biblio, syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #158556|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 158571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158571=edit
Bug 34784: (QA follow-up)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #158555|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 158570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158570=edit
Bug 34784: Implement feature in staff interface

Some libraries would like to auto-populate item callnumbers for items on a
record based on the system preference "itemcallnumber". Only items with empty
callnumbers would affected. This would add a button "Populate empty item
callnumbers" on catalogue/detail.pl, as well as a "Populate callnumber" button
for each line in the holdings table to set the callnumber for that specific
item.

Test Plan:
1) Set the systempreference to something ( "245a" will make the
   callnumber the record title for testing purposes )
2) Apply this patch set
3) Restart all the things!
4) Browse to a record details page, note no new buttons
5) Enable the new syspref EnablePopulateCallnumbers
5) Reload the record details, note the new "Populate callnumbers" button
   in the cataloging toolbar
7) Add one or more items with no callnumber to the record
8) Test the "Populate callnumbers" button
9) Add another item with no callnumber to the record
10) Test the "Populate callnumber" button for that single item

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #158554|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 158569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158569=edit
Bug 34784: Add REST API endpoints for updating single item or all applicable
items on a bib

Test Plan:
1) Apply this patch
2) prove t/db_dependent/api/v1/biblios.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

--- Comment #11 from Kyle M Hall  ---
> Most of these are cosmetic and should be quick to follow-up:
> 
> 1) Needs a follow-up to fix documentation.
> 
> +=head3 populate_empty_callnumbers
> +
> +Controller function that handles deleting a biblio object

Fixed!

> 2) Spelling
> 
> In the item form and the holding table we are using 'call number', but the
> patch uses 'callnumber'. I believe we should follow the GUI. 
> 
> See also: https://wiki.koha-community.org/wiki/Terminology

Fixed!

> 
> 3) I feel we should include the call number that would be used in the
> confirmation question. 
> 
> if ( confirm(__('Are you sure you want to populate callnumbers for all items
> without a callnumber on this record?')) ) 

Wow, that was more work than I expected but I was able to make that happen!

> 
> 4) Please no line breaks in translatable strings!
> 
> This is a known issue with Pootle, not sure about Weblate, but translators
> often might not know what it is and accidentally remove it.
> 
> msg += __('\nReload the page?');
> let msg = __('Item populated with the callnumber "%s"\nReload the
> page?').format(callnumber);

I think I've fixed this based on your description. We should add a coding
guideline for this.

> 
> 4) Button in the holdings table
> 
> The button for every single item in the holdings table takes up quite a bit
> of space. I wonder if we could find a way to make this work a little better.
> Maybe a split button with Edit as the main action?
Done!

> 
> 5) Button in the detail page's toolbar (not blocker)
> 
> Why not move this into the edit menu?

Done!

> 
> 
> 4) Maintenance script? (not blocker)
> 
> I wonder about the use case to require such a one by one change. If you have
> itemcallnumber set, this would only apply to items that have been created
> before, that have been imported or otherwise added from outside of Koha. 
> 
> Are there plans for a maintenance script to do this in batch?

There are no plans for a maintenance script but I'd be happy to make one on a
followup bug report if you can provide the parameters you'd like to see!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

--- Comment #10 from Kyle M Hall  ---
Created attachment 158556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158556=edit
Bug 34784: (QA follow-up)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

--- Comment #9 from Kyle M Hall  ---
Created attachment 158555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158555=edit
Bug 34784: Implement feature in staff interface

Some libraries would like to auto-populate item callnumbers for items on a
record based on the system preference "itemcallnumber". Only items with empty
callnumbers would affected. This would add a button "Populate empty item
callnumbers" on catalogue/detail.pl, as well as a "Populate callnumber" button
for each line in the holdings table to set the callnumber for that specific
item.

Test Plan:
1) Set the systempreference to something ( "245a" will make the
   callnumber the record title for testing purposes )
2) Apply this patch set
3) Restart all the things!
4) Browse to a record details page, note no new buttons
5) Enable the new syspref EnablePopulateCallnumbers
5) Reload the record details, note the new "Populate callnumbers" button
   in the cataloging toolbar
7) Add one or more items with no callnumber to the record
8) Test the "Populate callnumbers" button
9) Add another item with no callnumber to the record
10) Test the "Populate callnumber" button for that single item

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #156140|0   |1
is obsolete||
 Attachment #156141|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 158554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158554=edit
Bug 34784: Add REST API endpoints for updating single item or all applicable
items on a bib

Test Plan:
1) Apply this patch
2) prove t/db_dependent/api/v1/biblios.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #7 from Katrin Fischer  ---
I'd like for someone who knows their way around the REST API a little better to
have a second look here. 

Most of these are cosmetic and should be quick to follow-up:

1) Needs a follow-up to fix documentation.

+=head3 populate_empty_callnumbers
+
+Controller function that handles deleting a biblio object

2) Spelling

In the item form and the holding table we are using 'call number', but the
patch uses 'callnumber'. I believe we should follow the GUI. 

See also: https://wiki.koha-community.org/wiki/Terminology

3) I feel we should include the call number that would be used in the
confirmation question. 

if ( confirm(__('Are you sure you want to populate callnumbers for all items
without a callnumber on this record?')) ) 

4) Please no line breaks in translatable strings!

This is a known issue with Pootle, not sure about Weblate, but translators
often might not know what it is and accidentally remove it.

msg += __('\nReload the page?');
let msg = __('Item populated with the callnumber "%s"\nReload the
page?').format(callnumber);

4) Button in the holdings table

The button for every single item in the holdings table takes up quite a bit of
space. I wonder if we could find a way to make this work a little better. Maybe
a split button with Edit as the main action?

5) Button in the detail page's toolbar (not blocker)

Why not move this into the edit menu?


4) Maintenance script? (not blocker)

I wonder about the use case to require such a one by one change. If you have
itemcallnumber set, this would only apply to items that have been created
before, that have been imported or otherwise added from outside of Koha. 

Are there plans for a maintenance script to do this in batch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

David Nind  changed:

   What|Removed |Added

 Attachment #155627|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 156141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156141=edit
Bug 34784: Implement feature in staff interface

Some libraries would like to auto-populate item callnumbers for items on a
record based on the system preference "itemcallnumber". Only items with empty
callnumbers would affected. This would add a button "Populate empty item
callnumbers" on catalogue/detail.pl, as well as a "Populate callnumber" button
for each line in the holdings table to set the callnumber for that specific
item.

Test Plan:
1) Set the systempreference to something ( "245a" will make the
   callnumber the record title for testing purposes )
2) Apply this patch set
3) Restart all the things!
4) Browse to a record details page, note no new buttons
5) Enable the new syspref EnablePopulateCallnumbers
5) Reload the record details, note the new "Populate callnumbers" button
   in the cataloging toolbar
7) Add one or more items with no callnumber to the record
8) Test the "Populate callnumbers" button
9) Add another item with no callnumber to the record
10) Test the "Populate callnumber" button for that single item

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

David Nind  changed:

   What|Removed |Added

 Attachment #155626|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 156140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156140=edit
Bug 34784: Add REST API endpoints for updating single item or all applicable
items on a bib

Test Plan:
1) Apply this patch
2) prove t/db_dependent/api/v1/biblios.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

--- Comment #4 from Kyle M Hall  ---
Created attachment 155627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155627=edit
Bug 34784: Implement feature in staff interface

Some libraries would like to auto-populate item callnumbers for items on a
record based on the system preference "itemcallnumber". Only items with empty
callnumbers would affected. This would add a button "Populate empty item
callnumbers" on catalogue/detail.pl, as well as a "Populate callnumber" button
for each line in the holdings table to set the callnumber for that specific
item.

Test Plan:
1) Set the systempreference to something ( "245a" will make the
   callnumber the record title for testing purposes )
2) Apply this patch set
3) Restart all the things!
4) Browse to a record details page, note no new buttons
5) Enable the new syspref EnablePopulateCallnumbers
5) Reload the record details, note the new "Populate callnumbers" button
   in the cataloging toolbar
7) Add one or more items with no callnumber to the record
8) Test the "Populate callnumbers" button
9) Add another item with no callnumber to the record
10) Test the "Populate callnumber" button for that single item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #155623|0   |1
is obsolete||
 Attachment #155624|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 155626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155626=edit
Bug 34784: Add REST API endpoints for updating single item or all applicable
items on a bib

Test Plan:
1) Apply this patch
2) prove t/db_dependent/api/v1/biblios.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

--- Comment #2 from Kyle M Hall  ---
Created attachment 155624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155624=edit
Bug 34784: Implement feature in staff interface

Some libraries would like to auto-populate item callnumbers for items on a
record based on the system preference "itemcallnumber". Only items with empty
callnumbers would affected. This would add a button "Populate empty item
callnumbers" on catalogue/detail.pl, as well as a "Populate callnumber" button
for each line in the holdings table to set the callnumber for that specific
item.

Test Plan:
1) Set the systempreference to something ( "245a" will make the
   callnumber the record title for testing purposes )
2) Apply this patch set
3) Restart all the things!
4) Browse to a record details page, note no new buttons
5) Enable the new syspref EnablePopulateCallnumbers
5) Reload the record details, note the new "Populate callnumbers" button
   in the cataloging toolbar
7) Add one or more items with no callnumber to the record
8) Test the "Populate callnumbers" button
9) Add another item with no callnumber to the record
10) Test the "Populate callnumber" button for that single item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

--- Comment #1 from Kyle M Hall  ---
Created attachment 155623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155623=edit
Bug 34784: Add REST API endpoints for updating single item or all applicable
items on a bib

Test Plan:
1) Apply this patch
2) prove t/db_dependent/api/v1/biblios.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/