[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Lucas Gass changed: What|Removed |Added Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in|| CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #12 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|24.05.00|24.05.00,23.11.06 released in|| Status|Pushed to main |Pushed to stable --- Comment #11 from Fridolin Somers --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 --- Comment #10 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 --- Comment #9 from Nick Clemens --- Created attachment 164223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164223=edit Bug 35129: Return 400 if _per_page=0 passed This patch adds a safe guard for when consumers pass _per_page=0 to endpoints. This condition is checked for on a centralized place and avoid reaching the controller in such scenarios that would provoke a division by zero exception. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/pagination.t => FAIL: We expect a 400, but get a 500 instead 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! No more explosions for this! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Laura Escamilla Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Nick Clemens changed: What|Removed |Added Attachment #163637|0 |1 is obsolete|| Attachment #163638|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 164222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164222=edit Bug 35129: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Laura Escamilla Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Laura Escamilla changed: What|Removed |Added Attachment #163343|0 |1 is obsolete|| --- Comment #7 from Laura Escamilla --- Created attachment 163638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163638=edit Bug 35129: Return 400 if _per_page=0 passed This patch adds a safe guard for when consumers pass _per_page=0 to endpoints. This condition is checked for on a centralized place and avoid reaching the controller in such scenarios that would provoke a division by zero exception. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/pagination.t => FAIL: We expect a 400, but get a 500 instead 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! No more explosions for this! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Laura Escamilla changed: What|Removed |Added Attachment #163342|0 |1 is obsolete|| --- Comment #6 from Laura Escamilla --- Created attachment 163637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163637=edit Bug 35129: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Laura Escamilla changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 163343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163343=edit Bug 35129: Return 400 if _per_page=0 passed This patch adds a safe guard for when consumers pass _per_page=0 to endpoints. This condition is checked for on a centralized place and avoid reaching the controller in such scenarios that would provoke a division by zero exception. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/pagination.t => FAIL: We expect a 400, but get a 500 instead 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! No more explosions for this! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 163342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163342=edit Bug 35129: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 --- Comment #3 from Tomás Cohen Arazi --- Nice catch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 --- Comment #2 from Marcel de Rooy --- Sorry no quick simple solution found yet. Take a try! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 --- Comment #1 from Marcel de Rooy --- To prohibit _per_page=0 we could use OpenAPI 3.0 with not: const: 0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
