[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Caroline Cyr La Rose changed: What|Removed |Added Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/979 Status|Needs documenting |RESOLVED Documentation||Caroline Cyr La Rose contact|| CC||caroline.cyr-la-rose@inlibr ||o.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Caroline Cyr La Rose changed: What|Removed |Added Blocks||38129 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38129 [Bug 38129] Add note regarding permissions in suggestion manager search pop-up modal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Caroline Cyr La Rose changed: What|Removed |Added Blocks||38128 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 [Bug 38128] Agreement/License user selection not limited to users with erm permissions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Caroline Cyr La Rose changed: What|Removed |Added Blocks||38127 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 [Bug 38127] Missing column headings in 'Add user' pop-up modal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What|Removed |Added Blocks||38112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38112 [Bug 38112] Description of patrons search no longer displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added CC|martin.renvoize@ptfs-europe | |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Katrin Fischer changed: What|Removed |Added Text to go in the||The patron searches that release notes||formerly used a pop-up ||windows have been moved ||into a modal. Examples: ||patron search for routing ||lists, manager search for ||suggestions, guarantor ||search. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Pedro Amorim changed: What|Removed |Added Blocks||36706 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36706 [Bug 36706] 'Add guarantor' - Patron preview 'close window' does not work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Needs documenting CC||fridolin.som...@biblibre.co ||m --- Comment #165 from Fridolin Somers --- Enhancement not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Caroline Cyr La Rose changed: What|Removed |Added Blocks||36251 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 [Bug 36251] Patron search by letter broken in holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #164 from Jonathan Druart --- Last 2 patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #163 from Jonathan Druart --- Created attachment 162714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162714&action=edit Bug 35329: Fix selenium tests if no fund exist -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #162 from Jonathan Druart --- Created attachment 162713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162713&action=edit Bug 35329: Fix autocomplete when placing a hold There was a JS error Uncaught TypeError: node.autocomplete(...).data(...) is undefined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #161 from Jonathan Druart --- Same tests are still failing with those 2 patches, rescheduling another run to see if it's a random failure (I don't recreate locally). Also noted the following JS error in the log, which is not expected at all being superlibrarian: selenium_1 | JavaScript error: http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha//members/members-home.pl, line 2756: TypeError: libraries_map[data] is undefined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #160 from Jonathan Druart --- Last 2 patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #159 from Jonathan Druart --- Created attachment 162671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162671&action=edit Bug 35329: Fix conflict with 33457 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #158 from Jonathan Druart --- Created attachment 162670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162670&action=edit Bug 35329: (follow-up) Add styling to info and error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| --- Comment #157 from Jonathan Druart --- Pushed to master for 24.05.00. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Owen Leonard changed: What|Removed |Added Blocks||34608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 [Bug 34608] Add sort1 and sort2 to patron search results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #156 from Jonathan Druart --- Patches rebased and adjusted on top of bug 34478 (and friends). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #155 from Jonathan Druart --- Created attachment 162457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162457&action=edit Bug 35329: Handle duplicate without 500 This is not perfect but way better than before! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #154 from Jonathan Druart --- Created attachment 162456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162456&action=edit Bug 35329: Adjustment for 34478 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #153 from Jonathan Druart --- Created attachment 162455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162455&action=edit Bug 35329: (QA follow-up) Fix for bug 35865 This restores the missing hint that's restored by bug 35865 ahead of this patchset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #152 from Jonathan Druart --- Created attachment 162454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162454&action=edit Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #151 from Jonathan Druart --- Created attachment 162453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162453&action=edit Bug 35329: Fix filter vars scope Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #150 from Jonathan Druart --- Created attachment 162452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162452&action=edit Bug 35329: Add POD + tidy Selenium.pm Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #149 from Jonathan Druart --- Created attachment 162451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162451&action=edit Bug 35329: Add cypress tests Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #148 from Jonathan Druart --- Created attachment 162450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162450&action=edit Bug 35329: Add selenium tests Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329
--- Comment #147 from Jonathan Druart ---
Created attachment 162449
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162449&action=edit
Bug 35329: (follow-up) Label changes for improved accessibility
This patch alters the patron search form so that s wrap the
fields, allowing the label to be clickable without having to
associate it with a unique id. CSS has been modified to accommodate this
change.
The patch also adds missing Bootstrap classes to the "Clear" button, and
swaps out the "hint" class for the "note" class on the permissions
information ("Only staff with superlibrarian or acquisitions
permissions...").
After this patch, form field labels in the patron search modal should be
clickable to give focus to the field (except for Sort 1 and Sort 2 --
label don't work that way with Select2).
Signed-off-by: Owen Leonard
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #146 from Jonathan Druart --- Created attachment 162448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162448&action=edit Bug 35329: Prevent XSS Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #145 from Jonathan Druart --- Created attachment 162447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162447&action=edit Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #144 from Jonathan Druart --- Created attachment 162446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162446&action=edit Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #143 from Jonathan Druart --- Created attachment 162445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162445&action=edit Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #142 from Jonathan Druart --- Created attachment 162444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162444&action=edit Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #141 from Jonathan Druart --- Created attachment 162443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162443&action=edit Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #140 from Jonathan Druart --- Created attachment 162442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162442&action=edit Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #139 from Jonathan Druart --- Created attachment 162441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162441&action=edit Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #138 from Jonathan Druart --- Created attachment 162440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162440&action=edit Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #137 from Jonathan Druart --- Created attachment 162439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162439&action=edit Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #136 from Jonathan Druart --- Created attachment 162438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162438&action=edit Bug 35329: Move patron search to modal - basket Add user to an acquisition basket Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #135 from Jonathan Druart --- Created attachment 162437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162437&action=edit Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What|Removed |Added Attachment #161398|0 |1 is obsolete|| Attachment #161399|0 |1 is obsolete|| Attachment #161400|0 |1 is obsolete|| Attachment #161401|0 |1 is obsolete|| Attachment #161402|0 |1 is obsolete|| Attachment #161403|0 |1 is obsolete|| Attachment #161404|0 |1 is obsolete|| Attachment #161405|0 |1 is obsolete|| Attachment #161406|0 |1 is obsolete|| Attachment #161407|0 |1 is obsolete|| Attachment #161408|0 |1 is obsolete|| Attachment #161409|0 |1 is obsolete|| Attachment #161410|0 |1 is obsolete|| Attachment #161411|0 |1 is obsolete|| Attachment #161412|0 |1 is obsolete|| Attachment #161413|0 |1 is obsolete|| Attachment #161414|0 |1 is obsolete|| Attachment #161415|0 |1 is obsolete|| Attachment #161416|0 |1 is obsolete|| Attachment #161417|0 |1 is obsolete|| --- Comment #134 from Jonathan Druart --- Created attachment 162436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162436&action=edit Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #133 from Martin Renvoize --- Minor rebase on top of bug 33457 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161295|0 |1 is obsolete|| --- Comment #132 from Martin Renvoize --- Created attachment 161417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161417&action=edit Bug 35329: (QA follow-up) Fix for bug 35865 This restores the missing hint that's restored by bug 35865 ahead of this patchset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161294|0 |1 is obsolete|| --- Comment #131 from Martin Renvoize --- Created attachment 161416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161416&action=edit Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161293|0 |1 is obsolete|| --- Comment #130 from Martin Renvoize --- Created attachment 161415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161415&action=edit Bug 35329: Fix filter vars scope Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161292|0 |1 is obsolete|| --- Comment #129 from Martin Renvoize --- Created attachment 161414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161414&action=edit Bug 35329: Add POD + tidy Selenium.pm Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161291|0 |1 is obsolete|| --- Comment #128 from Martin Renvoize --- Created attachment 161413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161413&action=edit Bug 35329: Add cypress tests Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161290|0 |1 is obsolete|| --- Comment #127 from Martin Renvoize --- Created attachment 161412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161412&action=edit Bug 35329: Add selenium tests Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329
Martin Renvoize changed:
What|Removed |Added
Attachment #161289|0 |1
is obsolete||
--- Comment #126 from Martin Renvoize ---
Created attachment 161411
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161411&action=edit
Bug 35329: (follow-up) Label changes for improved accessibility
This patch alters the patron search form so that s wrap the
fields, allowing the label to be clickable without having to
associate it with a unique id. CSS has been modified to accommodate this
change.
The patch also adds missing Bootstrap classes to the "Clear" button, and
swaps out the "hint" class for the "note" class on the permissions
information ("Only staff with superlibrarian or acquisitions
permissions...").
After this patch, form field labels in the patron search modal should be
clickable to give focus to the field (except for Sort 1 and Sort 2 --
label don't work that way with Select2).
Signed-off-by: Owen Leonard
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161288|0 |1 is obsolete|| --- Comment #125 from Martin Renvoize --- Created attachment 161410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161410&action=edit Bug 35329: Prevent XSS Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161287|0 |1 is obsolete|| --- Comment #124 from Martin Renvoize --- Created attachment 161409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161409&action=edit Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161286|0 |1 is obsolete|| --- Comment #123 from Martin Renvoize --- Created attachment 161408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161408&action=edit Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161285|0 |1 is obsolete|| --- Comment #122 from Martin Renvoize --- Created attachment 161407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161407&action=edit Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161284|0 |1 is obsolete|| --- Comment #121 from Martin Renvoize --- Created attachment 161406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161406&action=edit Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161283|0 |1 is obsolete|| --- Comment #120 from Martin Renvoize --- Created attachment 161405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161405&action=edit Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161282|0 |1 is obsolete|| --- Comment #119 from Martin Renvoize --- Created attachment 161404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161404&action=edit Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161281|0 |1 is obsolete|| --- Comment #118 from Martin Renvoize --- Created attachment 161403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161403&action=edit Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161280|0 |1 is obsolete|| --- Comment #117 from Martin Renvoize --- Created attachment 161402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161402&action=edit Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161279|0 |1 is obsolete|| --- Comment #116 from Martin Renvoize --- Created attachment 161401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161401&action=edit Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161278|0 |1 is obsolete|| --- Comment #115 from Martin Renvoize --- Created attachment 161400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161400&action=edit Bug 35329: Move patron search to modal - basket Add user to an acquisition basket Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161277|0 |1 is obsolete|| --- Comment #114 from Martin Renvoize --- Created attachment 161399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161399&action=edit Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161276|0 |1 is obsolete|| --- Comment #113 from Martin Renvoize --- Created attachment 161398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161398&action=edit Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Depends on||33457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33457 [Bug 33457] Improve display of fund users when the patron has no firstname -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #112 from Martin Renvoize --- Small rebase so I could move bug 35865 (a bugfix) above this in the dependencies and then make sure we don't lose the fix from there when applying this one to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #111 from Martin Renvoize --- Created attachment 161295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161295&action=edit Bug 35329: (QA follow-up) Fix for bug 35865 This restores the missing hint that's restored by bug 35865 ahead of this patchset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161275|0 |1 is obsolete|| --- Comment #110 from Martin Renvoize --- Created attachment 161294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161294&action=edit Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161274|0 |1 is obsolete|| --- Comment #109 from Martin Renvoize --- Created attachment 161293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161293&action=edit Bug 35329: Fix filter vars scope Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161199|0 |1 is obsolete|| --- Comment #108 from Martin Renvoize --- Created attachment 161292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161292&action=edit Bug 35329: Add POD + tidy Selenium.pm Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161198|0 |1 is obsolete|| --- Comment #107 from Martin Renvoize --- Created attachment 161291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161291&action=edit Bug 35329: Add cypress tests Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161197|0 |1 is obsolete|| --- Comment #106 from Martin Renvoize --- Created attachment 161290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161290&action=edit Bug 35329: Add selenium tests Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329
Martin Renvoize changed:
What|Removed |Added
Attachment #161196|0 |1
is obsolete||
--- Comment #105 from Martin Renvoize ---
Created attachment 161289
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161289&action=edit
Bug 35329: (follow-up) Label changes for improved accessibility
This patch alters the patron search form so that s wrap the
fields, allowing the label to be clickable without having to
associate it with a unique id. CSS has been modified to accommodate this
change.
The patch also adds missing Bootstrap classes to the "Clear" button, and
swaps out the "hint" class for the "note" class on the permissions
information ("Only staff with superlibrarian or acquisitions
permissions...").
After this patch, form field labels in the patron search modal should be
clickable to give focus to the field (except for Sort 1 and Sort 2 --
label don't work that way with Select2).
Signed-off-by: Owen Leonard
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161195|0 |1 is obsolete|| --- Comment #104 from Martin Renvoize --- Created attachment 161288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161288&action=edit Bug 35329: Prevent XSS Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161194|0 |1 is obsolete|| --- Comment #103 from Martin Renvoize --- Created attachment 161287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161287&action=edit Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161193|0 |1 is obsolete|| --- Comment #102 from Martin Renvoize --- Created attachment 161286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161286&action=edit Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161192|0 |1 is obsolete|| --- Comment #101 from Martin Renvoize --- Created attachment 161285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161285&action=edit Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161191|0 |1 is obsolete|| --- Comment #100 from Martin Renvoize --- Created attachment 161284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161284&action=edit Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161190|0 |1 is obsolete|| --- Comment #99 from Martin Renvoize --- Created attachment 161283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161283&action=edit Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161189|0 |1 is obsolete|| --- Comment #98 from Martin Renvoize --- Created attachment 161282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161282&action=edit Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161188|0 |1 is obsolete|| --- Comment #97 from Martin Renvoize --- Created attachment 161281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161281&action=edit Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161187|0 |1 is obsolete|| --- Comment #96 from Martin Renvoize --- Created attachment 161280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161280&action=edit Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161186|0 |1 is obsolete|| --- Comment #95 from Martin Renvoize --- Created attachment 161279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161279&action=edit Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161185|0 |1 is obsolete|| --- Comment #94 from Martin Renvoize --- Created attachment 161278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161278&action=edit Bug 35329: Move patron search to modal - basket Add user to an acquisition basket Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161184|0 |1 is obsolete|| --- Comment #93 from Martin Renvoize --- Created attachment 161277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161277&action=edit Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161183|0 |1 is obsolete|| --- Comment #92 from Martin Renvoize --- Created attachment 161276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161276&action=edit Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Depends on||35865 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35865 [Bug 35865] Missing hint about permissions when adding managers to a basket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #91 from Martin Renvoize --- OK.. with the follow-ups we've resolved all my concerns.. anything else falls into the enhancement on top category and there are bugs opened and linked for that. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161260|0 |1 is obsolete|| --- Comment #90 from Martin Renvoize --- Created attachment 161275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161275&action=edit Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Attachment #161259|0 |1 is obsolete|| --- Comment #89 from Martin Renvoize --- Created attachment 161274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161274&action=edit Bug 35329: Fix filter vars scope Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #88 from Jonathan Druart --- Oops, just noticed you have opened bugs already! Marked bug 35846 and bug 35861 as duplicate! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #87 from Jonathan Druart --- > (In reply to Martin Renvoize from comment #83) > > There's also a mismatch in the filter names.. 'baskets_managers' vs > > 'orders_managers'.. I think this does need fixing before we go PQA... I had > > a quick look and couldn't work out the logic flow here I'm afraid :( > > I don't think so. However orders_managers is never used (neither on master) > and we should investigate that. Ok, opened bug 35865. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #86 from Jonathan Druart --- (In reply to Martin Renvoize from comment #58) > Minor comment, I think the result of an action could be made more apparent.. > it's rather hidden away.. Added some styling on "Add styling to info and error", but could still be improved I think. > also, if re-opening the modal, the result of the > last operation is still visible. Yes, I didn't know if it would be considered a bug or not, and it was not trivial to implement. Opened bug 35864 for discussion. (In reply to Martin Renvoize from comment #59) > Next comment.. could we perhaps put the results next to rather than under > the filters form in the modal? > > It feels odd to have so much whitespace in the modal and have the actual > useful content almost hidden off screen.. widescreen aspect ratios are > pretty common these days? Good idea, but definitely for a separate bug. Opened bug 35862. (In reply to Martin Renvoize from comment #63) > We should have a message similar to that on the funds ownership search in > the basket manager search.. we limit that search to users with particular > permissions too. Yes, this is a bug, fixed in "Fix filter vars scope". (In reply to Martin Renvoize from comment #64) > For consistency, I feel like whenever a search can be used to add to a list > of patrons, we should expose the select boxes and add selected functionlity. > I don't think this should be specifically limited to patron card creator > batches. No behavior changes here, but yes that could be nice. Opened bug 35861. (In reply to Martin Renvoize from comment #83) > There's also a mismatch in the filter names.. 'baskets_managers' vs > 'orders_managers'.. I think this does need fixing before we go PQA... I had > a quick look and couldn't work out the logic flow here I'm afraid :( I don't think so. However orders_managers is never used (neither on master) and we should investigate that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #85 from Jonathan Druart --- Created attachment 161260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161260&action=edit Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #84 from Jonathan Druart --- Created attachment 161259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161259&action=edit Bug 35329: Fix filter vars scope -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What|Removed |Added Blocks||35864 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35864 [Bug 35864] Should we clear patron search result when the modal is reopened? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What|Removed |Added Blocks||35862 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 [Bug 35862] Display patron search result on the right of the form (modal) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart changed: What|Removed |Added Blocks||35861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35861 [Bug 35861] Allow to add several patron at once when selecting patrons (from modals) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Blocks||35847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35847 [Bug 35847] We should consistently display the select options when appropriate in the patron search modal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize changed: What|Removed |Added Blocks||35846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35846 [Bug 35846] On wide screens, we should display the patron search results next to the filters rather than beneath -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
