[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Martin Renvoize changed: What|Removed |Added CC|martin.renvoize@ptfs-europe | |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Slava Shishkin changed: What|Removed |Added CC||slavashish...@gmail.com --- Comment #18 from Slava Shishkin --- Our librarians need the ability to choose today's date. This is currently not possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #17 from Lucas Gass --- Doesn't apply cleanly to 23.05.x, if needed please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Fridolin Somers changed: What|Removed |Added Status|Pushed to main |Pushed to stable CC||fridolin.som...@biblibre.co ||m Version(s)|24.05.00|24.05.00,23.11.06 released in|| --- Comment #16 from Fridolin Somers --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Emily Lamancusa changed: What|Removed |Added Severity|enhancement |minor Depends on||30718 --- Comment #15 from Emily Lamancusa --- (In reply to Katrin Fischer from comment #13) > Should this be a bug instead of an enh? Good catch, thanks! It should also have a dependency on 30718. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 [Bug 30718] Use flatpickr's altInput option everywhere -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #14 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Katrin Fischer changed: What|Removed |Added Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #13 from Katrin Fischer --- Should this be a bug instead of an enh? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #12 from Martin Renvoize --- I've made the same fix for the OPAC now in the follow-up on bug 35977 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35977 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize --- I checked all cases of 'flatpickr-futuredate' and they're all happy with this change. We are generally passing db dates to the 'value' field if we pass anything at all and that's correct. This patch corrects the use in flatpickr futuredate cases. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Martin Renvoize changed: What|Removed |Added Attachment #163743|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 165909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165909&action=edit Bug 35559: Correctly parse previous flatpickr date The Flatpickr configuration for futuredate and futuredateinclusive is meant to allow the preexisting date, even if it is in the past, to avoid data loss. As of Bug 30718 - Use flatpickr's alt option everywhere, that incoming date is in -mm-dd format, not the configured human-readable format, and needs to be parsed accordingly. To test: 1. Place 2 holds on the same bib, both with an expiration date set 2. Set the expiration date for one of the holds to a date in the past (e.g., in Koha Testing Docker, use the commands: ktd --shell koha-mysql kohadev to access the database directly) 3. Reload the holds tab for that bib --> Note that the future expiration date will be editable, and the past expiration date will not be editable 4. In a new tab, go to Administration > Patron Categories 5. Edit one patron category to have an enrolment period date in the future 6. Edit another patron category to have an enrolment period date in the past (e.g. by accessing the database directly, as above) 7. Reload the Edit pages for each of the above categories (in new tabs) --> Note that the future enrolment period date will be retained in the date field, but the past enrolment period date will be blanked out 8. Apply this patchset 9. Refresh the holds tab from step 3 --> Note that both expiration dates are now editable 10. Refresh the 2 patron category tabs from step 7 --> Note that both enrolment dates are now retained correctly 11. Open the date picker on one of the date fields that has a past date --> Note that other past dates, besides the existing date, are prevented Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Martin Renvoize changed: What|Removed |Added Keywords||rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Martin Renvoize changed: What|Removed |Added Depends on||34634 CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 [Bug 34634] Expiration date does not display on reserve/request.pl if date is today or in the past -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Emily Lamancusa changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Emily Lamancusa changed: What|Removed |Added QA Contact|emily.lamancusa@montgomeryc |testo...@bugs.koha-communit |ountymd.gov |y.org Assignee|stalkern...@gmail.com |emily.lamancusa@montgomeryc ||ountymd.gov Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Emily Lamancusa changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Emily Lamancusa changed: What|Removed |Added Attachment #159807|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #9 from Emily Lamancusa --- Created attachment 163743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163743&action=edit Bug 35559: Correctly parse previous flatpickr date The Flatpickr configuration for futuredate and futuredateinclusive is meant to allow the preexisting date, even if it is in the past, to avoid data loss. As of Bug 30718 - Use flatpickr's alt option everywhere, that incoming date is in -mm-dd format, not the configured human-readable format, and needs to be parsed accordingly. To test: 1. Place 2 holds on the same bib, both with an expiration date set 2. Set the expiration date for one of the holds to a date in the past (e.g., in Koha Testing Docker, use the commands: ktd --shell koha-mysql kohadev to access the database directly) 3. Reload the holds tab for that bib --> Note that the future expiration date will be editable, and the past expiration date will not be editable 4. In a new tab, go to Administration > Patron Categories 5. Edit one patron category to have an enrolment period date in the future 6. Edit another patron category to have an enrolment period date in the past (e.g. by accessing the database directly, as above) 7. Reload the Edit pages for each of the above categories (in new tabs) --> Note that the future enrolment period date will be retained in the date field, but the past enrolment period date will be blanked out 8. Apply this patchset 9. Refresh the holds tab from step 3 --> Note that both expiration dates are now editable 10. Refresh the 2 patron category tabs from step 7 --> Note that both enrolment dates are now retained correctly 11. Open the date picker on one of the date fields that has a past date --> Note that other past dates, besides the existing date, are prevented -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #8 from Emily Lamancusa --- Created attachment 163742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163742&action=edit Bug 35559: Revert changes from bug 34634 This reverts commit fad3af0005c3a4234634ee477fafc85902540843 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #7 from Emily Lamancusa --- It looks like this is a regression (or the indirect result of one), and I think I've tracked down how we got here, but I'm not familiar enough with flatpickr to submit an alternate patch. Hopefully this will be helpful to someone who is: 1. We had a bug in the past, where a flatpickr with futuredate wouldn't display the previously input date (e.g. the expiration date on an expired hold) if that date was in the past. We fixed that in Bug 29241 and its follow-up, Bug 29500. 2. Bug 30718 (Use flatpickr's altInput option everywhere) caused a regression, and the date field on an expired hold (or any other futuredate field with a preexisting date in the past) would show as blank again. 3. Bug 34634 fixed the regression by removing the input field and simply displaying the date if the hold was expired. However, some library staff are accustomed to extending holds on or after the expiration date is reached, so this less than ideal for those workflows. Also, the regression caused by bug 30718 (presumably) still exists for all other futuredate inputs, besides the holds page. So it would be ideal if we can fix that underlying regression and allow editing of the dates on expired holds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Keith D. changed: What|Removed |Added CC||kdem...@sjcfl.us --- Comment #6 from Keith D. --- Our circulation staff have also requested this feature. They are used to being able to edit the expiration date on the final date listed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #5 from Emily Lamancusa --- I've gotten feedback from our staff about this as well - we also don't use the cron for waiting holds, and it is common for staff to grant last-minute extensions if a customer called and asked for one. Incidentally, I also noticed an inconsistency the other day - the expiration dates becomes un-editable on the expiration date of the hold, but holds don't appear on the Holds Over tab until the day after the expiration date. Not sure off the top of my head which way the cron goes, but those three things should be consistent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Laura O'Neil changed: What|Removed |Added CC||la...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Mike Barrette changed: What|Removed |Added CC||mbarre...@oslri.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #4 from Owen Leonard --- (In reply to Lisette Scheer from comment #3) > Many libraries that don't expire waiting holds with the cron seem to hold > through the expiration date and would like the option to change the date at > that time. Agreed. We don't use the cron and would like the option to revise the expiration date even if it has passed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #3 from Lisette Scheer --- > Furthermore, I am not sure I agree with this change. If the expiration date > is today I would not considered it "the last day of the pick-up period". I > would consider that to be the day before the expirationdate. Many libraries that don't expire waiting holds with the cron seem to hold through the expiration date and would like the option to change the date at that time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- This creates a bit of a problem on reserve/request.pl with your patched applied. 1. Have a hold that expires today and go to reserve/request.pl for that item. 2. Look at the expiration date column and notice it will be blank. 3. We use data-flatpickr-futuredate on this input and today is not a futuredate. Furthermore, I am not sure I agree with this change. If the expiration date is today I would not considered it "the last day of the pick-up period". I would consider that to be the day before the expirationdate. Also, your bug title is not not correct. Have a look at the QA tool: Processing additional checks * Commit title does not start with 'Bug X: ' - c2d44aa429 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Phil Ringnalda changed: What|Removed |Added Component|Cataloging |Hold requests CC||gmcha...@gmail.com, ||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #1 from Peter Vashchuk --- Created attachment 159807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159807&action=edit Bug 35559 - Allow the change of expiration date on the last day of expiration The result of this comparison will almost never be 0 as it requires the dates to be same down to a second: DateTime->compare( dt_from_string( $res->expirationdate ), dt_from_string() ) == -1 This patch fixes it. To reproduce: 1) Create or use existing hold that is awaiting pickup. 2) Set it's expiration date to today. (if you can't do it through koha interface, edit it in the database or wait for tomorrow to come) 3) Check that you can't change the expiration date anymore as it says "Expired: %date%" 4) Apply the patch 5) Check that you can change the expiration date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Peter Vashchuk changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
