[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||mag...@libriotech.no, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #1 from Pedro Amorim --- Created attachment 159863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159863&action=edit Bug 35581: Illbackend.pm -> ILL/Backend.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #2 from Pedro Amorim --- Created attachment 159864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159864&action=edit Bug 35581: Illbatch.pm -> ILL/Batch.pm Illbatches.pm -> ILL/Batches.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #3 from Pedro Amorim --- Created attachment 159865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159865&action=edit Bug 35581: Illbatchstatus.pm -> ILL/Batch/status.pm Illbatchstatuses.pm -> ILL/Batch/Statuses.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #4 from Pedro Amorim --- Created attachment 159866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159866&action=edit Bug 35581: Illcomment.pm -> ILL/Comment.pm Illcomments.pm -> ILL/Comments.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #5 from Pedro Amorim --- Created attachment 159867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159867&action=edit Bug 35581: Illrequestattribute.pm -> ILL/Request/Attribute.pm Illrequestattributes.pm -> ILL/Request/Attributes.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #6 from Pedro Amorim --- Created attachment 159868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159868&action=edit Bug 35581: Koha/Illrequest/Workflow.pm -> Koha/ILL/Request/Workflow.pm Koha/Illrequest/Workflow/Availability.pm -> Koha/ILL/Request/Workflow/Availability.pm Koha/Illrequest/Workflow/TypeDisclaimer.pm -> Koha/ILL/Request/Workflow/TypeDisclaimer.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #7 from Pedro Amorim --- Created attachment 159869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159869&action=edit Bug 35581: Koha/Illrequest/Config.pm -> Koha/ILL/Request/Config.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #8 from Pedro Amorim --- Created attachment 159870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159870&action=edit Bug 35581: Koha/Illrequest/Logger.pm -> Koha/ILL/Request/Logger.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #9 from Pedro Amorim --- Created attachment 159871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159871&action=edit Bug 35581: Koha/Illrequest/SupplierUpdate.pm -> Koha/ILL/Request/SupplierUpdate.pm Koha/Illrequest/SupplierUpdateProcessor.pm -> Koha/ILL/Request/SupplierUpdateProcessor.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #10 from Pedro Amorim --- Created attachment 159872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159872&action=edit Bug 35581: Koha/Illrequest.pm -> Koha/ILL/Request.pm Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #11 from Pedro Amorim --- Created attachment 159873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159873&action=edit Bug 35581: QA Follow-up: Fix tidy warnings Fix forbidden pattern: Incorrect license statement (using postal address) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Depends on||19605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 [Bug 19605] ILL backends should be pluggable through regular Koha plugins -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35570 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Blocks||35570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 [Bug 35570] Add a generic master form in ILL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What|Removed |Added Attachment #159863|0 |1 is obsolete|| --- Comment #12 from David Nind --- Created attachment 160422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160422&action=edit Bug 35581: Illbackend.pm -> ILL/Backend.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What|Removed |Added Attachment #159864|0 |1 is obsolete|| --- Comment #13 from David Nind --- Created attachment 160423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160423&action=edit Bug 35581: Illbatch.pm -> ILL/Batch.pm Illbatches.pm -> ILL/Batches.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What|Removed |Added Attachment #159865|0 |1 is obsolete|| --- Comment #14 from David Nind --- Created attachment 160424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160424&action=edit Bug 35581: Illbatchstatus.pm -> ILL/Batch/status.pm Illbatchstatuses.pm -> ILL/Batch/Statuses.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What|Removed |Added Attachment #159866|0 |1 is obsolete|| --- Comment #15 from David Nind --- Created attachment 160425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160425&action=edit Bug 35581: Illcomment.pm -> ILL/Comment.pm Illcomments.pm -> ILL/Comments.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What|Removed |Added Attachment #159867|0 |1 is obsolete|| --- Comment #16 from David Nind --- Created attachment 160426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160426&action=edit Bug 35581: Illrequestattribute.pm -> ILL/Request/Attribute.pm Illrequestattributes.pm -> ILL/Request/Attributes.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What|Removed |Added Attachment #159868|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 160427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160427&action=edit Bug 35581: Koha/Illrequest/Workflow.pm -> Koha/ILL/Request/Workflow.pm Koha/Illrequest/Workflow/Availability.pm -> Koha/ILL/Request/Workflow/Availability.pm Koha/Illrequest/Workflow/TypeDisclaimer.pm -> Koha/ILL/Request/Workflow/TypeDisclaimer.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What|Removed |Added Attachment #159869|0 |1 is obsolete|| --- Comment #18 from David Nind --- Created attachment 160428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160428&action=edit Bug 35581: Koha/Illrequest/Config.pm -> Koha/ILL/Request/Config.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What|Removed |Added Attachment #159870|0 |1 is obsolete|| --- Comment #19 from David Nind --- Created attachment 160429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160429&action=edit Bug 35581: Koha/Illrequest/Logger.pm -> Koha/ILL/Request/Logger.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What|Removed |Added Attachment #159871|0 |1 is obsolete|| --- Comment #20 from David Nind --- Created attachment 160430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160430&action=edit Bug 35581: Koha/Illrequest/SupplierUpdate.pm -> Koha/ILL/Request/SupplierUpdate.pm Koha/Illrequest/SupplierUpdateProcessor.pm -> Koha/ILL/Request/SupplierUpdateProcessor.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What|Removed |Added Attachment #159872|0 |1 is obsolete|| --- Comment #21 from David Nind --- Created attachment 160431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160431&action=edit Bug 35581: Koha/Illrequest.pm -> Koha/ILL/Request.pm Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What|Removed |Added Attachment #159873|0 |1 is obsolete|| --- Comment #22 from David Nind --- Created attachment 160432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160432&action=edit Bug 35581: QA Follow-up: Fix tidy warnings Fix forbidden pattern: Incorrect license statement (using postal address) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #23 from David Nind --- Testing notes (using KTD): 1. Tests pass. 2. Also tested manually as per the test plan. For the PUBMED plugin, I created a request using these details: - Type: Journal article - Title: Regeneration of the heart - PMID: 22095736 (used when creating the batch) I'm not so familiar with the workflow for ILL requests, so it may be useful to have someone that is to add their sign off as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #24 from Pedro Amorim --- Created attachment 160620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160620&action=edit Bug 35581: (QA follow-up): Missed Illrequests.pm REST API class Koha/REST/V1/Illrequests.pm -> Koha/REST/V1/ILL/Requests.pm Test plan: 1 Apply patch 2 Make sure tests pass, run: prove t/db_dependent/api/v1/ill_* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Depends on||35331 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 [Bug 35331] Add an ILL table actions plugin hook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #25 from Pedro Amorim --- Created attachment 160622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160622&action=edit Bug 35581: (QA follow-up): Update changes coming from bug 35331 Test plan: prove t/db_dependent/Koha/Plugins/Ill_hooks.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #160422|0 |1 is obsolete|| --- Comment #26 from Pedro Amorim --- Created attachment 162020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162020&action=edit Bug 35581: Illbackend.pm -> ILL/Backend.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #160423|0 |1 is obsolete|| --- Comment #27 from Pedro Amorim --- Created attachment 162021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162021&action=edit Bug 35581: Illbatch.pm -> ILL/Batch.pm Illbatches.pm -> ILL/Batches.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #160424|0 |1 is obsolete|| --- Comment #28 from Pedro Amorim --- Created attachment 162022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162022&action=edit Bug 35581: Illbatchstatus.pm -> ILL/Batch/status.pm Illbatchstatuses.pm -> ILL/Batch/Statuses.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #160425|0 |1 is obsolete|| --- Comment #29 from Pedro Amorim --- Created attachment 162023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162023&action=edit Bug 35581: Illcomment.pm -> ILL/Comment.pm Illcomments.pm -> ILL/Comments.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #160426|0 |1 is obsolete|| --- Comment #30 from Pedro Amorim --- Created attachment 162024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162024&action=edit Bug 35581: Illrequestattribute.pm -> ILL/Request/Attribute.pm Illrequestattributes.pm -> ILL/Request/Attributes.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #160427|0 |1 is obsolete|| --- Comment #31 from Pedro Amorim --- Created attachment 162025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162025&action=edit Bug 35581: Koha/Illrequest/Workflow.pm -> Koha/ILL/Request/Workflow.pm Koha/Illrequest/Workflow/Availability.pm -> Koha/ILL/Request/Workflow/Availability.pm Koha/Illrequest/Workflow/TypeDisclaimer.pm -> Koha/ILL/Request/Workflow/TypeDisclaimer.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #160428|0 |1 is obsolete|| --- Comment #32 from Pedro Amorim --- Created attachment 162026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162026&action=edit Bug 35581: Koha/Illrequest/Config.pm -> Koha/ILL/Request/Config.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #160429|0 |1 is obsolete|| --- Comment #33 from Pedro Amorim --- Created attachment 162027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162027&action=edit Bug 35581: Koha/Illrequest/Logger.pm -> Koha/ILL/Request/Logger.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #160430|0 |1 is obsolete|| --- Comment #34 from Pedro Amorim --- Created attachment 162028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162028&action=edit Bug 35581: Koha/Illrequest/SupplierUpdate.pm -> Koha/ILL/Request/SupplierUpdate.pm Koha/Illrequest/SupplierUpdateProcessor.pm -> Koha/ILL/Request/SupplierUpdateProcessor.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #160431|0 |1 is obsolete|| --- Comment #35 from Pedro Amorim --- Created attachment 162029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162029&action=edit Bug 35581: Koha/Illrequest.pm -> Koha/ILL/Request.pm Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #160432|0 |1 is obsolete|| --- Comment #36 from Pedro Amorim --- Created attachment 162030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162030&action=edit Bug 35581: QA Follow-up: Fix tidy warnings Fix forbidden pattern: Incorrect license statement (using postal address) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #160620|0 |1 is obsolete|| --- Comment #37 from Pedro Amorim --- Created attachment 162031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162031&action=edit Bug 35581: (QA follow-up): Missed Illrequests.pm REST API class Koha/REST/V1/Illrequests.pm -> Koha/REST/V1/ILL/Requests.pm Test plan: 1 Apply patch 2 Make sure tests pass, run: prove t/db_dependent/api/v1/ill_* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #160622|0 |1 is obsolete|| --- Comment #38 from Pedro Amorim --- Created attachment 162032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162032&action=edit Bug 35581: (QA follow-up): Update changes coming from bug 35331 Test plan: prove t/db_dependent/Koha/Plugins/Ill_hooks.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #39 from Pedro Amorim --- Rebased on bug 34282 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added CC||nug...@gmail.com, ||vic...@tuxayo.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162020|0 |1 is obsolete|| --- Comment #40 from Pedro Amorim --- Created attachment 162817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162817&action=edit Bug 35581: Illbackend.pm -> ILL/Backend.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162021|0 |1 is obsolete|| --- Comment #41 from Pedro Amorim --- Created attachment 162818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162818&action=edit Bug 35581: Illbatch.pm -> ILL/Batch.pm Illbatches.pm -> ILL/Batches.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162022|0 |1 is obsolete|| --- Comment #42 from Pedro Amorim --- Created attachment 162819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162819&action=edit Bug 35581: Illbatchstatus.pm -> ILL/Batch/status.pm Illbatchstatuses.pm -> ILL/Batch/Statuses.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162023|0 |1 is obsolete|| --- Comment #43 from Pedro Amorim --- Created attachment 162820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162820&action=edit Bug 35581: Illcomment.pm -> ILL/Comment.pm Illcomments.pm -> ILL/Comments.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162024|0 |1 is obsolete|| --- Comment #44 from Pedro Amorim --- Created attachment 162821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162821&action=edit Bug 35581: Illrequestattribute.pm -> ILL/Request/Attribute.pm Illrequestattributes.pm -> ILL/Request/Attributes.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162025|0 |1 is obsolete|| --- Comment #45 from Pedro Amorim --- Created attachment 162822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162822&action=edit Bug 35581: Koha/Illrequest/Workflow.pm -> Koha/ILL/Request/Workflow.pm Koha/Illrequest/Workflow/Availability.pm -> Koha/ILL/Request/Workflow/Availability.pm Koha/Illrequest/Workflow/TypeDisclaimer.pm -> Koha/ILL/Request/Workflow/TypeDisclaimer.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162026|0 |1 is obsolete|| --- Comment #46 from Pedro Amorim --- Created attachment 162823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162823&action=edit Bug 35581: Koha/Illrequest/Config.pm -> Koha/ILL/Request/Config.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162027|0 |1 is obsolete|| --- Comment #47 from Pedro Amorim --- Created attachment 162824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162824&action=edit Bug 35581: Koha/Illrequest/Logger.pm -> Koha/ILL/Request/Logger.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162028|0 |1 is obsolete|| --- Comment #48 from Pedro Amorim --- Created attachment 162825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162825&action=edit Bug 35581: Koha/Illrequest/SupplierUpdate.pm -> Koha/ILL/Request/SupplierUpdate.pm Koha/Illrequest/SupplierUpdateProcessor.pm -> Koha/ILL/Request/SupplierUpdateProcessor.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162029|0 |1 is obsolete|| --- Comment #49 from Pedro Amorim --- Created attachment 162826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162826&action=edit Bug 35581: Koha/Illrequest.pm -> Koha/ILL/Request.pm Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162030|0 |1 is obsolete|| --- Comment #50 from Pedro Amorim --- Created attachment 162827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162827&action=edit Bug 35581: QA Follow-up: Fix tidy warnings Fix forbidden pattern: Incorrect license statement (using postal address) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162031|0 |1 is obsolete|| --- Comment #51 from Pedro Amorim --- Created attachment 162828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162828&action=edit Bug 35581: (QA follow-up): Missed Illrequests.pm REST API class Koha/REST/V1/Illrequests.pm -> Koha/REST/V1/ILL/Requests.pm Test plan: 1 Apply patch 2 Make sure tests pass, run: prove t/db_dependent/api/v1/ill_* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162032|0 |1 is obsolete|| --- Comment #52 from Pedro Amorim --- Created attachment 162829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162829&action=edit Bug 35581: (QA follow-up): Update changes coming from bug 35331 Test plan: prove t/db_dependent/Koha/Plugins/Ill_hooks.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #53 from Pedro Amorim --- Rebased on bug 34478 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Depends on||36245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36245 [Bug 36245] ILL - Custom backend form action is broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162817|0 |1 is obsolete|| --- Comment #54 from Pedro Amorim --- Created attachment 162880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162880&action=edit Bug 35581: Illbackend.pm -> ILL/Backend.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162818|0 |1 is obsolete|| --- Comment #55 from Pedro Amorim --- Created attachment 162881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162881&action=edit Bug 35581: Illbatch.pm -> ILL/Batch.pm Illbatches.pm -> ILL/Batches.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162819|0 |1 is obsolete|| --- Comment #56 from Pedro Amorim --- Created attachment 162882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162882&action=edit Bug 35581: Illbatchstatus.pm -> ILL/Batch/status.pm Illbatchstatuses.pm -> ILL/Batch/Statuses.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162820|0 |1 is obsolete|| --- Comment #57 from Pedro Amorim --- Created attachment 162883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162883&action=edit Bug 35581: Illcomment.pm -> ILL/Comment.pm Illcomments.pm -> ILL/Comments.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162821|0 |1 is obsolete|| --- Comment #58 from Pedro Amorim --- Created attachment 162884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162884&action=edit Bug 35581: Illrequestattribute.pm -> ILL/Request/Attribute.pm Illrequestattributes.pm -> ILL/Request/Attributes.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162822|0 |1 is obsolete|| --- Comment #59 from Pedro Amorim --- Created attachment 162885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162885&action=edit Bug 35581: Koha/Illrequest/Workflow.pm -> Koha/ILL/Request/Workflow.pm Koha/Illrequest/Workflow/Availability.pm -> Koha/ILL/Request/Workflow/Availability.pm Koha/Illrequest/Workflow/TypeDisclaimer.pm -> Koha/ILL/Request/Workflow/TypeDisclaimer.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162823|0 |1 is obsolete|| --- Comment #60 from Pedro Amorim --- Created attachment 162886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162886&action=edit Bug 35581: Koha/Illrequest/Config.pm -> Koha/ILL/Request/Config.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162824|0 |1 is obsolete|| --- Comment #61 from Pedro Amorim --- Created attachment 162887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162887&action=edit Bug 35581: Koha/Illrequest/Logger.pm -> Koha/ILL/Request/Logger.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162825|0 |1 is obsolete|| --- Comment #62 from Pedro Amorim --- Created attachment 162888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162888&action=edit Bug 35581: Koha/Illrequest/SupplierUpdate.pm -> Koha/ILL/Request/SupplierUpdate.pm Koha/Illrequest/SupplierUpdateProcessor.pm -> Koha/ILL/Request/SupplierUpdateProcessor.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162826|0 |1 is obsolete|| --- Comment #63 from Pedro Amorim --- Created attachment 162889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162889&action=edit Bug 35581: Koha/Illrequest.pm -> Koha/ILL/Request.pm Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162827|0 |1 is obsolete|| --- Comment #64 from Pedro Amorim --- Created attachment 162890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162890&action=edit Bug 35581: QA Follow-up: Fix tidy warnings Fix forbidden pattern: Incorrect license statement (using postal address) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162828|0 |1 is obsolete|| --- Comment #65 from Pedro Amorim --- Created attachment 162891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162891&action=edit Bug 35581: (QA follow-up): Missed Illrequests.pm REST API class Koha/REST/V1/Illrequests.pm -> Koha/REST/V1/ILL/Requests.pm Test plan: 1 Apply patch 2 Make sure tests pass, run: prove t/db_dependent/api/v1/ill_* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #162829|0 |1 is obsolete|| --- Comment #66 from Pedro Amorim --- Created attachment 162892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162892&action=edit Bug 35581: (QA follow-up): Update changes coming from bug 35331 Test plan: prove t/db_dependent/Koha/Plugins/Ill_hooks.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #67 from Pedro Amorim --- Rebased on bug 36245 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Tomás Cohen Arazi changed: What|Removed |Added Attachment #162880|0 |1 is obsolete|| Attachment #162881|0 |1 is obsolete|| Attachment #162882|0 |1 is obsolete|| Attachment #162883|0 |1 is obsolete|| Attachment #162884|0 |1 is obsolete|| Attachment #162885|0 |1 is obsolete|| Attachment #162886|0 |1 is obsolete|| Attachment #162887|0 |1 is obsolete|| Attachment #162888|0 |1 is obsolete|| Attachment #162889|0 |1 is obsolete|| Attachment #162890|0 |1 is obsolete|| Attachment #162891|0 |1 is obsolete|| Attachment #162892|0 |1 is obsolete|| --- Comment #68 from Tomás Cohen Arazi --- Created attachment 163803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163803&action=edit Bug 35581: Koha::Illbackend -> Koha::ILL::Backend Koha/Illbackend.pm -> Koha/ILL/Backend.pm Koha/REST/V1/Illbackends.pm -> Koha/REST/V1/ILL/Backends.pm Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #69 from Tomás Cohen Arazi --- Created attachment 163804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163804&action=edit Bug 35581: Koha::*Illbatch* -> Koha::*ILL::*Batch* Koha/Illbatch.pm -> Koha/ILL/Batch.pm Koha/Illbatches.pm -> Koha/ILL/Batches.pm Koha/REST/V1/Illbatches.pm -> Koha/REST/V1/ILL/Batches.pm t/db_dependent/Koha/Illbatch.t -> t/db_dependent/Koha/ILL/Batch.t t/db_dependent/Illbatches.t -> t/db_dependent/Koha/ILL/Batches.t Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #70 from Tomás Cohen Arazi --- Created attachment 163805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163805&action=edit Bug 35581: Illbatchstatus* -> ILL::Batch::Status* Koha/IllbatchStatus.pm -> Koha/ILL/Batch/Status.pm Koha/IllbatchStatuses.pm -> Koha/ILL/Batch/Statuses.pm Koha/REST/V1/IllbatchStatuses.pm -> Koha/REST/V1/ILL/Batch/Statuses.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #71 from Tomás Cohen Arazi --- Created attachment 163806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163806&action=edit Bug 35581: Koha::Illcomment* -> Koha::ILL::Comment* Koha/Illcomment.pm -> Koha/ILL/Comment.pm Koha/Illcomments.pm -> Koha/ILL/Comments.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #72 from Tomás Cohen Arazi --- Created attachment 163807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163807&action=edit Bug 35581: Koha::Illrequestattribute* -> Koha::ILL::Request::Attribute* Koha/Illrequestattribute.pm -> Koha/ILL/Request/Attribute.pm Koha/Illrequestattributes.pm -> Koha/ILL/Request/Attributes.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #73 from Tomás Cohen Arazi --- Created attachment 163808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163808&action=edit Bug 35581: Koha::Illrequest::Workflow* -> Koha::ILL::Request::Workflow* Koha/Illrequest/Workflow.pm -> Koha/ILL/Request/Workflow.pm Koha/Illrequest/Workflow/Availability.pm -> Koha/ILL/Request/Workflow/Availability.pm Koha/Illrequest/Workflow/TypeDisclaimer.pm -> Koha/ILL/Request/Workflow/TypeDisclaimer.pm Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #74 from Tomás Cohen Arazi --- Created attachment 163809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163809&action=edit Bug 35581: Koha::Illrequest::Config -> Koha::ILL::Request::Config Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #75 from Tomás Cohen Arazi --- Created attachment 163810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163810&action=edit Bug 35581: Koha::Illrequest::Logger -> Koha::ILL::Request::Logger Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #76 from Tomás Cohen Arazi --- Created attachment 163811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163811&action=edit Bug 35581: Koha::Illrequest::SupplierUpdate* -> Koha::ILL::Request::SupplierUpdate* Koha/Illrequest/SupplierUpdate.pm -> Koha/ILL/Request/SupplierUpdate.pm Koha/Illrequest/SupplierUpdateProcessor.pm -> Koha/ILL/Request/SupplierUpdateProcessor.pm Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #77 from Tomás Cohen Arazi --- Created attachment 163812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163812&action=edit Bug 35581: Koha::Illrequest -> Koha::ILL::Request Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #78 from Tomás Cohen Arazi --- Created attachment 163813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163813&action=edit Bug 35581: Koha::REST::V1::Illrequests -> Koha::REST::V1::ILL::Requests Test plan: 1. Apply patch 2. Make sure tests pass, run: prove t/db_dependent/api/v1/ill_* Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #79 from Tomás Cohen Arazi --- Created attachment 163814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163814&action=edit Bug 35581: Cleanup Comments.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #80 from Tomás Cohen Arazi --- Created attachment 163815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163815&action=edit Bug 35581: (follow-up) Remove internal use of ->illrequestattributes By now, we shouldn't be using the deprecated method internally. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #81 from Tomás Cohen Arazi --- Created attachment 163816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163816&action=edit Bug 35581: POD fixes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #163803|0 |1 is obsolete|| --- Comment #82 from Pedro Amorim --- Created attachment 164069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164069&action=edit Bug 35581: Koha::Illbackend -> Koha::ILL::Backend Koha/Illbackend.pm -> Koha/ILL/Backend.pm Koha/REST/V1/Illbackends.pm -> Koha/REST/V1/ILL/Backends.pm Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #163804|0 |1 is obsolete|| --- Comment #83 from Pedro Amorim --- Created attachment 164070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164070&action=edit Bug 35581: Koha::*Illbatch* -> Koha::*ILL::*Batch* Koha/Illbatch.pm -> Koha/ILL/Batch.pm Koha/Illbatches.pm -> Koha/ILL/Batches.pm Koha/REST/V1/Illbatches.pm -> Koha/REST/V1/ILL/Batches.pm t/db_dependent/Koha/Illbatch.t -> t/db_dependent/Koha/ILL/Batch.t t/db_dependent/Illbatches.t -> t/db_dependent/Koha/ILL/Batches.t Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #163805|0 |1 is obsolete|| --- Comment #84 from Pedro Amorim --- Created attachment 164071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164071&action=edit Bug 35581: Illbatchstatus* -> ILL::Batch::Status* Koha/IllbatchStatus.pm -> Koha/ILL/Batch/Status.pm Koha/IllbatchStatuses.pm -> Koha/ILL/Batch/Statuses.pm Koha/REST/V1/IllbatchStatuses.pm -> Koha/REST/V1/ILL/Batch/Statuses.pm Signed-off-by: David Nind Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #163806|0 |1 is obsolete|| --- Comment #85 from Pedro Amorim --- Created attachment 164072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164072&action=edit Bug 35581: Koha::Illcomment* -> Koha::ILL::Comment* Koha/Illcomment.pm -> Koha/ILL/Comment.pm Koha/Illcomments.pm -> Koha/ILL/Comments.pm Signed-off-by: David Nind Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #163807|0 |1 is obsolete|| --- Comment #86 from Pedro Amorim --- Created attachment 164073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164073&action=edit Bug 35581: Koha::Illrequestattribute* -> Koha::ILL::Request::Attribute* Koha/Illrequestattribute.pm -> Koha/ILL/Request/Attribute.pm Koha/Illrequestattributes.pm -> Koha/ILL/Request/Attributes.pm Signed-off-by: David Nind Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim changed: What|Removed |Added Attachment #163808|0 |1 is obsolete|| --- Comment #87 from Pedro Amorim --- Created attachment 164074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164074&action=edit Bug 35581: Koha::Illrequest::Workflow* -> Koha::ILL::Request::Workflow* Koha/Illrequest/Workflow.pm -> Koha/ILL/Request/Workflow.pm Koha/Illrequest/Workflow/Availability.pm -> Koha/ILL/Request/Workflow/Availability.pm Koha/Illrequest/Workflow/TypeDisclaimer.pm -> Koha/ILL/Request/Workflow/TypeDisclaimer.pm Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
