[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-05-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from Lucas Gass  ---
Doesn't apply clean to 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-05-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to main  |Pushed to stable
 Version(s)|24.05.00|24.05.00,23.11.06
released in||

--- Comment #11 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

--- Comment #10 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

--- Comment #9 from Katrin Fischer  ---
Good catch, thanks Brendan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #8 from Emily Lamancusa  ---
Thanks for the quick turnaround! Looks good now - passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #164437|0   |1
is obsolete||

--- Comment #7 from Emily Lamancusa  ---
Created attachment 164438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164438&action=edit
Bug 35708: Update default system preference for AutoRenewalNotices

Test plan:
1. Apply test plan and restart everything
2. Confirm AutoRenewalNotices defaults to patron messaging preferences

Signed-off-by: David Nind 
Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

--- Comment #6 from Brendan Lawlor  ---
(In reply to Emily Lamancusa from comment #4)

I had doubts about editing that file after I sent it.

Thanks for the info Emily!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Brendan Lawlor  changed:

   What|Removed |Added

 Attachment #164397|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

--- Comment #5 from Brendan Lawlor  ---
Created attachment 164437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164437&action=edit
Bug 35708: Update default system preference for AutoRenewalNotices

Test plan:
1. Apply test plan and restart everything
2. Confirm AutoRenewalNotices defaults to patron messaging preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Brendan Lawlor  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
   Patch complexity|--- |Trivial patch
 QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
   |y.org   |ountymd.gov
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
   Assignee|anke.br...@gwdg.de  |blaw...@clamsnet.org

--- Comment #4 from Emily Lamancusa  ---
Hi Brendan, thanks for catching that! 

Can you please amend your patch to remove the change to updatedatabase.pl? That
file is only used for upgrading existing systems older than version 21.05 - it
does not generally get edited anymore. The update to sysprefs.sql is all you
need in this case. :)

For future reference, this wiki page is a good starting point for making
changes to system preferences -
https://wiki.koha-community.org/wiki/System_Preferences

And if you're curious, a little history about updatedatabase.pl and how we make
database updates now -
https://wiki.koha-community.org/wiki/Database_updates#History

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||NEW INSTALLATIONS ONLY.
  release notes||This sets the default value
   ||for the AutoRenewalNotices
   ||system preference to
   ||"according to patron
   ||messaging preferences".
   ||(The previous default value
   ||was deprecated -
   ||"(Deprecated) according to
   ||--send-notices cron
   ||switch".)

--- Comment #3 from David Nind  ---
Testing notes (using KTD):

1. Check the system preference AutoRenewalNotices - note that the default is
"(Deprecated) according to --send-notices cron switch".
2. Apply the patch.
3. Reset everything (like it is a new installation): reset_all
4. Note that the AutoRenewalNotices system preference is now set to "according
to patron messaging preferences".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

David Nind  changed:

   What|Removed |Added

 Attachment #164394|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 164397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164397&action=edit
Bug: 35708: Update default system preference for AutoRenewalNotices

Test plan:
1. Apply test plan and restart everything
2. Confirm AutoRenewalNotices defaults to patron messaging preferences

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

--- Comment #1 from Brendan Lawlor  ---
Created attachment 164394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164394&action=edit
Bug: 35708: Update default system preference for AutoRenewalNotices

Test plan:
1. Apply test plan and restart everything
2. Confirm AutoRenewalNotices defaults to patron messaging preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Brendan Lawlor  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Anke Bruns  changed:

   What|Removed |Added

 CC||anke.br...@gwdg.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Anke Bruns  changed:

   What|Removed |Added

Version|22.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option

2024-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708

Anke Bruns  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |anke.br...@gwdg.de
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/