[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Bug 35787 depends on bug 35782, which changed state. Bug 35782 Summary: Remove Koha::Template::Plugin::Biblio::HoldsCount https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35782 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #10 from Caroline Cyr La Rose --- Architecture change, nothing to add/edit in the Koha manual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Needs documenting CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin Somers --- Enhancement not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 --- Comment #8 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 --- Comment #7 from Martin Renvoize --- Branch pushed https://github.com/PTFS-Europe/koha/tree/bug_35787 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Martin Renvoize changed: What|Removed |Added URL||https://github.com/PTFS-Eur ||ope/koha/tree/bug_35787 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Martin Renvoize changed: What|Removed |Added Blocks|35781 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 [Bug 35781] [omnibus] Remove unneeded Koha::Template::Plugin methods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Martin Renvoize changed: What|Removed |Added Blocks||35781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 [Bug 35781] [omnibus] Remove unneeded Koha::Template::Plugin methods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 --- Comment #6 from Martin Renvoize --- Created attachment 161056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161056=edit Bug 35787: Add unit test for filter_by_bookable Trivial test added for filter_by_bookable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Martin Renvoize changed: What|Removed |Added Depends on||29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 --- Comment #5 from Martin Renvoize --- Agreed on the too new to warrant the db rev.. but I will submit the unit tests for filter_by_bookable first thing tomorrow.. I have them on a branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 --- Comment #4 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #3) > Works as expected, QA script happy. > > QA question: You considered this TT method too new for a dbrev? I'd agree, > just mentioning in case it was an unintended miss. Yes, on purpose. I don't think we need one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | Status|Signed Off |Passed QA --- Comment #3 from Tomás Cohen Arazi --- Works as expected, QA script happy. QA question: You considered this TT method too new for a dbrev? I'd agree, just mentioning in case it was an unintended miss. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Tomás Cohen Arazi changed: What|Removed |Added Attachment #160960|0 |1 is obsolete|| --- Comment #2 from Tomás Cohen Arazi --- Created attachment 161038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161038=edit Bug 35787: Remove Koha::Template::Plugin::Biblio::CanBook We can replace it with biblio.items.filter_by_bookable, no need to have this TT method. Additionally there was no test for it. Test plan: Make sure the Bookings tab on the left of the biblio detail page is displayed when needed. Note that there is also a "Place booking" button that should appear in the toolbar. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Jonathan Druart changed: What|Removed |Added Blocks|35781 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 [Bug 35781] [omnibus] Remove unneeded Koha::Template::Plugin methods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Jonathan Druart changed: What|Removed |Added Depends on||35782 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35782 [Bug 35782] Remove Koha::Template::Plugin::Biblio::HoldsCount -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Jonathan Druart changed: What|Removed |Added Blocks||35788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 --- Comment #1 from Jonathan Druart --- Created attachment 160960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160960=edit Bug 35787: Remove Koha::Template::Plugin::Biblio::CanBook We can replace it with biblio.items.filter_by_bookable, no need to have this TT method. Additionally there was no test for it. Test plan: Make sure the Bookings tab on the left of the biblio detail page is displayed when needed. Note that there is also a "Place booking" button that should appear in the toolbar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
