[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #10 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|24.05.00|24.05.00,23.11.06 released in|| Status|Pushed to main |Pushed to stable --- Comment #9 from Fridolin Somers --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 --- Comment #8 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Katrin Fischer changed: What|Removed |Added Keywords||rel_22_11_candidate, ||rel_23_05_candidate, ||rel_23_11_candidate --- Comment #7 from Katrin Fischer --- Thanks for that one! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Katrin Fischer changed: What|Removed |Added CC||christian.stelzenmueller@bs ||z-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 --- Comment #6 from Jonathan Druart --- Created attachment 167007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167007=edit Bug 35929: Remove extra parenthesis and make it more readable Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Jonathan Druart changed: What|Removed |Added Attachment #166023|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 167006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167006=edit Bug 35929: Don't record a change for empty fields submitted in patron form This is reminiscent of bug 36159 - when a field is submitted as empty, and null in the DB we need to reject this as a change. I tried to copy the logic from that bug, as well as deleting submitted changes for hidden fields (from html manipulation) This should be tested extensively. One note: If you submit a valid change request, then submit a second with no change the second will be ignored, but the first will remain. i.e. if you change your name from 'Nick' to 'Nack' - then realize your typo you cannot submit a new request to change it back untl the initial request is cleared To test: 1 - Play with PatronSelfModificationBorrowerUnwantedField and PatronSelfModificationMandatory field to have some fields set 2 - Add a patron attribute, or several, that are editable in the OPAC 3 - Try submitting a form with no changes, note a modification requets is submitted 4 - Approve the request 5 - Apply patch, restart all 6 - Try submitted a blank request, you are notified there were no changes 7 - Try to force an unwanted field via html modification 8 - No changes reported 9 - Confirm attributes changes are successful 10 - After a successful request, try submitting a blank request 11 - Note no changes are recorded, but the initial request is still active Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Jonathan Druart changed: What|Removed |Added Blocks||36816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 [Bug 36816] OPAC - Patron 'submit update request' does not work for clearing patron attribute types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Lucas Gass changed: What|Removed |Added Attachment #166022|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 166023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166023=edit Bug 35929: Don't record a change for empty fields submitted in patron form This is reminiscent of bug 36159 - when a field is submitted as empty, and null in the DB we need to reject this as a change. I tried to copy the logic from that bug, as well as deleting submitted changes for hidden fields (from html manipulation) This should be tested extensively. One note: If you submit a valid change request, then submit a second with no change the second will be ignored, but the first will remain. i.e. if you change your name from 'Nick' to 'Nack' - then realize your typo you cannot submit a new request to change it back untl the initial request is cleared To test: 1 - Play with PatronSelfModificationBorrowerUnwantedField and PatronSelfModificationMandatory field to have some fields set 2 - Add a patron attribute, or several, that are editable in the OPAC 3 - Try submitting a form with no changes, note a modification requets is submitted 4 - Approve the request 5 - Apply patch, restart all 6 - Try submitted a blank request, you are notified there were no changes 7 - Try to force an unwanted field via html modification 8 - No changes reported 9 - Confirm attributes changes are successful 10 - After a successful request, try submitting a blank request 11 - Note no changes are recorded, but the initial request is still active Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Nick Clemens changed: What|Removed |Added Assignee|oleon...@myacpl.org |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 --- Comment #3 from Nick Clemens --- Created attachment 166022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166022=edit Bug 35929: Don't record a change for empty fields submitted in patron form This is reminiscent of bug 36159 - when a field is submitted as empty, and null in the DB we need to reject this as a change. I tried to copy the logic from that bug, as well as deleting submitted changes for hidden fields (from html manipulation) This should be tested extensively. One note: If you submit a valid change request, then submit a second with no change the second will be ignored, but the first will remain. i.e. if you change your name from 'Nick' to 'Nack' - then realize your typo you cannot submit a new request to change it back untl the initial request is cleared To test: 1 - Play with PatronSelfModificationBorrowerUnwantedField and PatronSelfModificationMandatory field to have some fields set 2 - Add a patron attribute, or several, that are editable in the OPAC 3 - Try submitting a form with no changes, note a modification requets is submitted 4 - Approve the request 5 - Apply patch, restart all 6 - Try submitted a blank request, you are notified there were no changes 7 - Try to force an unwanted field via html modification 8 - No changes reported 9 - Confirm attributes changes are successful 10 - After a successful request, try submitting a blank request 11 - Note no changes are recorded, but the initial request is still active -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36159 CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Jason Robb changed: What|Removed |Added CC||jr...@sekls.org --- Comment #2 from Jason Robb --- +1 We've been getting lots of odd blanks on the pending request modifications lately as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 --- Comment #1 from Katrin Fischer --- We just got another report of this, so giving this another 'bump'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/