[Koha-bugs] [Bug 36045] Use DataTables filter for suggestions search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36045 Owen Leonard changed: What|Removed |Added Attachment #165714|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 167792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167792=edit Bug 36045: Use DataTables filter for suggestions search This patch removes the server-side suggestions search form and related code from the OPAC suggestions page. In its place is a DataTables filter form and a custom dropdown to replace the "suggested by me/anyone" option from the old search. To test you should have some suggestions in your system submitted by two or more users. - Apply the patch and rebuild the OPAC CSS. - Go to Administration -> System preferences and set the "OPACViewOthersSuggestions" preference to "Show." - Log in to the OPAC as one of the users who has submitted suggetions. - Go to the purchase suggestions page. - The initial view should be of "your" suggestions. - The dropdown filter at the top should have "Suggested by me" selected. - The "Clear filter" button should be disabled. - Test that the "Suggested by me" dropdown works to change what's shown in the table. - The "Clear filter" button should be enabled when you choose "Suggested by anyone." - The DataTables "Search" field should work correctly with either setting of the "Suggested by..." dropdown. - Go back to Administration in the staff interface and disable the "OPACViewOthersSuggestions" preference. - Return to the suggestions page in the OPAC. - You should see only your suggestions, and the "Suggested by..." dropdown should not be there. - Confirm that filtering still works correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36045] Use DataTables filter for suggestions search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36045 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- The only thing I noticed, and I wasn't sure whether this it is what is expected or not: 1. Without entering a search term, if I select 'Suggested by anyone' it displays everyone else's suggestions - but not mine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36045] Use DataTables filter for suggestions search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36045 David Nind changed: What|Removed |Added Attachment #162061|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 165714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165714=edit Bug 36045: Use DataTables filter for suggestions search This patch removes the server-side suggestions search form and related code from the OPAC suggestions page. In its place is a DataTables filter form and a custom dropdown to replace the "suggested by me/anyone" option from the old search. To test you should have some suggestions in your system submitted by two or more users. - Apply the patch and rebuild the OPAC CSS. - Go to Administration -> System preferences and set the "OPACViewOthersSuggestions" preference to "Show." - Log in to the OPAC as one of the users who has submitted suggetions. - Go to the purchase suggestions page. - The initial view should be of "your" suggestions. - The dropdown filter at the top should have "Suggested by me" selected. - The "Clear filter" button should be disabled. - Test that the "Suggested by me" dropdown works to change what's shown in the table. - The "Clear filter" button should be enabled when you choose "Suggested by anyone." - The DataTables "Search" field should work correctly with either setting of the "Suggested by..." dropdown. - Go back to Administration in the staff interface and disable the "OPACViewOthersSuggestions" preference. - Return to the suggestions page in the OPAC. - You should see only your suggestions, and the "Suggested by..." dropdown should not be there. - Confirm that filtering still works correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36045] Use DataTables filter for suggestions search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36045 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36045] Use DataTables filter for suggestions search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36045 --- Comment #1 from Owen Leonard --- Created attachment 162061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162061=edit Bug 36045: Use DataTables filter for suggestions search This patch removes the server-side suggestions search form and related code from the OPAC suggestions page. In its place is a DataTables filter form and a custom dropdown to replace the "suggested by me/anyone" option from the old search. To test you should have some suggestions in your system submitted by two or more users. - Apply the patch and rebuild the OPAC CSS. - Go to Administration -> System preferences and set the "OPACViewOthersSuggestions" preference to "Show." - Log in to the OPAC as one of the users who has submitted suggetions. - Go to the purchase suggestions page. - The initial view should be of "your" suggestions. - The dropdown filter at the top should have "Suggested by me" selected. - The "Clear filter" button should be disabled. - Test that the "Suggested by me" dropdown works to change what's shown in the table. - The "Clear filter" button should be enabled when you choose "Suggested by anyone." - The DataTables "Search" field should work correctly with either setting of the "Suggested by..." dropdown. - Go back to Administration in the staff interface and disable the "OPACViewOthersSuggestions" preference. - Return to the suggestions page in the OPAC. - You should see only your suggestions, and the "Suggested by..." dropdown should not be there. - Confirm that filtering still works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36045] Use DataTables filter for suggestions search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36045 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36045] Use DataTables filter for suggestions search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36045 Owen Leonard changed: What|Removed |Added Summary|OPAC purchase suggestion|Use DataTables filter for |search too limited |suggestions search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/