[Koha-bugs] [Bug 36060] If issues table includes overdues 'Renew selected items' button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Fridolin Somers changed: What|Removed |Added Status|Pushed to main |Needs documenting CC||fridolin.som...@biblibre.co ||m --- Comment #23 from Fridolin Somers --- Depends on Bug 36418 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues 'Renew selected items' button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Keywords||rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues 'Renew selected items' button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #22 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues 'Renew selected items' button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues 'Renew selected items' button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #21 from Katrin Fischer --- No string changes, decided to push. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues 'Renew selected items' button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Katrin Fischer changed: What|Removed |Added Summary|If issues table includes|If issues table includes |overdues Renew selected |overdues 'Renew selected |items button is disabled|items' button is disabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #20 from Victor Grousset/tuxayo --- > 4. Notice that there is now 'Renew selected items' and 'Checkin > selected items' button. I'm assuming it's a copypasta from Bug 35068 test plan. Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166723|0 |1 is obsolete|| --- Comment #19 from Victor Grousset/tuxayo --- Created attachment 166943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166943=edit Bug 36060: (follow-up) Remember selections when refreshing the table Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162673|0 |1 is obsolete|| --- Comment #18 from Victor Grousset/tuxayo --- Created attachment 166942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166942=edit Bug 36060: Simplify logic to enable/disable CheckinChecked/RenewChecked buttons This patch attempts to simplify for disabling/enabling the 'Check in selected items' and 'Renewal selected items' buttons. To test: 1. APPLY patch, clear browser's cache 2. Have more than 1 checkout issued to a borrower. 3. Load the checkout table on circ/circulation.pl 4. Notice that there is now 'Renew selected items' and 'Checkin selected items' button. 5. Play around with each making sure that they work as excepted when checkouts are checked in either the 'Check in' or 'Renew' columns. 6. Uncheck everything in the 'Renew column', the 'Renew selected items' button should be disabled. 7. Uncheck everything in the 'Checkin column', the 'Checkin selected items' button should be disabled. 8. Try unchecking some of these to make sure the Renew/Checkin button is properly disabled when no related checkboxes are checked. 9. Try using the select all/none options at the top of both the 'Renew' and 'Checkin' columns. Make sure the 'Renew selected items' and 'Checkin selected items' become properly disabled/enabled. 10. Make sure the 'Renew all' button still works properly. 11. Have two checkouts. Click one for Renew and one for Checkin. Click on Check in selected items. 12. When the table reloads the 'renew' selections should be retained 13. Have two checkouts. Click one for Renew and one for Checkin. Click on Renew selected items. 14. When the table reloads the 'check in' selections should be retained 15. Have overdues 16. Go to a patron account and load the issue table 17. The items that are overdue are checked for renewal by default 16. The 'Renew selected items' button show be enabled. Signed-off-by: Brendan Lawlor Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #17 from Lucas Gass --- Created attachment 166723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166723=edit Bug 36060: (follow-up) Remember selections when refreshing the table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Attachment #164036|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Bug 36060 depends on bug 36418, which changed state. Bug 36418 Summary: Set response's content-type to application/json when needed - svc scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Failed QA QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net |y.org | --- Comment #16 from Victor Grousset/tuxayo --- > 13. Have two checkouts. Click one for Renew and one for Checkin. Click on > Renew selected items. > 14. When the table reloads the 'check in' selections should be retained Oh, no :( I tried many combinations and I never got checkin to stay when having done a renew. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #15 from Lucas Gass --- Created attachment 164036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164036=edit Bug 36060: (follow-up) Remove unnessesary code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060
--- Comment #14 from Lucas Gass ---
(In reply to Victor Grousset/tuxayo from comment #12)
> Found unused variables left:
> var renewchecked
> var checkinchecked
>
> ---
>
> minor thing: I don't get how `$("#RenewChecked").on("click"` works correctly
> without CheckRenewCheckinBoxes() when `$("#CheckinChecked").on("click"`
> needs it.
Neither should actually need it because CheckRenewCheckinBoxes() is called in
RefreshIssuesTable(). We also don't need the following in either of those on
click functions:
$('#RenewChecked, #CheckinChecked').prop('disabled' , true );
Thanks Victor!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #13 from Lucas Gass --- Went to look at QA concerns and noticed Bug 36418, making this one a dependency of that one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Depends on||36418 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418 [Bug 36418] Can't properly renew/checkin from issues-table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
--- Comment #12 from Victor Grousset/tuxayo ---
Found unused variables left:
var renewchecked
var checkinchecked
---
minor thing: I don't get how `$("#RenewChecked").on("click"` works correctly
without CheckRenewCheckinBoxes() when `$("#CheckinChecked").on("click"` needs
it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Attachment #162459|0 |1 is obsolete|| --- Comment #11 from Lucas Gass --- Created attachment 162673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162673=edit Bug 36060: Simplify logic to enable/disable CheckinChecked/RenewChecked buttons This patch attempts to simplify for disabling/enabling the 'Check in selected items' and 'Renewal selected items' buttons. To test: 1. APPLY patch, clear browser's cache 2. Have more than 1 checkout issued to a borrower. 3. Load the checkout table on circ/circulation.pl 4. Notice that there is now 'Renew selected items' and 'Checkin selected items' button. 5. Play around with each making sure that they work as excepted when checkouts are checked in either the 'Check in' or 'Renew' columns. 6. Uncheck everything in the 'Renew column', the 'Renew selected items' button should be disabled. 7. Uncheck everything in the 'Checkin column', the 'Checkin selected items' button should be disabled. 8. Try unchecking some of these to make sure the Renew/Checkin button is properly disabled when no related checkboxes are checked. 9. Try using the select all/none options at the top of both the 'Renew' and 'Checkin' columns. Make sure the 'Renew selected items' and 'Checkin selected items' become properly disabled/enabled. 10. Make sure the 'Renew all' button still works properly. 11. Have two checkouts. Click one for Renew and one for Checkin. Click on Check in selected items. 12. When the table reloads the 'renew' selections should be retained 13. Have two checkouts. Click one for Renew and one for Checkin. Click on Renew selected items. 14. When the table reloads the 'check in' selections should be retained 15. Have overdues 16. Go to a patron account and load the issue table 17. The items that are overdue are checked for renewal by default 16. The 'Renew selected items' button show be enabled. Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #10 from Lucas Gass --- Needs rebased now that Bug 34478 is in, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #9 from Lucas Gass --- (In reply to Brendan Lawlor from comment #8) > Hi Lucas, sorry for the false report and thanks for your time chatting with > me. > > I retested this bug this morning and could not reproduce it. So then I reset > git and tested again without the bug applied and then I could see it. > > So I think what happened was I didn't have the bug applied or had applied > the wrong bug by accident when I first saw the bug. > > My bad, status back to signed off. I appreciate your testing, Brendan. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #8 from Brendan Lawlor --- Hi Lucas, sorry for the false report and thanks for your time chatting with me. I retested this bug this morning and could not reproduce it. So then I reset git and tested again without the bug applied and then I could see it. So I think what happened was I didn't have the bug applied or had applied the wrong bug by accident when I first saw the bug. My bad, status back to signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Brendan Lawlor changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #7 from Lucas Gass --- I've tried reproducing the problem as Brendan describes in both Firefox and Chrome without success. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #6 from Lucas Gass --- (In reply to Brendan Lawlor from comment #5) > I'm not sure, but maybe the bug I saw where the checkout table reloaded with > both the renew and checkin box checked for a record could have been caused > by circ rules that I set up when I tested. I set the circ rule unit to > hours. I am going to test again with the default ktd circ rules and see if > the behavior is different. > > If it's not the circ rules, maybe it is just caused by the user following a > specific, admittedly goofy sequence of actions. > > > To reproduce: > 1. Set the circ rule unit to hours > 2. Have a few checkouts with at least one overdue > 3. Load the checkout table and see the overdue item's renew checkbox is > checked by default > 4. Change the overdue item's checkbox to check the Check In checkbox instead > 5. Check the Renew checkbox for a different item > 6. Click the Renew selected items button > 7. When the table reloads see both the Renew and Check In checkboxes are > checked for the overdue item Sorry Brendan, I am still unable to reproduce this problem following your test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #5 from Brendan Lawlor --- I'm not sure, but maybe the bug I saw where the checkout table reloaded with both the renew and checkin box checked for a record could have been caused by circ rules that I set up when I tested. I set the circ rule unit to hours. I am going to test again with the default ktd circ rules and see if the behavior is different. If it's not the circ rules, maybe it is just caused by the user following a specific, admittedly goofy sequence of actions. To reproduce: 1. Set the circ rule unit to hours 2. Have a few checkouts with at least one overdue 3. Load the checkout table and see the overdue item's renew checkbox is checked by default 4. Change the overdue item's checkbox to check the Check In checkbox instead 5. Check the Renew checkbox for a different item 6. Click the Renew selected items button 7. When the table reloads see both the Renew and Check In checkboxes are checked for the overdue item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #4 from Lucas Gass --- (In reply to Brendan Lawlor from comment #3) > This worked as described, but I just noticed one small edge case with the > overdues. > > Because the renew boxes are checked by default, if you change the selection > on an overdue to checkin and then click the renew selected items it reloads > with the default renew checkboxes checked for the overdues, but also retains > the change you made to select the checkin checkbox as selected. > > It's not a problem if you don't have overdues, or if after you check a > checkin boxes for overdues you use the checkin selected button first before > using the renew selected button. Brendan, With this patch applied I am unable to recreate this problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Brendan Lawlor changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Brendan Lawlor changed: What|Removed |Added CC||blaw...@clamsnet.org --- Comment #3 from Brendan Lawlor --- This worked as described, but I just noticed one small edge case with the overdues. Because the renew boxes are checked by default, if you change the selection on an overdue to checkin and then click the renew selected items it reloads with the default renew checkboxes checked for the overdues, but also retains the change you made to select the checkin checkbox as selected. It's not a problem if you don't have overdues, or if after you check a checkin boxes for overdues you use the checkin selected button first before using the renew selected button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Brendan Lawlor changed: What|Removed |Added Attachment #161991|0 |1 is obsolete|| --- Comment #2 from Brendan Lawlor --- Created attachment 162459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162459=edit Bug 36060: Simplify logic to enable/disable CheckinChecked/RenewChecked buttons This patch attempts to simplify for disabling/enabling the 'Check in selected items' and 'Renewal selected items' buttons. To test: 1. APPLY patch, clear browser's cache 2. Have more than 1 checkout issued to a borrower. 3. Load the checkout table on circ/circulation.pl 4. Notice that there is now 'Renew selected items' and 'Checkin selected items' button. 5. Play around with each making sure that they work as excepted when checkouts are checked in either the 'Check in' or 'Renew' columns. 6. Uncheck everything in the 'Renew column', the 'Renew selected items' button should be disabled. 7. Uncheck everything in the 'Checkin column', the 'Checkin selected items' button should be disabled. 8. Try unchecking some of these to make sure the Renew/Checkin button is properly disabled when no related checkboxes are checked. 9. Try using the select all/none options at the top of both the 'Renew' and 'Checkin' columns. Make sure the 'Renew selected items' and 'Checkin selected items' become properly disabled/enabled. 10. Make sure the 'Renew all' button still works properly. 11. Have two checkouts. Click one for Renew and one for Checkin. Click on Check in selected items. 12. When the table reloads the 'renew' selections should be retained 13. Have two checkouts. Click one for Renew and one for Checkin. Click on Renew selected items. 14. When the table reloads the 'check in' selections should be retained 15. Have overdues 16. Go to a patron account and load the issue table 17. The items that are overdue are checked for renewal by default 16. The 'Renew selected items' button show be enabled. Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Brendan Lawlor changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #1 from Lucas Gass --- Created attachment 161991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161991=edit Bug 36060: Simplify logic to enable/disable CheckinChecked/RenewChecked buttons This patch attempts to simplify for disabling/enabling the 'Check in selected items' and 'Renewal selected items' buttons. To test: 1. APPLY patch, clear browser's cache 2. Have more than 1 checkout issued to a borrower. 3. Load the checkout table on circ/circulation.pl 4. Notice that there is now 'Renew selected items' and 'Checkin selected items' button. 5. Play around with each making sure that they work as excepted when checkouts are checked in either the 'Check in' or 'Renew' columns. 6. Uncheck everything in the 'Renew column', the 'Renew selected items' button should be disabled. 7. Uncheck everything in the 'Checkin column', the 'Checkin selected items' button should be disabled. 8. Try unchecking some of these to make sure the Renew/Checkin button is properly disabled when no related checkboxes are checked. 9. Try using the select all/none options at the top of both the 'Renew' and 'Checkin' columns. Make sure the 'Renew selected items' and 'Checkin selected items' become properly disabled/enabled. 10. Make sure the 'Renew all' button still works properly. 11. Have two checkouts. Click one for Renew and one for Checkin. Click on Check in selected items. 12. When the table reloads the 'renew' selections should be retained 13. Have two checkouts. Click one for Renew and one for Checkin. Click on Renew selected items. 14. When the table reloads the 'check in' selections should be retained 15. Have overdues 16. Go to a patron account and load the issue table 17. The items that are overdue are checked for renewal by default 16. The 'Renew selected items' button show be enabled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Depends on||35068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35068 [Bug 35068] Split 'Renew or check in selected items' button in issues table into separate buttons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
