[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #21 from Kyle M Hall --- Could you update mainpage.pl to only execute the query if the results will be visible? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Owen Leonard changed: What|Removed |Added Attachment #165823|0 |1 is obsolete|| Attachment #165824|0 |1 is obsolete|| --- Comment #22 from Owen Leonard --- Created attachment 170654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170654&action=edit Bug 36064: Add holds with cancellation request info to staff interface main page To Test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Make sure there is a Default waiting hold cancellation policy. 4. Make the holds watiing by checking them in. 5. Go to the OPAC and request to cancel. 6. Go to the staff interface home page, you should see 'Holds with cancellation requests: X'. 7. Cancel the hold. 8. Back on the main page it should not be counted again the number for 'Holds with cancellation requests: X' 9. Log in as a staff member with Staff access but without circulate_remaining_permissions. 10. You should not see the 'Holds with cancellation requests: X' line. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064
--- Comment #23 from Owen Leonard ---
Created attachment 170655
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170655&action=edit
Bug 36064: (follow-up) Activate correct tab
This patch makes a change to the JavaScript on waitingreserves.pl so
that the correct tab is activated if you follow the "Holds with
cancellation requests" link on the home page.
The page has code to activate the last viewed tab, but I've modified it
so that if there is a location hash ('waitingreserves.pl#tab') the tab
specified in the hash is selected instead of the last used tab.
If there is no location hash the last active tab will be activated.
I've also corrected the location hash in the link on the home page.
To test, apply the patch and follow the "Holds with cancellation
requests" link. The "Holds with cancellation requests" tab should be
active.
Click a different tab, e.g. "Holds waiting." Go the the circulation home
page, then click the link for "Holds awaiting pickup." The tab you
selected should be active.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Depends on||36063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 [Bug 36063] Add Holds to Pull info to intranet-main page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 --- Comment #1 from Lucas Gass --- Created attachment 161998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161998&action=edit Bug 36064: Add holds with cancellation request info to staff interface main page To Test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Make sure there is a Default waiting hold cancellation policy. 4. Make the holds watiing by checking them in. 5. Go to the OPAC and request to cancel. 6. Go to the staff interface home page, you should see 'Holds with cancellation requests: X'. 7. Cancel the hold. 8. Back on the main page it should not be counted again the number for 'Holds with cancellation requests: X' 9. Log in as a staff member with Staff access but without circulate_remaining_permissions. 10. You should not see the 'Holds with cancellation requests: X' line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Depends on||22456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 [Bug 22456] Allow patrons to cancel their waiting holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 David Nind changed: What|Removed |Added Attachment #161998|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 161999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161999&action=edit Bug 36064: Add holds with cancellation request info to staff interface main page To Test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Make sure there is a Default waiting hold cancellation policy. 4. Make the holds watiing by checking them in. 5. Go to the OPAC and request to cancel. 6. Go to the staff interface home page, you should see 'Holds with cancellation requests: X'. 7. Cancel the hold. 8. Back on the main page it should not be counted again the number for 'Holds with cancellation requests: X' 9. Log in as a staff member with Staff access but without circulate_remaining_permissions. 10. You should not see the 'Holds with cancellation requests: X' line. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 ByWater Sandboxes changed: What|Removed |Added Attachment #161999|0 |1 is obsolete|| --- Comment #3 from ByWater Sandboxes --- Created attachment 162002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162002&action=edit Bug 36064: Add holds with cancellation request info to staff interface main page To Test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Make sure there is a Default waiting hold cancellation policy. 4. Make the holds watiing by checking them in. 5. Go to the OPAC and request to cancel. 6. Go to the staff interface home page, you should see 'Holds with cancellation requests: X'. 7. Cancel the hold. 8. Back on the main page it should not be counted again the number for 'Holds with cancellation requests: X' 9. Log in as a staff member with Staff access but without circulate_remaining_permissions. 10. You should not see the 'Holds with cancellation requests: X' line. Signed-off-by: David Nind Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 --- Comment #4 from Christopher Brannon --- Works as described. However, the link to the cancelled holds page/tab isn't 100%. It takes you to the page, but doesn't always bring up the tab. I think it is an issue with the page/tab, not this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Blocks||36073 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36073 [Bug 36073] Add Holds Queue info to intranet-main page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Blocks|36073 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36073 [Bug 36073] Add Holds Queue info to intranet-main page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064
--- Comment #5 from Owen Leonard ---
Created attachment 162105
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162105&action=edit
Bug 36064: (follow-up) Activate correct tab
This patch makes a change to the JavaScript on waitingreserves.pl so
that the correct tab is activated if you follow the "Holds with
cancellation requests" link on the home page.
The page has code to activate the last viewed tab, but I've modified it
so that if there is a location hash ('waitingreserves.pl#tab') the tab
specified in the hash is selected instead of the last used tab.
If there is no location hash the last active tab will be activated.
I've also corrected the location hash in the link on the home page.
To test, apply the patch and follow the "Holds with cancellation
requests" link. The "Holds with cancellation requests" tab should be
active.
Click a different tab, e.g. "Holds waiting." Go the the circulation home
page, then click the link for "Holds awaiting pickup." The tab you
selected should be active.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #6 from David Nind --- Just a note - this bug is dependent on bug 36063, which currently doesn't apply (and is also currently Failed QA). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Owen Leonard changed: What|Removed |Added Attachment #162002|0 |1 is obsolete|| Attachment #162105|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 165796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165796&action=edit Bug 36064: Add holds with cancellation request info to staff interface main page To Test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Make sure there is a Default waiting hold cancellation policy. 4. Make the holds watiing by checking them in. 5. Go to the OPAC and request to cancel. 6. Go to the staff interface home page, you should see 'Holds with cancellation requests: X'. 7. Cancel the hold. 8. Back on the main page it should not be counted again the number for 'Holds with cancellation requests: X' 9. Log in as a staff member with Staff access but without circulate_remaining_permissions. 10. You should not see the 'Holds with cancellation requests: X' line. Signed-off-by: David Nind Signed-off-by: Christopher Brannon Current depends: 22456 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064
--- Comment #8 from Owen Leonard ---
Created attachment 165797
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165797&action=edit
Bug 36064: (follow-up) Activate correct tab
This patch makes a change to the JavaScript on waitingreserves.pl so
that the correct tab is activated if you follow the "Holds with
cancellation requests" link on the home page.
The page has code to activate the last viewed tab, but I've modified it
so that if there is a location hash ('waitingreserves.pl#tab') the tab
specified in the hash is selected instead of the last used tab.
If there is no location hash the last active tab will be activated.
I've also corrected the location hash in the link on the home page.
To test, apply the patch and follow the "Holds with cancellation
requests" link. The "Holds with cancellation requests" tab should be
active.
Click a different tab, e.g. "Holds waiting." Go the the circulation home
page, then click the link for "Holds awaiting pickup." The tab you
selected should be active.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Owen Leonard changed: What|Removed |Added Attachment #165796|0 |1 is obsolete|| Attachment #165797|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 165798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165798&action=edit Bug 36064: Add holds with cancellation request info to staff interface main page To Test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Make sure there is a Default waiting hold cancellation policy. 4. Make the holds watiing by checking them in. 5. Go to the OPAC and request to cancel. 6. Go to the staff interface home page, you should see 'Holds with cancellation requests: X'. 7. Cancel the hold. 8. Back on the main page it should not be counted again the number for 'Holds with cancellation requests: X' 9. Log in as a staff member with Staff access but without circulate_remaining_permissions. 10. You should not see the 'Holds with cancellation requests: X' line. Signed-off-by: David Nind Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064
--- Comment #10 from Owen Leonard ---
Created attachment 165799
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165799&action=edit
Bug 36064: (follow-up) Activate correct tab
This patch makes a change to the JavaScript on waitingreserves.pl so
that the correct tab is activated if you follow the "Holds with
cancellation requests" link on the home page.
The page has code to activate the last viewed tab, but I've modified it
so that if there is a location hash ('waitingreserves.pl#tab') the tab
specified in the hash is selected instead of the last used tab.
If there is no location hash the last active tab will be activated.
I've also corrected the location hash in the link on the home page.
To test, apply the patch and follow the "Holds with cancellation
requests" link. The "Holds with cancellation requests" tab should be
active.
Click a different tab, e.g. "Holds waiting." Go the the circulation home
page, then click the link for "Holds awaiting pickup." The tab you
selected should be active.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Owen Leonard changed: What|Removed |Added Depends on|36063 | --- Comment #11 from Owen Leonard --- (In reply to David Nind from comment #6) > Just a note - this bug is dependent on bug 36063, which currently doesn't > apply (and is also currently Failed QA). I hope no one minds, I rebased this one on main so that it could move forward without waiting for Bug 36063. The features don't really depend on each other. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 [Bug 36063] Add Holds to Pull info to intranet-main page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 --- Comment #12 from Lucas Gass --- > I hope no one minds, I rebased this one on main so that it could move > forward without waiting for Bug 36063. The features don't really depend on > each other. I appreciate it, Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #13 from David Nind --- sha1/fake ancestor error when trying to apply the patches: git bz apply 36064 Bug 36064 - Add Holds with cancellation requests info to intranet-main page 165798 - Bug 36064: Add holds with cancellation request info to staff interface main page 165799 - Bug 36064: (follow-up) Activate correct tab Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36064: Add holds with cancellation request info to staff interface main page error: sha1 information is lacking or useless (mainpage.pl). error: could not build fake ancestor Patch failed at 0001 Bug 36064: Add holds with cancellation request info to staff interface main page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Attachment #165798|0 |1 is obsolete|| --- Comment #14 from Lucas Gass --- Created attachment 165809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165809&action=edit Bug 36064: Add holds with cancellation request info to staff interface main page To Test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Make sure there is a Default waiting hold cancellation policy. 4. Make the holds watiing by checking them in. 5. Go to the OPAC and request to cancel. 6. Go to the staff interface home page, you should see 'Holds with cancellation requests: X'. 7. Cancel the hold. 8. Back on the main page it should not be counted again the number for 'Holds with cancellation requests: X' 9. Log in as a staff member with Staff access but without circulate_remaining_permissions. 10. You should not see the 'Holds with cancellation requests: X' line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064
Lucas Gass changed:
What|Removed |Added
Attachment #165799|0 |1
is obsolete||
--- Comment #15 from Lucas Gass ---
Created attachment 165810
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165810&action=edit
Bug 36064: (follow-up) Activate correct tab
This patch makes a change to the JavaScript on waitingreserves.pl so
that the correct tab is activated if you follow the "Holds with
cancellation requests" link on the home page.
The page has code to activate the last viewed tab, but I've modified it
so that if there is a location hash ('waitingreserves.pl#tab') the tab
specified in the hash is selected instead of the last used tab.
If there is no location hash the last active tab will be activated.
I've also corrected the location hash in the link on the home page.
To test, apply the patch and follow the "Holds with cancellation
requests" link. The "Holds with cancellation requests" tab should be
active.
Click a different tab, e.g. "Holds waiting." Go the the circulation home
page, then click the link for "Holds awaiting pickup." The tab you
selected should be active.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 --- Comment #16 from Lucas Gass --- Rebased my patch and attached it back with Owen's as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 David Nind changed: What|Removed |Added Attachment #165809|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 165823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165823&action=edit Bug 36064: Add holds with cancellation request info to staff interface main page To Test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Make sure there is a Default waiting hold cancellation policy. 4. Make the holds watiing by checking them in. 5. Go to the OPAC and request to cancel. 6. Go to the staff interface home page, you should see 'Holds with cancellation requests: X'. 7. Cancel the hold. 8. Back on the main page it should not be counted again the number for 'Holds with cancellation requests: X' 9. Log in as a staff member with Staff access but without circulate_remaining_permissions. 10. You should not see the 'Holds with cancellation requests: X' line. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064
David Nind changed:
What|Removed |Added
Attachment #165810|0 |1
is obsolete||
--- Comment #18 from David Nind ---
Created attachment 165824
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165824&action=edit
Bug 36064: (follow-up) Activate correct tab
This patch makes a change to the JavaScript on waitingreserves.pl so
that the correct tab is activated if you follow the "Holds with
cancellation requests" link on the home page.
The page has code to activate the last viewed tab, but I've modified it
so that if there is a location hash ('waitingreserves.pl#tab') the tab
specified in the hash is selected instead of the last used tab.
If there is no location hash the last active tab will be activated.
I've also corrected the location hash in the link on the home page.
To test, apply the patch and follow the "Holds with cancellation
requests" link. The "Holds with cancellation requests" tab should be
active.
Click a different tab, e.g. "Holds waiting." Go the the circulation home
page, then click the link for "Holds awaiting pickup." The tab you
selected should be active.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds a release notes||"Holds with cancellation ||requests: X" link to the ||staff interface home page. ||This makes it more visible ||to librarians that patrons ||have made cancellation ||requests, and action them ||(where patrons have the ||ability to cancel holds). --- Comment #19 from David Nind --- Testing notes (using KTD): 1. Enable patrons to cancel hold requests: 1.1 Go to Administration > Circulation and fine rules > Default waiting hold cancellation policy 1.2 For All and All set cancellation allowed to Yes and click +Add 2. Have some patron hold cancellation requests: 2.1 Log in as the patron you created the holds for (change their username and password) 2.2 In the OPAC under Summary > Holds, click 'Request to cancel' for one of the waiting holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 --- Comment #20 from Katrin Fischer --- I believe this could make a great and save addition to 24.05 still. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
