[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #162675|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 162683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162683=edit Bug 36187: Corrected set data.patron_id in select_suggestor() To test: 1. Make a new suggestion in the staff interface and attempt to set the "Created by" patron to someone other than the logged in user. 2. Submit the suggestion. 3. select suggestedby from suggestions where suggestionid = X; ( Where X is the suggestionid ) 4. The value is NULL 5. On suggestion/suggestion.pl the "Suggested by" column is blank. 6. APPLY PATCH 7. Try 1 - 3 again. This time the suggestedby should be correctly set. Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass changed: What|Removed |Added Attachment #162520|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 162675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162675=edit Bug 36187: Corrected set data.patron_id in select_suggestor() To test: 1. Make a new suggestion in the staff interface and attempt to set the "Created by" patron to someone other than the logged in user. 2. Submit the suggestion. 3. select suggestedby from suggestions where suggestionid = X; ( Where X is the suggestionid ) 4. The value is NULL 5. On suggestion/suggestion.pl the "Suggested by" column is blank. 6. APPLY PATCH 7. Try 1 - 3 again. This time the suggestedby should be correctly set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass changed: What|Removed |Added Blocks||35597 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35597 [Bug 35597] Purchase Suggestion changes aren't logged -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 --- Comment #2 from Lucas Gass --- Created attachment 162520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162520=edit Bug 36187: Corrected set data.patron_id in select_suggestor() To test: 1. Make a new suggestion in the staff interface and attempt to set the "Created by" patron to someone other than the logged in user. 2. Submit the suggestion. 3. select suggestedby from suggestions where suggestionid = X; ( Where X is the suggestionid ) 4. The value is NULL 5. On suggestion/suggestion.pl the "Suggested by" column is blank. 6. APPLY PATCH 7. Try 1 - 3 again. This time the suggestedby should be correctly set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 --- Comment #1 from Lucas Gass --- In the select_suggester() function data.borrowernumber is incorrect. It should be data.patron_id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/