[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Owen Leonard changed: What|Removed |Added Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Fridolin Somers changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED --- Comment #11 from Fridolin Somers --- Bug 34478 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Katrin Fischer changed: What|Removed |Added Depends on||34478 --- Comment #10 from Katrin Fischer --- (In reply to Fridolin Somers from comment #9) > So depends on Bug 34478 right ? Correct Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin Somers --- So depends on Bug 34478 right ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 --- Comment #8 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Marcel de Rooy changed: What|Removed |Added Attachment #162994|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 163166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163166=edit Bug 36274: Correct links leading to purchase suggestion page To test: 1. APPLY PATCH 2. As a logged in OPAC user go to 'Your account' > Purchase suggestion. The form should display. 3. Make a suggestion and confirm it works. 4. Try to make a suggestion using title, author, isbn information from an item that already exists. 5. See the "A similar document already exists:" warning. Confirm the suggestion anyways. 6. Set MaxTotalSuggestions to 4 and NumberOfSuggestionDays to 2. Make sure you can still navigate to the purchase suggestion form. 7. Do an OPAC search that will yield no results as a logged in user. 8. Click the "Make a purchase suggestion" link, making sure it works. 9. Turn on AnonSuggestions and log out of the OPAC. 10. Do an OPAC search that will yield no results. Again click the "Make a purchase suggestion", confirm it works. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Katrin Fischer changed: What|Removed |Added Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 David Nind changed: What|Removed |Added Attachment #162935|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 162994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162994=edit Bug 36274: Correct links leading to purchase suggestion page To test: 1. APPLY PATCH 2. As a logged in OPAC user go to 'Your account' > Purchase suggestion. The form should display. 3. Make a suggestion and confirm it works. 4. Try to make a suggestion using title, author, isbn information from an item that already exists. 5. See the "A similar document already exists:" warning. Confirm the suggestion anyways. 6. Set MaxTotalSuggestions to 4 and NumberOfSuggestionDays to 2. Make sure you can still navigate to the purchase suggestion form. 7. Do an OPAC search that will yield no results as a logged in user. 8. Click the "Make a purchase suggestion" link, making sure it works. 9. Turn on AnonSuggestions and log out of the OPAC. 10. Do an OPAC search that will yield no results. Again click the "Make a purchase suggestion", confirm it works. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 --- Comment #5 from Lucas Gass --- (In reply to Owen Leonard from comment #3) > This works to display the form I think there's still a problem with the > check for duplicates. I filled out the form (title, author, isbn, and year) > using information from a book already in the catalog and when I submitted it > I got a blank page. Good catch. I approached this the wrong way. My new patch should be better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Lucas Gass changed: What|Removed |Added Attachment #162907|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 162935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162935=edit Bug 36274: Correct links leading to purchase suggestion page To test: 1. APPLY PATCH 2. As a logged in OPAC user go to 'Your account' > Purchase suggestion. The form should display. 3. Make a suggestion and confirm it works. 4. Try to make a suggestion using title, author, isbn information from an item that already exists. 5. See the "A similar document already exists:" warning. Confirm the suggestion anyways. 6. Set MaxTotalSuggestions to 4 and NumberOfSuggestionDays to 2. Make sure you can still navigate to the purchase suggestion form. 7. Do an OPAC search that will yield no results as a logged in user. 8. Click the "Make a purchase suggestion" link, making sure it works. 9. Turn on AnonSuggestions and log out of the OPAC. 10. Do an OPAC search that will yield no results. Again click the "Make a purchase suggestion", confirm it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 --- Comment #3 from Owen Leonard --- This works to display the form I think there's still a problem with the check for duplicates. I filled out the form (title, author, isbn, and year) using information from a book already in the catalog and when I submitted it I got a blank page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 --- Comment #2 from Lucas Gass --- (In reply to Katrin Fischer from comment #0) > When in the OPAC and I click on "New suggestion", only an empty page comes > up. The form is missing. > I didn't see anything in the logs. > Not sure if this is related to CSRF or not? Yes, related to CSRF but a trivial fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com Patch complexity|--- |Trivial patch CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 --- Comment #1 from Lucas Gass --- Created attachment 162907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162907=edit Bug 36274: Use right op on opac-suggestions.tt To test: 1. click on "New suggestion", only an empty page comes up. The form is missing. 2. Apply patch and try again. 3. Play with suggestions making sure everything looks as excepted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Katrin Fischer changed: What|Removed |Added Blocks||36044 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36044 [Bug 36044] Show ISBN number of purchase suggestions on the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
