[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|RESOLVED CC||lu...@bywatersolutions.com Resolution|--- |FIXED --- Comment #15 from Lucas Gass --- Not needed in 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Fridolin Somers changed: What|Removed |Added Version(s)|24.05.00|24.05.00,23.11.06 released in|| Status|Pushed to main |Pushed to stable CC||fridolin.som...@biblibre.co ||m --- Comment #14 from Fridolin Somers --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Katrin Fischer changed: What|Removed |Added Version|23.11 |Main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 --- Comment #13 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #12 from Victor Grousset/tuxayo --- > The strange thing is, however, that we do not notice any latency when > highlighting strings after a click... Only happens in 0XX fields. Anyway. Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166105|0 |1 is obsolete|| --- Comment #11 from Victor Grousset/tuxayo --- Created attachment 166478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166478&action=edit Bug 36388: Mouse operation does not work in draggable fields in authority editor When using the authority editor in Firefox, it is not possible to set the cursor or select text from the text field. This patch mimics the corrections made in bug 35425 for biblio editor. Test plan: == 1. Start editing an existing authority record and try to put the cursor with the mouse in the middle of the content of any subfield or to select text with the mouse. It should not be possilbe. 2. Apply the patch (reload plack etc.). 3. Repeat p. 1 - everything should work as expected. Signed-off-by: Lucas Gass Signed-off-by: Pedro Amorim Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m Severity|normal |minor Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Pedro Amorim changed: What|Removed |Added Attachment #165852|0 |1 is obsolete|| --- Comment #10 from Pedro Amorim --- Created attachment 166105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166105&action=edit Bug 36388: Mouse operation does not work in draggable fields in authority editor When using the authority editor in Firefox, it is not possible to set the cursor or select text from the text field. This patch mimics the corrections made in bug 35425 for biblio editor. Test plan: == 1. Start editing an existing authority record and try to put the cursor with the mouse in the middle of the content of any subfield or to select text with the mouse. It should not be possilbe. 2. Apply the patch (reload plack etc.). 3. Repeat p. 1 - everything should work as expected. Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Janusz Kaczmarek changed: What|Removed |Added Attachment #165851|0 |1 is obsolete|| --- Comment #9 from Janusz Kaczmarek --- Created attachment 165852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165852&action=edit Bug 36388: Mouse operation does not work in draggable fields in authority editor When using the authority editor in Firefox, it is not possible to set the cursor or select text from the text field. This patch mimics the corrections made in bug 35425 for biblio editor. Test plan: == 1. Start editing an existing authority record and try to put the cursor with the mouse in the middle of the content of any subfield or to select text with the mouse. It should not be possilbe. 2. Apply the patch (reload plack etc.). 3. Repeat p. 1 - everything should work as expected. Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Janusz Kaczmarek changed: What|Removed |Added Attachment #165825|0 |1 is obsolete|| --- Comment #8 from Janusz Kaczmarek --- Created attachment 165851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165851&action=edit Bug 36388: Mouse operation does not work in draggable fields in authority editor When using the authority editor in Firefox, it is not possible to set the cursor or select text from the text field. This patch mimics the corrections made in bug 35425 for biblio editor. Test plan: == 1. Start editing an existing authority record and try to put the cursor with the mouse in the middle of the content of any subfield or to select text with the mouse. It should not be possilbe. 2. Apply the patch (reload plack etc.). 3. Repeat p. 1 - everything should work as expected. Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Janusz Kaczmarek changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 --- Comment #7 from Janusz Kaczmarek --- (In reply to Victor Grousset/tuxayo from comment #6) > And then it's possible to solve the duplication of when cloning a field in > cataloging.js. > Because that part has the same code as initializeSortable() Victor, thank you for your remark. I'm submitting a corrected version following your suggestion--for your evaluation. The strange thing is, however, that we do not notice any latency when highlighting strings after a click... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Victor Grousset/tuxayo changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net |y.org | CC||vic...@tuxayo.net Status|Signed Off |Failed QA --- Comment #6 from Victor Grousset/tuxayo --- The first attempt, the selected text in a subfield has a 1 second latency before highlighting text selected. (auth and biblios so it's from Bug 35383) That's weird but not blocking. (In reply to Andrii Nugged from comment #3) > Note: there was related issue: Bug 35383, solved differently, but I think we > should analyze how to make "common", unified solution with same coding style Good point, I had issues testing and when it worked, I forgot about this and attached a second signoff (it's just a 2nd signoff, it's valid). Back to this remark, for QA that's an issue because copying the change of bug 35425 is introducing duplication. initializeSortable() is totally duplicated and even the calls to it would benefit from being in the same place for biblios and auths to be sure that if those for on editor are changed, the others are. cataloging.js is included in addbiblio.tt and authorities.tt so unless something unexpected, moving the js change from addbiblio.tt and authorities.tt to cataloging.js should work. And then it's possible to solve the duplication of when cloning a field in cataloging.js. Because that part has the same code as initializeSortable() I don't know if it was noticed in bug 35425 that duplication was introduced, but it was it might have been ok to not bother. But now it's a third time duplication, see rule of three: https://en.wikipedia.org/wiki/Rule_of_three_(computer_programming) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #163652|0 |1 is obsolete|| --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 165825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165825&action=edit Bug 36388: Mouse operation does not work in draggable fields in authority editor When using the authority editor in Firefox, it is not possible to set the cursor or select text from the text field. This patch mimics the corrections made in bug 35425 for biblio editor. Test plan: == 1. Start editing an existing authority record and try to put the cursor with the mouse in the middle of the content of any subfield or to select text with the mouse. It should not be possilbe. 2. Apply the patch (reload plack etc.). 3. Repeat p. 1 - everything should work as expected. Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com --- Comment #4 from Esther Melander --- Also referencing Bug 36324, which I should have referenced was happening in a Chrome based browser. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Andrii Nugged changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36324 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 --- Comment #3 from Andrii Nugged --- Note: there was related issue: Bug 35383, solved differently, but I think we should analyze how to make "common", unified solution with same coding style -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Andrii Nugged changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35383 CC||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Lucas Gass changed: What|Removed |Added Attachment #163633|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 163652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163652&action=edit Bug 36388: Mouse operation does not work in draggable fields in authority editor When using the authority editor in Firefox, it is not possible to set the cursor or select text from the text field. This patch mimics the corrections made in bug 35425 for biblio editor. Test plan: == 1. Start editing an existing authority record and try to put the cursor with the mouse in the middle of the content of any subfield or to select text with the mouse. It should not be possilbe. 2. Apply the patch (reload plack etc.). 3. Repeat p. 1 - everything should work as expected. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Janusz Kaczmarek changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |janus...@gmail.com |ity.org | --- Comment #1 from Janusz Kaczmarek --- Created attachment 163633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163633&action=edit Bug 36388: Mouse operation does not work in draggable fields in authority editor When using the authority editor in Firefox, it is not possible to set the cursor or select text from the text field. This patch mimics the corrections made in bug 35425 for biblio editor. Test plan: == 1. Start editing an existing authority record and try to put the cursor with the mouse in the middle of the content of any subfield or to select text with the mouse. It should not be possilbe. 2. Apply the patch (reload plack etc.). 3. Repeat p. 1 - everything should work as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
