[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in|| CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|24.05.00|24.05.00,23.11.06 released in|| Status|Pushed to main |Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 --- Comment #4 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Passed QA --- Comment #3 from Nick Clemens --- Trivial update - we aren't handling the error, so waiting will appear the same, but it may succeed now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Nick Clemens changed: What|Removed |Added Attachment #164099|0 |1 is obsolete|| --- Comment #2 from Nick Clemens --- Created attachment 164125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164125&action=edit Bug 36461: Advanced editor should disable RequireJS timeout with waitSeconds: 0 We aren't actually doing any error handling with the RequireJS waitSeconds config, just leaving the advanced editor hanging on loading if it times out, so instead we should disable it. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Load the Cataloging module home page in Firefox and open Firefox's Web Developer Tools, and in the Network tab change from "No Throttling" to "Regular 2G" 3. In the Cataloging page, click Advanced editor, and watch it attempt to load for 30 seconds, followed by a setTimout error in the devtools console, and then wait as long as you can stand for anything but the "Loading, please wait..." to happen in the web page. Nothing ever will. 4. Apply the patch, restart, set EnableAdvancedCatalogingEditor back to Enable, turn throttling on, load the Advanced editor again, and note that even though it will take a minute or more to load through the throttling, the editor does actually load. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 --- Comment #1 from Phil Ringnalda --- Created attachment 164099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164099&action=edit Bug 36461: Advanced editor should disable RequireJS timeout with waitSeconds: 0 We aren't actually doing any error handling with the RequireJS waitSeconds config, just leaving the advanced editor hanging on loading if it times out, so instead we should disable it. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Load the Cataloging module home page in Firefox and open Firefox's Web Developer Tools, and in the Network tab change from "No Throttling" to "Regular 2G" 3. In the Cataloging page, click Advanced editor, and watch it attempt to load for 30 seconds, followed by a setTimout error in the devtools console, and then wait as long as you can stand for anything but the "Loading, please wait..." to happen in the web page. Nothing ever will. 4. Apply the patch, restart, set EnableAdvancedCatalogingEditor back to Enable, turn throttling on, load the Advanced editor again, and note that even though it will take a minute or more to load through the throttling, the editor does actually load. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Phil Ringnalda changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
