[Koha-bugs] [Bug 36502] Independent branches should not prevent holds if canreservefromotherbranches is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36502 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- Sorry Laura, there's a little more work needed here. We're missing a unit test update (both to fix the failure this introduces and test the new case introduced) * Proving t/db_dependent/Koha/Items.t KO! # Failed test '2 items for hold, filtered by IndependentBranches' # at t/db_dependent/Koha/Items.t line 2068. # got: '6' # expected: '2' # Looks like you failed 1 test of 13. # Failed test 'filter_by_for_hold' # at t/db_dependent/Koha/Items.t line 2078. # Looks like you failed 1 test of 20. t/db_dependent/Koha/Items.t .. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36502] Independent branches should not prevent holds if canreservefromotherbranches is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36502 Esther Melander changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||esther.melander@bywatersolu ||tions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36502] Independent branches should not prevent holds if canreservefromotherbranches is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36502 ByWater Sandboxes changed: What|Removed |Added Attachment #164376|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 164388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164388=edit Bug 36502: Canreservefromotherbranches allows staff to place holds even if independent branches is enabled To test: 1. Enable both the IndependentBranches and canreservefromotherbranches system preferences. 2. Log in to the staff interface with a non-super librarian staff user that has permissions to place holds. 3. Search the catalog for an item. 1. The non-super librarian user should be able to place holds on item from their branch. 2. They should see a “No holds allowed” on items from other branches. 4. Apply the patch and restart_all 5. Repeat step 3 or refresh the page. 1. The non-super librarian can now place holds on items from their branch and other branches. 6. Turn off canreservefromotherbranches 1. The non-super librarian cannot place holds on items from other branches again. 7. Sign off and have a great day! :D Signed-off-by: esther -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36502] Independent branches should not prevent holds if canreservefromotherbranches is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36502 --- Comment #1 from Laura Escamilla --- Created attachment 164376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164376=edit Bug 36502: Canreservefromotherbranches allows staff to place holds even if independent branches is enabled To test: 1. Enable both the IndependentBranches and canreservefromotherbranches system preferences. 2. Log in to the staff interface with a non-super librarian staff user that has permissions to place holds. 3. Search the catalog for an item. 1. The non-super librarian user should be able to place holds on item from their branch. 2. They should see a “No holds allowed” on items from other branches. 4. Apply the patch and restart_all 5. Repeat step 3 or refresh the page. 1. The non-super librarian can now place holds on items from their branch and other branches. 6. Turn off canreservefromotherbranches 1. The non-super librarian cannot place holds on items from other branches again. 7. Sign off and have a great day! :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36502] Independent branches should not prevent holds if canreservefromotherbranches is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36502 Laura Escamilla changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
