[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to CSV doesn't have the total
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585 --- Comment #8 from Michael Hafen --- (In reply to Lucas Gass from comment #7) > Why the following line? > > [% IF ( loopro.hilighted ) %][% ELSE %][% END %] I don't know either, that line was there when I started. I'm guessing it's for table row zebra stripping. Yeah, digging through the history, that line used to toggle a 'hilighted' class, until 17 years ago in commit 1a90d0db7d. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to CSV doesn't have the total
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #7 from Lucas Gass --- Why the following line? [% IF ( loopro.hilighted ) %][% ELSE %][% END %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to CSV doesn't have the total
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585 David Nind changed: What|Removed |Added Attachment #167248|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to CSV doesn't have the total
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585 --- Comment #6 from David Nind --- Created attachment 167251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167251&action=edit Bug 36585: Improve 'Patrons with the most checkouts' report Update the 'Patrons with the most checkouts' report (bor_issues_top.pl) to: 1. Add the total to the CSV output. 2. Change the screen output to only show the patrons name once, instead of for each group by column. 3. Add total check out when output to screen. 4. Change item type group by from biblioitems.itemtype to items.itype. Note: This does not fix the SQL query so that it can run if the database is in strict mode. Test plan: 1. If using koha-testing-docker (KTD), set strict SQL mode for your database to 0 (that is, turn it off). (Edit 0 in /etc/koha/sites/kohadev/koha-conf.xml (and then flush_memcached and restart_all)) 2. Add some data so that a useful report can be generated: . Check out and return some items to different patrons in different libraries: ==> Minimum end result: . two items issued to a patron for one library, 1 item issued and returned for the same patron at another library . one item issued to another patron from another patron category for one of the libraries used previously 3. Generate the report with output to screen with a group by, for example: 'By' option set to Category code 4. Observe that the patron name is repeated for each column group. 5. Observe that there is no total column. 6. Generate the report with output to CSV. 7. Observe that the total checkouts is not in the CSV. 8. Apply the patch and restart Koha (restart_all). 9. Generate the CSV report again. 10. Observe that the total checkouts is in the CSV. 11. Generate the report to screen again. 12. Observe that there is a total column and the patron name is only shown in one column. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to CSV doesn't have the total
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to CSV doesn't have the total
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585 David Nind changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #5 from David Nind --- Changing status back to needs sign off. The commit message needs formatting according to the https://wiki.koha-community.org/wiki/Commit_messages I will update the commit message when I sign it off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to CSV doesn't have the total
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585 Michael Hafen changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to CSV doesn't have the total
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585 Michael Hafen changed: What|Removed |Added Attachment #164782|0 |1 is obsolete|| --- Comment #4 from Michael Hafen --- Created attachment 167248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167248&action=edit improve bor_issues_top report Try the following with and without a group by, specifically item type. 1. Generate the report with output to screen with a group by. 2. Observe that the patron name is repeated for each column group. 3. Observe that there is no total column. 4. Generate the report with output to csv. 5. Observe that the total check outs is not in the csv. 6. Apply patch. restart Koha. 7. Generate the report to csv again. 8. Observe that the total checkouts is in the csv. 9. Generate the report to screen again. 10. Observe that there is a total column and the patron name is only in one column. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to CSV doesn't have the total
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585 David Nind changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |michael.ha...@washk12.org |ity.org | Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #3 from David Nind --- Hi Michael. There doesn't seem to be a patch attached, as far as I can see. I've changed the assignee to yourself. David -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to CSV doesn't have the total
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585 Katrin Fischer changed: What|Removed |Added Summary|Patrons with the most |Patrons with the most |checkouts Report when |checkouts Report when |outputting to csv doesn't |outputting to CSV doesn't |have the total |have the total -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to csv doesn't have the total
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585 Michael Hafen changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #2 from Michael Hafen --- [ The test plan is in the patch, but I forgot to copy it here. ] Try the following with and without a group by, specifically item type. 1. Generate the report with output to screen with a group by. 2. Observe that the patron name is repeated for each column group. 3. Observe that there is no total column. 4. Generate the report with output to csv. 5. Observe that the total check outs is not in the csv. 6. Apply patch. restart Koha. 7. Generate the report to csv again. 8. Observe that the total checkouts is in the csv. 9. Generate the report to screen again. 10. Observe that there is a total column and the patron name is only in one column. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to csv doesn't have the total
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585 --- Comment #1 from Michael Hafen --- Created attachment 164782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164782&action=edit Improve bor_issues_top report -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
