[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 Olivier V changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 Olivier V changed: What|Removed |Added Attachment #171220|0 |1 is obsolete|| --- Comment #29 from Olivier V --- Created attachment 171229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171229&action=edit Bug 36594: Library hours in koha/admin/branches.pl now adhere to selected time and calendar system preferences. -Newly created or edited libraries no longer display 'null' for undefined open and close times. -Libraries without any defined hours will state such instead of displaying the hours table. -The CalendarFirstDayOfWeek system preferences is now respected when viewing a library with defined hours. -Time displays and inputs now follow the TimeFormat system preference. -Times are no longer displayed with seconds. As part of this patch, a new Template Filter, KohaTimes, has been added to allow for proper formatting of time strings based on systems preferences. To Test: 1. Login to staff interface 2. Go to Koha administration > Basic parameters > Libraries 3. Edit any library or create a new library. Do not set hours. 4. Save the library. *Note that on the library list, in the hours column, all days are displayed with 'null'. 5. Edit or create a 2nd library. 6. Try to manually enter a time (not using the flatpickr modal) *Note that the mask wants a date format, not a time format. 7. Set some hours for the library, leaving at least one day without hours. Save. *Note that in the library list, in the hours column, defined times are in the format HH:MM:SS. 7. Edit the system preference CalendarFirstDayOfWeek to set a day other than Sunday as the first day of the week. 8. Return to Koha administration > Basic parameters > Libraries 9. Click on the name of a specific library with hours to view details. *Note that the order of the calendar weeek still starts with Sunday. 10. The order of the calendar week still starts with Sunday. 11. Edit the system preference TimeFormat and set to 12-hours. 12. Return to Koha administration > Basic parameters > Libraries. *Note that the time format on the branches list is not in 12-hour format. 13. Click on the name of a specific library with hours to view details. *Note that the time format in the branch details screen is not in 12-hour format. 14. Apply Patch. 15. Return to Koha administration > Basic parameters > Libraries 16. Verify that your library with all undefined times shows "Library hours not set". 17. Verify that your library with defined hours is showing times in HH:MM format, and days without defined hours are blank. 18. Verify that your library with defined hours is respecting the TimeFormat preferences. 19. Click on the name of a library with hours to view details. 20. Verify that the hours respect the CalendarFirstDayOfWeek and TimeFormat preferences. 21. Click on the name of another library without hours to view details. Verify these libraries show as "No opening hours have been set" in the branch detail view. 22. Edit a library's hours. When inputing, try to manually enter a time (not using the flatpickr modal). Verify that you can enter time in the proper (12 or 24 hours) format. Sponsored-by: Westlake Porter Public Library Signed-off-by: Olivier V -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 CJ Lynce changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #28 from CJ Lynce --- Please try this with Firefox- and Chrome-based browsers. Both should work properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 CJ Lynce changed: What|Removed |Added Attachment #171153|0 |1 is obsolete|| --- Comment #27 from CJ Lynce --- Created attachment 171220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171220&action=edit Bug 36594: Library hours in koha/admin/branches.pl now adhere to selected time and calendar system preferences. -Newly created or edited libraries no longer display 'null' for undefined open and close times. -Libraries without any defined hours will state such instead of displaying the hours table. -The CalendarFirstDayOfWeek system preferences is now respected when viewing a library with defined hours. -Time displays and inputs now follow the TimeFormat system preference. -Times are no longer displayed with seconds. As part of this patch, a new Template Filter, KohaTimes, has been added to allow for proper formatting of time strings based on systems preferences. To Test: 1. Login to staff interface 2. Go to Koha administration > Basic parameters > Libraries 3. Edit any library or create a new library. Do not set hours. 4. Save the library. *Note that on the library list, in the hours column, all days are displayed with 'null'. 5. Edit or create a 2nd library. 6. Try to manually enter a time (not using the flatpickr modal) *Note that the mask wants a date format, not a time format. 7. Set some hours for the library, leaving at least one day without hours. Save. *Note that in the library list, in the hours column, defined times are in the format HH:MM:SS. 7. Edit the system preference CalendarFirstDayOfWeek to set a day other than Sunday as the first day of the week. 8. Return to Koha administration > Basic parameters > Libraries 9. Click on the name of a specific library with hours to view details. *Note that the order of the calendar weeek still starts with Sunday. 10. The order of the calendar week still starts with Sunday. 11. Edit the system preference TimeFormat and set to 12-hours. 12. Return to Koha administration > Basic parameters > Libraries. *Note that the time format on the branches list is not in 12-hour format. 13. Click on the name of a specific library with hours to view details. *Note that the time format in the branch details screen is not in 12-hour format. 14. Apply Patch. 15. Return to Koha administration > Basic parameters > Libraries 16. Verify that your library with all undefined times shows "Library hours not set". 17. Verify that your library with defined hours is showing times in HH:MM format, and days without defined hours are blank. 18. Verify that your library with defined hours is respecting the TimeFormat preferences. 19. Click on the name of a library with hours to view details. 20. Verify that the hours respect the CalendarFirstDayOfWeek and TimeFormat preferences. 21. Click on the name of another library without hours to view details. Verify these libraries show as "No opening hours have been set" in the branch detail view. 22. Edit a library's hours. When inputing, try to manually enter a time (not using the flatpickr modal). Verify that you can enter time in the proper (12 or 24 hours) format. Sponsored-by: Westlake Porter Public Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 CJ Lynce changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #26 from CJ Lynce --- Thanks Oliver, that's helpful and makes sense (the library list was originally done in JavaScript, while the individual view uses template toolkit). Let me work on correction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #25 from Olivier V --- (In reply to Olivier V from comment #24) > Created attachment 171213 [details] > Sql results libraries_hours The problem seems to be coming from the firefox browser since it'S a bit picky on date format. I tried the fix once more but with the chrome browser this time and everything worked fine. For firefox i tested with every dateformat and timeformat and i still got the same result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #24 from Olivier V --- Created attachment 171213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171213&action=edit Sql results libraries_hours -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #23 from CJ Lynce --- Hi Oliver, thanks for testing! I'm Having trouble tracking that one down. Could you share the following for your test case: A) Your open and close times inputs for your library. B) Your TimeFormat system pref setting (12 or 24 hours) C) Your region's date format (dd/mm/, -dd-mm, etc.) D) If possible, create a SQL report 'SELECT* FROM library_hours' and attach the results (or feel free to email it to me) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 Olivier V changed: What|Removed |Added CC||ovez...@inlibro.com --- Comment #22 from Olivier V --- Everything works as intended except in the libraries table where the dates comes out as "invalid Date" while in the specific view of the library the date appear in the right format and time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 CJ Lynce changed: What|Removed |Added Attachment #171152|0 |1 is obsolete|| --- Comment #21 from CJ Lynce --- Created attachment 171153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171153&action=edit Bug 36594: Library hours in koha/admin/branches.pl now adhere to selected time and calendar system preferences. -Newly created or edited libraries no longer display 'null' for undefined open and close times. -Libraries without any defined hours will state such instead of displaying the hours table. -The CalendarFirstDayOfWeek system preferences is now respected when viewing a library with defined hours. -Time displays and inputs now follow the TimeFormat system preference. -Times are no longer displayed with seconds. As part of this patch, a new Template Filter, KohaTimes, has been added to allow for proper formatting of time strings based on systems preferences. To Test: 1. Login to staff interface 2. Go to Koha administration > Basic parameters > Libraries 3. Edit any library or create a new library. Do not set hours. 4. Save the library. *Note that on the library list, in the hours column, all days are displayed with 'null'. 5. Edit or create a 2nd library. 6. Try to manually enter a time (not using the flatpickr modal) *Note that the mask wants a date format, not a time format. 7. Set some hours for the library, leaving at least one day without hours. Save. *Note that in the library list, in the hours column, defined times are in the format HH:MM:SS. 7. Edit the system preference CalendarFirstDayOfWeek to set a day other than Sunday as the first day of the week. 8. Return to Koha administration > Basic parameters > Libraries 9. Click on the name of a specific library with hours to view details. *Note that the order of the calendar weeek still starts with Sunday. 10. The order of the calendar week still starts with Sunday. 11. Edit the system preference TimeFormat and set to 12-hours. 12. Return to Koha administration > Basic parameters > Libraries. *Note that the time format on the branches list is not in 12-hour format. 13. Click on the name of a specific library with hours to view details. *Note that the time format in the branch details screen is not in 12-hour format. 14. Apply Patch. 15. Return to Koha administration > Basic parameters > Libraries 16. Verify that your library with all undefined times shows "Library hours not set". 17. Verify that your library with defined hours is showing times in HH:MM format, and days without defined hours are blank. 18. Verify that your library with defined hours is respecting the TimeFormat preferences. 19. Click on the name of a library with hours to view details. 20. Verify that the hours respect the CalendarFirstDayOfWeek and TimeFormat preferences. 21. Click on the name of another library without hours to view details. Verify these libraries show as "No opening hours have been set" in the branch detail view. 22. Edit a library's hours. When inputing, try to manually enter a time (not using the flatpickr modal). Verify that you can enter time in the proper (12 or 24 hours) format. Sponsored-by: Westlake Porter Public Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #20 from CJ Lynce --- Here's and update patch that addresses a myriad of display issues brought up in Comment 1, 12, and 15, with the exception of the topics in bug_36079 (integrating the calendar and hours better) and bug_37662 (string changes) I added a new KohaTimes filter for TT to handle the 12/24 hour formatting (KohaDates does not handle time-only inputs) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 CJ Lynce changed: What|Removed |Added Text to go in the|This fixes the display of |This fixes the display of release notes|library hours in the staff |library hours in the staff |interface (Administration > |interface (Administration > |Basic parameters > |Basic parameters > |Libraries): |Libraries): |- If there are |This patch |no opening and closing |corrects the following |times entered for all the |issues related to the |days of the week, then the |display of library |library hours column|-Newly |displays as "Library hours |created or edited libraries |not set" (instead of|no longer display 'null' |displaying a table with all |for undefined open and |the days and null for each |close times. |time; editing the library, |-Libraries |without entering any times, |without any defined hours |was also displaying the |will state such instead of |table). |displaying the hours table. |- If no values are |-The CalendarFirstDayOfWeek |entered for a day's opening |system preferences is now |and closing times, the |respected when viewing a |library is considered |library with defined hours. |closed and now displays as |-Time displays and inputs |"Closed" for the day|now follow the TimeFormat |(instead of displaying |system preference. |null). |-Times |- The opening and |are no longer displayed |closing times are now |with seconds. |displayed in the format |-A TT filter, |HH:MM (instead of |KohaTimes, has been added |HH:MM:SS). |to handle proper formatting |- The |of time strings based on |CalendarFirstDayOfWeek |systems preferences. |system preference is now| |used when viewing a library | |with opening and closing| |times set (instead of | |always displaying Sunday as | |the first day of the week). | Status|Failed QA |Needs Signoff --- Comment #19 from CJ Lynce --- Here's and update patch that addresses a myriad of display issues brought up in Comment 1, 12, and 15, with the exception of the topics in bug_36079 (integrating the calendar and hours better) and bug_37662 (string changes) I added a new KohaTimes filter for TT to handle the 12/24 hour formatting (KohaDates does not handle time-only inputs) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 CJ Lynce changed: What|Removed |Added Attachment #170460|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #18 from CJ Lynce --- Created attachment 171152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171152&action=edit Bug 36594: Library hours in koha/admin/branches.pl now adhere to selected time and calendar system preferences. -Newly created or edited libraries no longer display 'null' for undefined open and close times. -Libraries without any defined hours will state such instead of displaying the hours table. -The CalendarFirstDayOfWeek system preferences is now respected when viewing a library with defined hours. -Time displays and inputs now follow the TimeFormat system preference. -Times are no longer displayed with seconds. As part of this patch, a new Template Filter, KohaTimes, has been added to allow for proper formatting of time strings based on systems preferences. To Test: 1. Login to staff interface 2. Go to Koha administration > Basic parameters > Libraries 3. Edit any library or create a new library. Do not set hours. 4. Save the library. *Note that on the library list, in the hours column, all days are displayed with 'null'. 5. Edit or create a 2nd library. 6. Try to manually enter a time (not using the flatpickr modal) *Note that the mask wants a date format, not a time format. 7. Set some hours for the library, leaving at least one day without hours. Save. *Note that in the library list, in the hours column, defined times are in the format HH:MM:SS. 7. Edit the system preference CalendarFirstDayOfWeek to set a day other than Sunday as the first day of the week. 8. Return to Koha administration > Basic parameters > Libraries 9. Click on the name of a specific library with hours to view details. *Note that the order of the calendar weeek still starts with Sunday. 10. The order of the calendar week still starts with Sunday. 11. Edit the system preference TimeFormat and set to 12-hours. 12. Return to Koha administration > Basic parameters > Libraries. *Note that the time format on the branches list is not in 12-hour format. 13. Click on the name of a specific library with hours to view details. *Note that the time format in the branch details screen is not in 12-hour format. 14. Apply Patch. 15. Return to Koha administration > Basic parameters > Libraries 16. Verify that your library with all undefined times shows "Library hours not set". 17. Verify that your library with defined hours is showing times in HH:MM format, and days without defined hours are blank. 18. Verify that your library with defined hours is respecting the TimeFormat preferences. 19. Click on the name of a library with hours to view details. 20. Verify that the hours respect the CalendarFirstDayOfWeek and TimeFormat preferences. 21. Click on the name of another library without hours to view details. Verify these libraries show as "No opening hours have been set" in the branch detail view. 22. Edit a library's hours. When inputing, try to manually enter a time (not using the flatpickr modal). Verify that you can enter time in the proper (12 or 24 hours) format. Sponsored-by: Westlake Porter Public Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #17 from CJ Lynce --- Thanks for the feedback. I agree that better integration with the calendar is ultimately needed, and I'll list my thoughts on that over on bug_36079. Limiting the fix for this bug to resolving the 'null' display issue that appears when you edit or add a library is a fairly basic fix compared to appropriately pulling in calendar data so that it relates to 'regular hours'. (The 'null matrix that shows when no hours are defined for the library is a massive space waster for systems with many libraries). I will look at respecting the time format when displaying, though if going the route of creating a KohaTimes.pm filter, that is a bit above my skills wheelhouse still, but I'm willing to give it a shot with some guidance? Related to dates without hours defined, leaving them blank rather than 'Closed' is probably a better option, and again focuses on display/formatting issues. I'd posit taking this small bite out here, then taking the larger work of integration on bug_36079. Thoughts? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #16 from Martin Renvoize --- To get the time format correct we probably want a Koha/Template/Plugin/KohaTimes.pm template filter adding. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #15 from Martin Renvoize --- This is a good start.. though I feel it can be misleading right now. I'd really like to see calendar taken into account so we're not marking 24 hour opening days as Closed and rather actually using the regular closed days for marking Closed. I also see we're not formatting the times as per the system preference yet. I'm afraid it's a fail for me.. whilst I'm keen to see this fixed I think we need to go further. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #14 from CJ Lynce --- I suspect 1. & 2. are due to config issues with the use of flatpickr for time only. Manually typing in a time formats as a date when you try specify minutes or an hour larger than 12. This appears to be the only place flatpickr is configured to just do time and not date only or date&time. 3. may or may not be flatpickr, as it looks like the current code (koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc) is trying to honor the 24 or 12 hour system variable. I'm going to try to get new bugs opened for this later today, unless someone beats me to them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #13 from Katrin Fischer --- I wonder if 1. might also depend on some local settings. Would you mind filing these separately? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=37662 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 David Nind changed: What|Removed |Added Blocks||37662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37662 [Bug 37662] Library information - text inconsistencies between the table, edit form, and display page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 David Nind changed: What|Removed |Added Text to go in the||This fixes the display of release notes||library hours in the staff ||interface (Administration > ||Basic parameters > ||Libraries): ||- If there are ||no opening and closing ||times entered for all the ||days of the week, then the ||library hours column ||displays as "Library hours ||not set" (instead of ||displaying a table with all ||the days and null for each ||time; editing the library, ||without entering any times, ||was also displaying the ||table). ||- If no values are ||entered for a day's opening ||and closing times, the ||library is considered ||closed and now displays as ||"Closed" for the day ||(instead of displaying ||null). ||- The opening and ||closing times are now ||displayed in the format ||HH:MM (instead of ||HH:MM:SS). ||- The ||CalendarFirstDayOfWeek ||system preference is now ||used when viewing a library ||with opening and closing ||times set (instead of ||always displaying Sunday as ||the first day of the week). --- Comment #12 from David Nind --- Thank you for providing a patch to fix this! I've added a draft release note - feel free to update it if I haven't got it right. Some other things I noted - for fixing on other bugs: 1. Entering the time manually: you can only manually enter the time up to 12 in either of the open or close time input fields (irrespective of the TimeFormat system preference) - for example, for the close time column you can't manually enter 14:00 (you can select it from the input control) 2. When editing the opening and closing times, if you select the X it then displays the date picker. 3. Using the TimeFormat system preference: the selector takes this system preference into account, but then displays the time using 24 hours (for example: entering 4:00 PM as the closing time displays as 16:00). 4. Text inconsistencies - I have created bug 37662 for these: 4.1 If no library opening and closing times are set, it displays in the library hours column as "Library hours not set". However, if you view the library details (selecting the library name in the name column), the text is "No opening hours have been set." 4.2 The column name in the list of libraries is "Library hours". However, if you view the library details (selecting the library name in the name column), the field label is "Opening hours". "Opening hours" is also used as the field label when adding and editing library information. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 David Nind changed: What|Removed |Added Attachment #170298|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 170460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170460&action=edit Bug 36594: Library hours display issues The following issues existing when displays library hours in koha/admin/branches.pl -For newly created or edited libraries, 'null' is displayed when that time is undefined. -Time is displayed with seconds, which are not necessary. -The system preference CalendarFirstDayOfWeek is not respected when viewing a specific library with hours defined. This patch corrects these issues: -Undefined values are properly handled. All open & close times are undefined, the library is considered as not having hours set. -If open and close times for a day are both undefined, the library is considered closed. -Time is now displayed in the format HH:MM -CalendarFirstDayOfWeek is respected when viewing a library with defined hours. To Test: 1. Login to staff interface 2. Go to Koha administration > Basic parameters > Libraries 3. Edit any library or create a new library. Do not set hours. Save. 4. On the library list, in the hours column, all days are displayed with null. 5. Edit or create a 2nd library, set some hours, leaving at least one day without hours. Save. 6. In the library list, in the hours column, defined times are in the format HH:MM:SS. 7. Edit the system preference CalendarFirstDayOfWeek to set a day other than Sunday as the first day of the week. 8. Return to Go to Koha administration > Basic parameters > Libraries 9. Click on the name of a specific library with hours to view details. 10. The order of the calendar week still starts with Sunday. 11. Apply Patch. 12. Return to Go to Koha administration > Basic parameters > Libraries 13. Check that your library with all undefined times shows "Library hours not set". 14. Check that your library with defined hours is showing times in HH:MM format, and days without defined hours are "Closed". 15. Click on the name of a library with hours to view details. Verify that the calendar week starts respects CalendarFirstDayOfWeek. 16. Click on the name of another library without hours to view details. Verify these libraries show as "No opening hours have been set" in the branch detail view. Sponsored-by: Westlake Porter Public Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 CJ Lynce changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #10 from CJ Lynce --- Katrin, that makes sense to keep this bug focused on getting the currently collected data to display correctly. In that case, the submitted the patch should cover it. I'll do some additional digging to better understand how open and closed hours are used/not used, and open another bug for functionality changes. Bug 36079 will likely tie into an ideal solution with this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 Katrin Fischer changed: What|Removed |Added Status|In Discussion |ASSIGNED --- Comment #9 from Katrin Fischer --- Hi CJ, I feel these are all great questions, but I wonder if we should not split them to a separate bug as this was mostly to deal with the display issues, not affecting the functionality. Do you agree? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 CJ Lynce changed: What|Removed |Added Patch complexity|--- |Small patch CC||cj.ly...@westlakelibrary.or ||g Assignee|koha-b...@lists.koha-commun |cj.ly...@westlakelibrary.or |ity.org |g Status|NEW |In Discussion --- Comment #8 from CJ Lynce --- Please take a look at a first try at addressing the issues here. The following assumptions/decisions apply: A) Days with both open and close times undefined are considered 'CLOSED'. B) It might be possible to have a library open one day and close the next? This would mean that an opening time is defined, but a closing time is not for one day, and a closing time defined for the next day, but no opening time. Regarding B) The more I think about this, I don't think this is going to work well. If a library opened on a Monday, and remained opened straight through to Wednesday, Tuesday would shows as closed since both times are undefined. I also don't have a great understanding yet of all the places these times are used (e.g. calculating due dates/times, or displaying in the OPAC?), but I would imagine allowing and opening time, and no closing time for a day would cause problems? I think a better way would be to require BOTH open and close times for a day for it to be considered valid. If a library is opening spanning days, do it 'close' at 23:59, and open at 0:00 the next day? I welcome any comments on these thoughts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #7 from CJ Lynce --- Created attachment 170298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170298&action=edit Bug 36594: Library hours display issues The following issues existing when displays library hours in koha/admin/branches.pl -For newly created or edited libraries, 'null' is displayed when that time is undefined. -Time is displayed with seconds, which are not necessary. -The system preference CalendarFirstDayOfWeek is not respected when viewing a specific library with hours defined. This patch corrects these issues: -Undefined values are properly handled. All open & close times are undefined, the library is considered as not having hours set. -If open and close times for a day are both undefined, the library is considered closed. -Time is now displayed in the format HH:MM -CalendarFirstDayOfWeek is respected when viewing a library with defined hours. To Test: 1. Login to staff interface 2. Go to Koha administration > Basic parameters > Libraries 3. Edit any library or create a new library. Do not set hours. Save. 4. On the library list, in the hours column, all days are displayed with null. 5. Edit or create a 2nd library, set some hours, leaving at least one day without hours. Save. 6. In the library list, in the hours column, defined times are in the format HH:MM:SS. 7. Edit the system preference CalendarFirstDayOfWeek to set a day other than Sunday as the first day of the week. 8. Return to Go to Koha administration > Basic parameters > Libraries 9. Click on the name of a specific library with hours to view details. 10. The order of the calendar week still starts with Sunday. 11. Apply Patch. 12. Return to Go to Koha administration > Basic parameters > Libraries 13. Check that your library with all undefined times shows "Library hours not set". 14. Check that your library with defined hours is showing times in HH:MM format, and days without defined hours are "Closed". 15. Click on the name of a library with hours to view details. Verify that the calendar week starts respects CalendarFirstDayOfWeek. 16. Click on the name of another library without hours to view details. Verify these libraries show as "No opening hours have been set" in the branch detail view. Sponsored-by: Westlake Porter Public Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36079 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #6 from David Nind --- Thanks Caroline! I didn't know about the CalendarFirstDayOfWeek system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 Bug 36594 depends on bug 6796, which changed state. Bug 6796 Summary: Overnight checkouts taking into account opening and closing hours https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #5 from Caroline Cyr La Rose --- (In reply to Caroline Cyr La Rose from comment #4) > (In reply to David Nind from comment #3) > > > 3. Option to organise the order of the day column - displays as Sunday to > > Monday, which I think is an American convention. Here in New Zealand, the > > first day of the week is Monday. > > There is a system preference, CalendarFirstDayOfWeek, that determines the > first day of the week. I tried changing it to Wednesday and the days are > rearranged in the library display. So I think this part is OK. I retract that statement, it is not 100% OK. The hours table in the main library table (the first one when you go to Administration > Libraries) is subject to CalendarFirstDayOfWeek. The one in the form (new library or edit existing) is also OK. BUT if you click on the name of the library, the days table is displayed with Sunday first regardless of CalendarFirstDayOfWeek. So it's 66% OK ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #4 from Caroline Cyr La Rose --- (In reply to David Nind from comment #3) > 3. Option to organise the order of the day column - displays as Sunday to > Monday, which I think is an American convention. Here in New Zealand, the > first day of the week is Monday. There is a system preference, CalendarFirstDayOfWeek, that determines the first day of the week. I tried changing it to Wednesday and the days are rearranged in the library display. So I think this part is OK. I agree with all the rest and would add (although that might be Tomás' first point) to display the text "Library hours not set" if everything is null. In KTD, and I assume in other existing systems, all the libraries currently show as "Library hours not set" in the main branches table. But if you create a new library, or edit an existing library, the table with 'null' everywhere appears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- I can confirm the display issues. To replicate: 1. Go to Koha administration > Basic parameters > Libraries 2. Edit any library. 3. Submit (without making any changes). 4. In the library hours column, all days are displayed with null 5. If you select a time for opening or closing, it displays with seconds, for example: 08:00:00 In addition, I have these suggestions (maybe separate bugs?): 1. Column headings: maybe change 'Open time' and 'Close time' to 'Opens' and 'Closes'. Or maybe 'Opening time' and 'Closing time' - realising that column width is at a premium, and not sure how this affects translation. 2. Option to select that the library is closed for the day, and displays in the table as 'Closed' 3. Option to organise the order of the day column - displays as Sunday to Monday, which I think is an American convention. Here in New Zealand, the first day of the week is Monday. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 Jonathan Druart changed: What|Removed |Added CC||alei...@catalyst.net.nz, ||jonathan.dru...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #2 from Martin Renvoize --- This is one of the things I was getting at when I said we really need to link the closed days and the opening hours functionalities.. For regular closed days we shouldn't display opening hours at all.. just mark the whole day as closed in that row. The other time output I would be keen to have fixed too and agree. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 --- Comment #1 from Katrin Fischer --- +1 thank you for filing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Depends on||6796 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 [Bug 6796] Overnight checkouts taking into account opening and closing hours -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
