[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #147 from Victor Grousset/tuxayo --- > Didn't we have both the "search header" (select all, etc.) and the table > header (thead) sticky at some point? Good finding! confirmed for 22.11, 23.05, 23.11 main, 24.05 doesn't have it. opened bug 37992 since it's not caused by removal of HC Sticky -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #146 from Jonathan Druart --- 3. Do a patron search, the toolbar should stick as you scroll down. Didn't we have both the "search header" (select all, etc.) and the table header (thead) sticky at some point? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #145 from Victor Grousset/tuxayo --- (In reply to Owen Leonard from comment #128) > Since those templates are unchanged and there have never been floating > toolbars on those pages I think there is nothing to test on those pages. Great, no issue then! :D Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171095|0 |1 is obsolete|| --- Comment #144 from Victor Grousset/tuxayo --- Created attachment 171867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171867&action=edit Bug 36694: Remove HC sticky from js/results-list.js It got moved there by bug-36557 after the patches here were written. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171094|0 |1 is obsolete|| --- Comment #143 from Victor Grousset/tuxayo --- Created attachment 171866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171866&action=edit Bug 36694: (follow-up) Remove some missed instances This patch removes some missed HCSticky code/mentions as well as the entry on the About page. Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171093|0 |1 is obsolete|| --- Comment #142 from Victor Grousset/tuxayo --- Created attachment 171865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171865&action=edit Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171092|0 |1 is obsolete|| --- Comment #141 from Victor Grousset/tuxayo --- Created attachment 171864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171864&action=edit Bug 36694: (follow-up): fix pages where toolbar was not sticky Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171091|0 |1 is obsolete|| --- Comment #140 from Victor Grousset/tuxayo --- Created attachment 171863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171863&action=edit Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171090|0 |1 is obsolete|| --- Comment #139 from Victor Grousset/tuxayo --- Created attachment 171862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171862&action=edit Bug 36694: Remove HC sticky from OPAC pages Rebased-by: Victor Grousset/tuxayo Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171089|0 |1 is obsolete|| --- Comment #138 from Victor Grousset/tuxayo --- Created attachment 171861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171861&action=edit Bug 36694: Remove HC sticky from remaining staff pages Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171088|0 |1 is obsolete|| --- Comment #137 from Victor Grousset/tuxayo --- Created attachment 171860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171860&action=edit Bug 36694: Remove HC sticky from members/ pages Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171087|0 |1 is obsolete|| --- Comment #136 from Victor Grousset/tuxayo --- Created attachment 171859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171859&action=edit Bug 36694: Remove HC stikcy from cataloguing/ pages Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171086|0 |1 is obsolete|| --- Comment #135 from Victor Grousset/tuxayo --- Created attachment 171858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171858&action=edit Bug 36694: Remove HC sticky from catalogue/ pages Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171085|0 |1 is obsolete|| --- Comment #134 from Victor Grousset/tuxayo --- Created attachment 171857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171857&action=edit Bug 36694: Remove HC sticky from preferences.tt/authorities.tt Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171084|0 |1 is obsolete|| --- Comment #133 from Victor Grousset/tuxayo --- Created attachment 171856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171856&action=edit Bug 36694: Remove HC sticky from acqui/supplier.tt Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171083|0 |1 is obsolete|| --- Comment #132 from Victor Grousset/tuxayo --- Created attachment 171855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171855&action=edit Bug 36694: Set sticky element top to -1px Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171082|0 |1 is obsolete|| --- Comment #131 from Victor Grousset/tuxayo --- Created attachment 171854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171854&action=edit Bug 36694: Add JS observer to detect stuck sticky element Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171081|0 |1 is obsolete|| --- Comment #130 from Victor Grousset/tuxayo --- Created attachment 171853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171853&action=edit Bug 36694: Remove HC sticky from acqui/basket.tt Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #171080|0 |1 is obsolete|| --- Comment #129 from Victor Grousset/tuxayo --- Created attachment 171852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171852&action=edit Bug 36694: Remove HC sticky from patron search searchbar Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #128 from Owen Leonard --- Since those templates are unchanged and there have never been floating toolbars on those pages I think there is nothing to test on those pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net |y.org | --- Comment #127 from Victor Grousset/tuxayo --- I think the only remaining thing to get to passed QA is the finding in Comment 110. Whether there is still something to test in moremember.pl and circulation.pl. Or maybe there is a regression that broke the stickiness in these pages after the test plan here was written. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #125 from Owen Leonard --- Created attachment 171094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171094&action=edit Bug 36694: (follow-up) Remove some missed instances This patch removes some missed HCSticky code/mentions as well as the entry on the About page. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #126 from Owen Leonard --- Created attachment 171095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171095&action=edit Bug 36694: Remove HC sticky from js/results-list.js It got moved there by bug-36557 after the patches here were written. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #124 from Owen Leonard --- Created attachment 171093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171093&action=edit Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #123 from Owen Leonard --- Created attachment 171092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171092&action=edit Bug 36694: (follow-up): fix pages where toolbar was not sticky Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #122 from Owen Leonard --- Created attachment 171091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171091&action=edit Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #121 from Owen Leonard --- Created attachment 171090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171090&action=edit Bug 36694: Remove HC sticky from OPAC pages Rebased-by: Victor Grousset/tuxayo Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #119 from Owen Leonard --- Created attachment 171088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171088&action=edit Bug 36694: Remove HC sticky from members/ pages Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #118 from Owen Leonard --- Created attachment 171087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171087&action=edit Bug 36694: Remove HC stikcy from cataloguing/ pages Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #120 from Owen Leonard --- Created attachment 171089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171089&action=edit Bug 36694: Remove HC sticky from remaining staff pages Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #116 from Owen Leonard --- Created attachment 171085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171085&action=edit Bug 36694: Remove HC sticky from preferences.tt/authorities.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #117 from Owen Leonard --- Created attachment 171086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171086&action=edit Bug 36694: Remove HC sticky from catalogue/ pages Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #114 from Owen Leonard --- Created attachment 171083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171083&action=edit Bug 36694: Set sticky element top to -1px Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #112 from Owen Leonard --- Created attachment 171081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171081&action=edit Bug 36694: Remove HC sticky from acqui/basket.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #115 from Owen Leonard --- Created attachment 171084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171084&action=edit Bug 36694: Remove HC sticky from acqui/supplier.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Owen Leonard changed: What|Removed |Added Attachment #169110|0 |1 is obsolete|| Attachment #169111|0 |1 is obsolete|| Attachment #169112|0 |1 is obsolete|| Attachment #169113|0 |1 is obsolete|| Attachment #169114|0 |1 is obsolete|| Attachment #169115|0 |1 is obsolete|| Attachment #169116|0 |1 is obsolete|| Attachment #169117|0 |1 is obsolete|| Attachment #169118|0 |1 is obsolete|| Attachment #169119|0 |1 is obsolete|| Attachment #169120|0 |1 is obsolete|| Attachment #169121|0 |1 is obsolete|| Attachment #169122|0 |1 is obsolete|| Attachment #169123|0 |1 is obsolete|| Attachment #169124|0 |1 is obsolete|| Attachment #169125|0 |1 is obsolete|| --- Comment #111 from Owen Leonard --- Created attachment 171080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171080&action=edit Bug 36694: Remove HC sticky from patron search searchbar Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #113 from Owen Leonard --- Created attachment 171082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171082&action=edit Bug 36694: Add JS observer to detect stuck sticky element Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #110 from Victor Grousset/tuxayo --- > 13. Try each of the other members pages like memberentry.pl, >moremember.pl, circulation.pl. On each of the pages the toolbar >should stick. moremember.pl, circulation.pl => nope but neither on main Was there something about this or can this be skipped? Additional testing: - marc21_field_008 cataloguing plugin - label batch content - patron card creator batch content -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #109 from Victor Grousset/tuxayo --- Rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #108 from Victor Grousset/tuxayo --- Created attachment 169125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169125&action=edit Bug 36694: Remove HC sticky from js/results-list.js It got moved there by bug-36557 after the patches here were written. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167837|0 |1 is obsolete|| --- Comment #107 from Victor Grousset/tuxayo --- Created attachment 169124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169124&action=edit Bug 36694: (follow-up) Remove some missed instances This patch removes some missed HCSticky code/mentions as well as the entry on the About page. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167836|0 |1 is obsolete|| --- Comment #106 from Victor Grousset/tuxayo --- Created attachment 169123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169123&action=edit Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167835|0 |1 is obsolete|| --- Comment #105 from Victor Grousset/tuxayo --- Created attachment 169122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169122&action=edit Bug 36694: (follow-up): fix pages where toolbar was not sticky Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167834|0 |1 is obsolete|| --- Comment #104 from Victor Grousset/tuxayo --- Created attachment 169121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169121&action=edit Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167833|0 |1 is obsolete|| --- Comment #103 from Victor Grousset/tuxayo --- Created attachment 169120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169120&action=edit Bug 36694: Remove HC sticky from OPAC pages Rebased-by: Victor Grousset/tuxayo Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167832|0 |1 is obsolete|| --- Comment #102 from Victor Grousset/tuxayo --- Created attachment 169119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169119&action=edit Bug 36694: Remove HC sticky from remaining staff pages Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167831|0 |1 is obsolete|| --- Comment #101 from Victor Grousset/tuxayo --- Created attachment 169118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169118&action=edit Bug 36694: Remove HC sticky from members/ pages Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167830|0 |1 is obsolete|| --- Comment #100 from Victor Grousset/tuxayo --- Created attachment 169117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169117&action=edit Bug 36694: Remove HC stikcy from cataloguing/ pages Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167829|0 |1 is obsolete|| --- Comment #99 from Victor Grousset/tuxayo --- Created attachment 169116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169116&action=edit Bug 36694: Remove HC sticky from catalogue/ pages Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167828|0 |1 is obsolete|| --- Comment #98 from Victor Grousset/tuxayo --- Created attachment 169115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169115&action=edit Bug 36694: Remove HC sticky from preferences.tt/authorities.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167827|0 |1 is obsolete|| --- Comment #97 from Victor Grousset/tuxayo --- Created attachment 169114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169114&action=edit Bug 36694: Remove HC sticky from acqui/supplier.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167826|0 |1 is obsolete|| --- Comment #96 from Victor Grousset/tuxayo --- Created attachment 169113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169113&action=edit Bug 36694: Set sticky element top to -1px Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167825|0 |1 is obsolete|| --- Comment #95 from Victor Grousset/tuxayo --- Created attachment 169112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169112&action=edit Bug 36694: Add JS observer to detect stuck sticky element Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167824|0 |1 is obsolete|| --- Comment #94 from Victor Grousset/tuxayo --- Created attachment 169111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169111&action=edit Bug 36694: Remove HC sticky from acqui/basket.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #167823|0 |1 is obsolete|| --- Comment #93 from Victor Grousset/tuxayo --- Created attachment 169110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169110&action=edit Bug 36694: Remove HC sticky from patron search searchbar Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #92 from Owen Leonard --- (In reply to Owen Leonard from comment #71) > In Firefox the result is a weird jittery effect where you can't scroll down. Today I observed this behavior in main so I guess that's just a thing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #91 from Owen Leonard --- Created attachment 167837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167837&action=edit Bug 36694: (follow-up) Remove some missed instances This patch removes some missed HCSticky code/mentions as well as the entry on the About page. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #90 from Owen Leonard --- Created attachment 167836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167836&action=edit Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #89 from Owen Leonard --- Created attachment 167835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167835&action=edit Bug 36694: (follow-up): fix pages where toolbar was not sticky Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #88 from Owen Leonard --- Created attachment 167834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167834&action=edit Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #87 from Owen Leonard --- Created attachment 167833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167833&action=edit Bug 36694: Remove HC sticky from OPAC pages Rebased-by: Victor Grousset/tuxayo Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #86 from Owen Leonard --- Created attachment 167832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167832&action=edit Bug 36694: Remove HC sticky from remaining staff pages Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #85 from Owen Leonard --- Created attachment 167831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167831&action=edit Bug 36694: Remove HC sticky from members/ pages Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #84 from Owen Leonard --- Created attachment 167830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167830&action=edit Bug 36694: Remove HC stikcy from cataloguing/ pages Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #83 from Owen Leonard --- Created attachment 167829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167829&action=edit Bug 36694: Remove HC sticky from catalogue/ pages Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #82 from Owen Leonard --- Created attachment 167828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167828&action=edit Bug 36694: Remove HC sticky from preferences.tt/authorities.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #81 from Owen Leonard --- Created attachment 167827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167827&action=edit Bug 36694: Remove HC sticky from acqui/supplier.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #80 from Owen Leonard --- Created attachment 167826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167826&action=edit Bug 36694: Set sticky element top to -1px Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #79 from Owen Leonard --- Created attachment 167825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167825&action=edit Bug 36694: Add JS observer to detect stuck sticky element Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #78 from Owen Leonard --- Created attachment 167824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167824&action=edit Bug 36694: Remove HC sticky from acqui/basket.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Owen Leonard changed: What|Removed |Added Attachment #167507|0 |1 is obsolete|| Attachment #167508|0 |1 is obsolete|| Attachment #167509|0 |1 is obsolete|| Attachment #167510|0 |1 is obsolete|| Attachment #167511|0 |1 is obsolete|| Attachment #167512|0 |1 is obsolete|| Attachment #167513|0 |1 is obsolete|| Attachment #167514|0 |1 is obsolete|| Attachment #167515|0 |1 is obsolete|| Attachment #167516|0 |1 is obsolete|| Attachment #167517|0 |1 is obsolete|| Attachment #167518|0 |1 is obsolete|| Attachment #167519|0 |1 is obsolete|| Attachment #167520|0 |1 is obsolete|| Attachment #167539|0 |1 is obsolete|| --- Comment #77 from Owen Leonard --- Created attachment 167823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167823&action=edit Bug 36694: Remove HC sticky from patron search searchbar Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #76 from Victor Grousset/tuxayo --- QA note: After looking for all occurrences of "sticky" (rg -i "sticky\b") There doesn't seem to be anything relevant related to HC Sticky left. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #75 from Victor Grousset/tuxayo --- Hey I still get the same results without the patches! :o Double checked on a sandbox. And on a 23.11 demo. And it doesn't happen in a 22.11 demo. How weird that such a specific behavior wouldn't be changed. Anyway, ready for signoff I guess. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #74 from Victor Grousset/tuxayo --- > I am unable to recreate this. Oh no it's dependent on the number of elements in the table and probably the screen size. ðŸ˜ðŸ˜ðŸ˜ And the size of each line which depends on the picked record. 🫠So here is a working (as in "failed successfully") combination. 0. Firefox 1. Add 3 times in a basket the record 279 (Linux kernel development) Shortcut: After adding once, you can hit back in the browser and click save again. 2. Apply patches and yarn build 3. While stuff builds: Enable responsive design mode on your tab (ctrl shift M or equivalent) 4. Set the viewport size to 1800x800 5. refresh page 6. You can't scroll to the bottom, it keeps glitching back up. On Chromium, Device Mode with viewport 1400x700 (mind that the zoom stays at 100% and that Chromium doesn't completely switch the DPI to better emulate mobile devices, it might fail to reproduce) And then scroll step by step and midpage the two stickies will start fighting. (with the top never being displayed before that) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Sam Lau changed: What|Removed |Added CC||sama...@gmail.com --- Comment #73 from Sam Lau --- Tested and works for me in both Chrome and Safari. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #72 from Lucas Gass --- > In Firefox the result is a weird jittery effect where you can't scroll down. I am unable to recreate this. > In Chromium there's not the jittery effect but the sticky toolbar overlaps > the sticky DataTable header. I do recreate this, in both Chrome and FF. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #71 from Owen Leonard --- (In reply to Victor Grousset/tuxayo from comment #69) > There is still comment 49 though. I think my follow-up takes care of those, but I'm leaving this as Failed QA because of an issue I saw with acqui/basket.tt. The sticky toolbar works fine until it gets to the sticky header on the DataTable. In Firefox the result is a weird jittery effect where you can't scroll down. In Chromium there's not the jittery effect but the sticky toolbar overlaps the sticky DataTable header. I assume we'll see this issue on any page that combines a sticky toolbar and a sticky DataTable header. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #70 from Owen Leonard --- Created attachment 167539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167539&action=edit Bug 36694: (follow-up) Remove some missed instances This patch removes some missed HCSticky code/mentions as well as the entry on the About page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Status|Patch doesn't apply |Failed QA --- Comment #69 from Victor Grousset/tuxayo --- Rebased. (compared the diffs with the rebased version of the conflicting commit and the original to double check that the rebase didn't introduce unwanted changes) There is still comment 49 though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166940|0 |1 is obsolete|| --- Comment #68 from Victor Grousset/tuxayo --- Created attachment 167520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167520&action=edit Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166715|0 |1 is obsolete|| --- Comment #67 from Victor Grousset/tuxayo --- Created attachment 167519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167519&action=edit Bug 36694: (follow-up): fix pages where toolbar was not sticky -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166714|0 |1 is obsolete|| --- Comment #66 from Victor Grousset/tuxayo --- Created attachment 167518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167518&action=edit Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166713|0 |1 is obsolete|| --- Comment #65 from Victor Grousset/tuxayo --- Created attachment 167517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167517&action=edit Bug 36694: Remove HC sticky from OPAC pages Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166712|0 |1 is obsolete|| --- Comment #64 from Victor Grousset/tuxayo --- Created attachment 167516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167516&action=edit Bug 36694: Remove HC sticky from remaining staff pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166711|0 |1 is obsolete|| --- Comment #63 from Victor Grousset/tuxayo --- Created attachment 167515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167515&action=edit Bug 36694: Remove HC sticky from members/ pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166710|0 |1 is obsolete|| --- Comment #62 from Victor Grousset/tuxayo --- Created attachment 167514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167514&action=edit Bug 36694: Remove HC stikcy from cataloguing/ pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166709|0 |1 is obsolete|| --- Comment #61 from Victor Grousset/tuxayo --- Created attachment 167513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167513&action=edit Bug 36694: Remove HC sticky from catalogue/ pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166708|0 |1 is obsolete|| --- Comment #60 from Victor Grousset/tuxayo --- Created attachment 167512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167512&action=edit Bug 36694: Remove HC sticky from preferences.tt/authorities.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166707|0 |1 is obsolete|| --- Comment #59 from Victor Grousset/tuxayo --- Created attachment 167511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167511&action=edit Bug 36694: Remove HC sticky from acqui/supplier.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166706|0 |1 is obsolete|| --- Comment #58 from Victor Grousset/tuxayo --- Created attachment 167510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167510&action=edit Bug 36694: Set sticky element top to -1px -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166705|0 |1 is obsolete|| --- Comment #57 from Victor Grousset/tuxayo --- Created attachment 167509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167509&action=edit Bug 36694: Add JS observer to detect stuck sticky element -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166704|0 |1 is obsolete|| --- Comment #56 from Victor Grousset/tuxayo --- Created attachment 167508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167508&action=edit Bug 36694: Remove HC sticky from acqui/basket.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #166703|0 |1 is obsolete|| --- Comment #55 from Victor Grousset/tuxayo --- Created attachment 167507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167507&action=edit Bug 36694: Remove HC sticky from patron search searchbar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Owen Leonard changed: What|Removed |Added Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo changed: What|Removed |Added Severity|normal |enhancement --- Comment #54 from Victor Grousset/tuxayo --- Ok, switching severity :) (In reply to Victor Grousset/tuxayo from comment #49) > QA notes. > > In > koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss > 88:// Sticky footer styles > > It's not related to this. (took long to confirm >_<) BTW, I meant that this is a remaining thing and that it's not a problem because it's not about HC Sticky -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #53 from Lucas Gass --- (In reply to Victor Grousset/tuxayo from comment #50) > Do we reserve enhancement severity for functional stuff. Or do refactoring > that don't fix any bug are also enhancements? I think this is an enhancement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #52 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #50) > Do we reserve enhancement severity for functional stuff. Or do refactoring > that don't fix any bug are also enhancements? I'd say that something not fixing a bug would be an enhancement, also refactorings might not be suitable for backporting unless needed for other patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #51 from David Nind --- Thanks for fixing the permissions area - this all seems to work as expected now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
