[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 Caroline Cyr La Rose changed: What|Removed |Added Resolution|--- |FIXED CC||caroline.cyr-la-rose@inlibr ||o.com Status|Needs documenting |RESOLVED --- Comment #11 from Caroline Cyr La Rose --- Bug fix, nothing to add/edit in the Koha manual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to main |Needs documenting --- Comment #10 from Fridolin Somers --- Depends on Bug 33174 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 --- Comment #9 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 --- Comment #8 from Lucas Gass --- (In reply to Emily Lamancusa from comment #7) > Thanks, Lucas! Did you mean to set this to PQA? (it's still at Signed Off) Thanks Emily, I did mean to set that to PQA. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 Lucas Gass changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 --- Comment #7 from Emily Lamancusa --- Thanks, Lucas! Did you mean to set this to PQA? (it's still at Signed Off) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 --- Comment #6 from Lucas Gass --- This looks good, fixes an obvious problem, QA scripts are happy. I feel good marking this one straight to PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 Lucas Gass changed: What|Removed |Added Attachment #165583|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 165588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165588&action=edit Bug 36701: Adjust confirmation to hide empty div To test: 1. Place a hold on any bib record 2. Cancel the hold by clicking the trash can icon next to it --> Note that there is an empty red page section in the modal 3. Apply patch and refresh the page 4. Repeat steps 1-2 --> No empty red page section 5. Confirm that the test plan from bug 33174 still works Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 Emily Lamancusa changed: What|Removed |Added Attachment #165580|0 |1 is obsolete|| --- Comment #4 from Emily Lamancusa --- Created attachment 165583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165583&action=edit Bug 36701: Adjust confirmation to hide empty div To test: 1. Place a hold on any bib record 2. Cancel the hold by clicking the trash can icon next to it --> Note that there is an empty red page section in the modal 3. Apply patch and refresh the page 4. Repeat steps 1-2 --> No empty red page section 5. Confirm that the test plan from bug 33174 still works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 --- Comment #3 from Emily Lamancusa --- Thanks for the tip, Lucas! That's good to know. I'll amend my patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 --- Comment #2 from Lucas Gass --- Thanks Emily! Previous experience has told me that the hidden attribute doesn't always work well with jQuery's show() and hide() methods. I think it might be better to use style="display:none;" here. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 Emily Lamancusa changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 --- Comment #1 from Emily Lamancusa --- Created attachment 165580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165580&action=edit Bug 36701: Adjust confirmation to hide empty div To test: 1. Place a hold on any bib record 2. Cancel the hold by clicking the trash can icon next to it --> Note that there is an empty red page section in the modal 3. Apply patch and refresh the page 4. Repeat steps 1-2 --> No empty red page section 5. Confirm that the test plan from bug 33174 still works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36701] Adjust hold confirmation to avoid showing empty div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36701 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
