[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|24.05.00,23.11.06   |24.05.00,23.11.06,23.05.12
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #20 from Lucas Gass  ---
Trivial patch, choosing to backport to 23.05.x for upcoming 23.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|24.05.00|24.05.00,23.11.06
released in||
 Status|Pushed to main  |Pushed to stable

--- Comment #19 from Fridolin Somers  ---
Easy small enhancement, backported

Pushed to 23.11.x for 23.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

--- Comment #18 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|rel_24_05_candidate |

--- Comment #17 from Katrin Fischer  ---
This is the previous patch, but with parts removed. Moving to PQA directly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_24_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

--- Comment #16 from David Nind  ---
Testing notes (using KTD):

1. Can search on the index in the search field using musical-presentation, for
example: musical-presentation:score

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

David Nind  changed:

   What|Removed |Added

 Attachment #166486|0   |1
is obsolete||

--- Comment #15 from David Nind  ---
Created attachment 166487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166487&action=edit
bug 36723: Add musical presentation to Elasticsearch index mappings

After discussing with my team this morning we agreed the best way forward given
the insight from Katrin would be to only include the addition to the index
mappings and leave the advanced search dropdown additions as a customization
for our client who requested it, due to it being more of a niche enchancement.
I have amended the patch to only include the changes to the Elasticsearch
mappings.

Testing plan:

1. Start up KTD with Elasticsearch: ktd --es8 up
2. Apply the patch and restart everything (restart_all).
3. Reset the mappings: Administration > Catalog > Search engine configuration
(Elasticsearch) > Reset mappings (at the bottom of the page)
4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev
5. Alternative to steps 3 and 4: reset_all
6. Update the visibility for 254$a in the default framework so that it is
visible in the Editor (OPAC, Staff interface should already be selected).
7. Add a new record using the default framework and put a term in 254$a, such
as 'Full score'.

Sponsored-by: Education Services Australia SCIS
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #166485|0   |1
is obsolete||

--- Comment #14 from Danyon Sewell  ---
Created attachment 166486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166486&action=edit
bug 36723: Add musical presentation to Elasticsearch index mappings

After discussing with my team this morning we agreed the best way forward given
the insight from Katrin would be to only include the addition to the index
mappings and leave the advanced search dropdown additions as a customization
for our client who requested it, due to it being more of a niche enchancement.
I have amended the patch to only include the changes to the Elasticsearch
mappings.

Testing plan:

1. Start up KTD with Elasticsearch: ktd --es8 up
2. Apply the patch and restart everything (restart_all).
3. Reset the mappings: Administration > Catalog > Search engine configuration
(Elasticsearch) > Reset mappings (at the bottom of the page)
4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev
5. Alternative to steps 3 and 4: reset_all
6. Update the visibility for 254$a in the default framework so that it is
visible in the Editor (OPAC, Staff interface should already be selected).
7. Add a new record using the default framework and put a term in 254$a, such
as 'Full score'.

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #166484|0   |1
is obsolete||

--- Comment #13 from Danyon Sewell  ---
Created attachment 166485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166485&action=edit
bug 36723: Add musical presentation to Elasticsearch index mappings

After discussing with my team this morning we agreed the best way forward given
the insight from Katrin would be to only include the addition to the index
mappings and leave the advanced search dropdown additions as a customization
for our client who requested it, due to it being more of a niche enchancement.
I have amended the patch to only include the changes to the Elasticsearch
mappings.

Testing plan:

1. Start up KTD with Elasticsearch: ktd --es8 up
2. Apply the patch and restart everything (restart_all).
3. Reset the mappings: Administration > Catalog > Search engine configuration
(Elasticsearch) > Reset mappings (at the bottom of the page)
4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev
5. Alternative to steps 3 and 4: reset_all
6. Update the visibility for 254$a in the default framework so that it is
visible in the Editor (OPAC, Staff interface should already be selected).
7. Add a new record using the default framework and put a term in 254$a, such
as 'Full score'.

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #166446|0   |1
is obsolete||

--- Comment #12 from Danyon Sewell  ---
Created attachment 166484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166484&action=edit
bug 36723: Add musical presentation to Elasticsearch index mappings

After discussing with my team this morning we agreed the best way forward given
the insight from Katrin would be to only include the addition to the index
mappings and leave the advanced search dropdown additions as a customization
for our client who requested it, due to it being more of a niche enchancement.
I have amended the patch to only include the changes to the Elasticsearch
mappings.

Testing plan:

1. Start up KTD with Elasticsearch: ktd --es8 up
2. Apply the patch and restart everything (restart_all).
3. Reset the mappings: Administration > Catalog > Search engine configuration
(Elasticsearch) > Reset mappings (at the bottom of the page)
4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev
5. Alternative to steps 3 and 4: reset_all
6. Update the visibility for 254$a in the default framework so that it is
visible in the Editor (OPAC, Staff interface should already be selected).
7. Add a new record using the default framework and put a term in 254$a, such
as 'Full score'.

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Danyon Sewell  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #166446|Bug 36723: Add musical  |bug 36723: Add musical
description|presentation to |presentation to
   |Elasticsearch index |Elasticsearch index
   |mappings|mappings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #166445|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #166093|0   |1
is obsolete||

--- Comment #11 from Danyon Sewell  ---
Created attachment 166446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166446&action=edit
Bug 36723: Add musical presentation to Elasticsearch index mappings

Apologies for the mess all, I seem to have accidentally obsoletted the previous
patches instead of writing a follow-up

This comment is intended to squash all the individual commits into one patch.
As for the index not being defined for Zebra at all, would it be worthwhile for
me to define it for zebra too?

Testing plan:

1. Start up KTD with Elasticsearch: ktd --es8 up
2. Apply the patch and restart everything (restart_all).
3. Reset the mappings: Administration > Catalog > Search engine configuration
(Elasticsearch) > Reset mappings (at the bottom of the page)
4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev
5. Alternative to steps 3 and 4: reset_all
6. Update the visibility for 254$a in the default framework so that it is
visible in the Editor (OPAC, Staff interface should already be selected).
7. Add a new record using the default framework and put a term in 254$a, such
as 'Full score'.
8. Use the advanced search. For the keyword indexes, 'Musical presentation' is
now listed.
9. Search for the term you added for the record in step 6.
10. Do this for both the Opac and Staff Client.

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

--- Comment #10 from Danyon Sewell  ---
Created attachment 166445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166445&action=edit
bug 36723: Add musical presentation to Elasticsearch index mappings

Have written a patch to allow Musical Presentation to be a search option within
Elasticsearch index mappings

Test plan:

1. Apply this patch

2. Ensure MARC index 254 (Musical Presentation) is visible to edit on the
default MARC bibliographic framework
   Koha Administration > MARC Bibliographic framework > Actions (under default
framework) > MARC structure > Search 254 and actions->edit subfield > tick box
for visibility should have OPAC, Staff Interface and Editor ticked.

3. Edit a record using the default MARC bibliographic framework and put a
search term under index 254 and save.

4. Head back to the home page and go to Advanced Search

5. under the Search for dropdown select Musical presentation and in the search
field enter the search term you used in step 3.

Your results should appear

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

--- Comment #9 from Katrin Fischer  ---
Another bigger issue why we should not add the pull-down: this index is not
defined for Zebra at all and libraries using Elastic would need to update their
mappings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #8 from Katrin Fischer  ---
Something is looking a little odd here:

1) I think some of the bugzilla comments ended up in the commit message. 
2) This advertises updating the mapping, but the patch actually adds a new
entry  to the pull down in the OPAC. I think we are missing the previous patch:
please note that patches with the exact same subject line will overwrite each
other when uploaded to bugzilla. Be always specific and mark (follow-up) as
such and describe what they are fixing.

Updating the mappings is a non-issue, but I feel this is a very specific field
that will only be interesting for some libraries that have musical holdings. A
lot of other libraries might ask to hide it. 

Maybe we could discuss separately how to handle this and limit the bug to the
Elasticsearch mapping for now?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #166091|0   |1
is obsolete||

--- Comment #7 from Danyon Sewell  ---
Created attachment 166093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166093&action=edit
Bug 36723: Add musical presentation to Elasticsearch index mappings

Thanks for the minor changes David.

For your other two points noted:

1. I think that's a bit out of scope for this enhancement, all we're really
wanting to do is add this particular index to the advanced search feature, what
your suggesting i'd assume would require a change within the xslt.

2. You're absolutely right that's my mistake, I have updated that in this
latest patch, hopefully that should be all that is required.

also going to copy your testing plan as it's much clearer than mine was :)

Testing plan:

1. Start up KTD with Elasticsearch: ktd --es8 up
2. Apply the patch and restart everything (restart_all).
3. Reset the mappings: Administration > Catalog > Search engine configuration
(Elasticsearch) > Reset mappings (at the bottom of the page)
4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev
5. Alternative to steps 3 and 4: reset_all
6. Update the visibility for 254$a in the default framework so that it is
visible in the Editor (OPAC, Staff interface should already be selected).
7. Add a new record using the default framework and put a term in 254$a, such
as 'Full score'.
8. Use the advanced search. For the keyword indexes, 'Musical presentation' is
now listed.
9. Search for the term you added for the record in step 6.
10. Do this for both the Opac and Staff Client.

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

David Nind  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |danyonsew...@catalyst.net.n
   |ity.org |z

--- Comment #6 from David Nind  ---
Added assignee

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

--- Comment #5 from David Nind  ---
I made two minor changes to the patch:
1. Bug title: "Bug" (Change to a capital B from b).
2. For the advanced search keyword title, I changed it to sentence case to
match with all the others - Musical presentation.

I did note a couple of things, but I'm not sure whether these are in scope for
this bug or are achieved some other way:
1. The 254$a is not displayed in the details page for the record on the staff
interface and OPAC, even though it is set to visible. I assume that this
requires updating something else.
2. The "Musical presentation" index does not appear as an option in the OPAC
advanced search when 'More options' is selected. 

Testing notes using KTD:

1. Start up KTD with Elasticsearch: ktd --es8 up
2. Apply the patch and restart everything (restart_all).
3. Reset the mappings: Administration > Catalog > Search engine configuration
(Elasticsearch) > Reset mappings (at the bottom of the page)
4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev
5. Alternative to steps 3 and 4: reset_all
6. Update the visibility for 254$a in the default framework so that it is
visible in the Editor (OPAC, Staff interface should already be selected).
7. Add a new record using the default framework and put a term in 254$a, such
as 'Full score'.
8. Use the advanced search. For the keyword indexes, 'Musical presentation' is
now listed.
9. Search for the term you added for the record in step 6.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Attachment #165941|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

--- Comment #4 from David Nind  ---
Created attachment 166091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166091&action=edit
Bug 36723: Add musical presentation to Elasticsearch index mappings

Have written a patch to allow Musical Presentation to be a search option within
Elasticsearch index mappings

Test plan:

1. Apply this patch

2. Ensure MARC index 254 (Musical Presentation) is visible to edit on the
default MARC bibliographic framework
   Koha Administration > MARC Bibliographic framework > Actions (under default
framework) > MARC structure > Search 254 and actions->edit subfield > tick box
for visibility should have OPAC, Staff Interface and Editor ticked.

3. Edit a record using the default MARC bibliographic framework and put a
search term under index 254 and save.

4. Head back to the home page and go to Advanced Search

5. under the Search for dropdown select Musical presentation and in the search
field enter the search term you used in step 3.

Your results should appear

Sponsored-by: Education Services Australia SCIS
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #165940|0   |1
is obsolete||

--- Comment #3 from Danyon Sewell  ---
Created attachment 165941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165941&action=edit
bug 36723: Add musical presentation to Elasticsearch index mappings

Have written a patch to allow Musical Presentation to be a search option within
Elasticsearch index mappings

Test plan:

1. Apply this patch

2. Ensure MARC index 254 (Musical Presentation) is visible to edit on the
default MARC bibliographic framework
   Koha Administration > MARC Bibliographic framework > Actions (under default
framework) > MARC structure > Search 254 and actions->edit subfield > tick box
for visibility should have OPAC, Staff Interface and Editor ticked.

3. Edit a record using the default MARC bibliographic framework and put a
search term under index 254 and save.

4. Head back to the home page and go to Advanced Search

5. under the Search for dropdown select Musical presentation and in the search
field enter the search term you used in step 3.

Your results should appear

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Danyon Sewell  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #165938|0   |1
is obsolete||

--- Comment #2 from Danyon Sewell  ---
Created attachment 165940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165940&action=edit
bug 36723: Add musical presentation to Elasticsearch index mappings

Have written a patch to allow Musical Presentation to be a search option within
Elasticsearch index mappings

Test plan:

1. Apply this patch

2. Ensure MARC index 254 (Musical Presentation) is visible to edit on the
default MARC bibliographic framework
   Koha Administration > MARC Bibliographic framework > Actions (under default
framework) > MARC structure > Search 254 and actions->edit subfield > tick box
for visibility should have OPAC, Staff Interface and Editor ticked.

3. Edit a record using the default MARC bibliographic framework and put a
search term under index 254 and save.

4. Head back to the home page and go to Advanced Search

5. under the Search for dropdown select Musical presentation and in the search
field enter the search term you used in step 3.

Your results should appear

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

--- Comment #1 from Danyon Sewell  ---
Created attachment 165938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165938&action=edit
bug 36723: Add musical presentation to Elasticsearch index mappings

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/